Review Request: Make Network Manager show signal strength in system tray also for mobile broadband connections

Discussion:

Kai Uwe Broulik

2011-10-11 16:05:29 UTC

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102827/
-----------------------------------------------------------

Review request for Network Management.

Description
-------

As I now use a Surfstick to get to the internet, I found it handy to see the signal strength right in system tray like WiFi connections do, rather than opening the popup all the time.
This patch resolves this issue by making the system tray show the signal strength as well as the access technology (Edge, umts, etc) in a similar way like Plasma Active's (fake?) mobilesignal widget does, where I also borrowed the graphics from :P
I currently only respected the Plasma SVG icon case, i.e. when you do not use SVG graphics, it uses the generic phone icon still, as we do not yet have a icon naming spec for such cases and do not have icons either, so the tooltip and popup have the generic phone icon.

I added the HSDPA and 3G strength icons to the network.svgz icon file from network manager. See attachments.

This addresses bug 283776.
http://bugs.kde.org/show_bug.cgi?id=283776

Diffs
-----

applet/networkmanager.cpp 73a9cf4
libs/internals/uiutils.cpp f90e44e

Diff: http://git.reviewboard.kde.org/r/102827/diff/diff

Testing
-------

Compiles and works okay.
It is not yet perfect but I think it is a good start.

Known issues:
- The strength indicator is only updated if you click (hover?) the system tray icon. The konsole output states that the signals "Solid::Control::ModemGsmNetworkInterface::signalQualityChanged()" do not exist (but I don't know why?) and thus not being triggered
- When not connected, there is either no icon at all (I wanted to use the no-wifi connected icon as fallback) or the 3G with 50% strength (this is weird)

Screenshots
-----------

HSDPA tray icon
http://git.reviewboard.kde.org/r/102827/s/289/

Thanks,

Kai Uwe Broulik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20111011/e63ba411/attachment-0001.html>

Lamarque Vieira Souza

2011-10-12 15:46:30 UTC

Permalink

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102827/#review7264
-----------------------------------------------------------

applet/networkmanager.cpp
<http://git.reviewboard.kde.org/r/102827/#comment6320>

remove extra space.

applet/networkmanager.cpp
<http://git.reviewboard.kde.org/r/102827/#comment6332>

this else clause is not necessary.

applet/networkmanager.cpp
<http://git.reviewboard.kde.org/r/102827/#comment6328>

add a "else" after the "}" to prevent testing the modem clause when the wifi one has already been used.

applet/networkmanager.cpp
<http://git.reviewboard.kde.org/r/102827/#comment6322>

remove extra space.

applet/networkmanager.cpp
<http://git.reviewboard.kde.org/r/102827/#comment6323>

remote extra space.

applet/networkmanager.cpp
<http://git.reviewboard.kde.org/r/102827/#comment6324>

remove extra space.

applet/networkmanager.cpp
<http://git.reviewboard.kde.org/r/102827/#comment6321>

remote extra space.

applet/networkmanager.cpp
<http://git.reviewboard.kde.org/r/102827/#comment6326>

remote extra space.

applet/networkmanager.cpp
<http://git.reviewboard.kde.org/r/102827/#comment6329>

use the variable accesstechnology instead of calling this method again.

applet/networkmanager.cpp
<http://git.reviewboard.kde.org/r/102827/#comment6327>

remove extra space.

applet/networkmanager.cpp
<http://git.reviewboard.kde.org/r/102827/#comment6330>

optimization: remove this else clause.

applet/networkmanager.cpp
<http://git.reviewboard.kde.org/r/102827/#comment6331>

optimization: remove this else clause and just add 'return QString("phone");' incondicionally.

applet/networkmanager.cpp
<http://git.reviewboard.kde.org/r/102827/#comment6337>

I do not think there is a "phone" element in the network.svgz. It must be added for this to work, unless Plasma::Svg is smart enough to search for pixmaps when there is no element.

applet/networkmanager.cpp
<http://git.reviewboard.kde.org/r/102827/#comment6325>

remove extra space.

applet/networkmanager.cpp
<http://git.reviewboard.kde.org/r/102827/#comment6333>

This test is required to prevent crashes with CDMA phones.

applet/networkmanager.cpp
<http://git.reviewboard.kde.org/r/102827/#comment6334>

signal signalQualityChanged passes an uint variable, not int. The QObject::connect does not work because of that.

applet/networkmanager.cpp
<http://git.reviewboard.kde.org/r/102827/#comment6336>

accessTechnologyChanges passes a variable of type Solid::Control::ModemInterface::AccessTechnology, not int. The QObject::connect does not work because of that.

libs/internals/uiutils.cpp
<http://git.reviewboard.kde.org/r/102827/#comment6335>

This comment is not necessary, remove it. Uutils::iconName() is for pixmap icons only, not svg.

- Lamarque Vieira Souza

Post by Kai Uwe Broulik
-----------------------------------------------------------
http://git.reviewboard.kde.org/r/102827/
-----------------------------------------------------------
(Updated Oct. 11, 2011, 4:05 p.m.)
Review request for Network Management.
Description
-------
As I now use a Surfstick to get to the internet, I found it handy to see the signal strength right in system tray like WiFi connections do, rather than opening the popup all the time.
This patch resolves this issue by making the system tray show the signal strength as well as the access technology (Edge, umts, etc) in a similar way like Plasma Active's (fake?) mobilesignal widget does, where I also borrowed the graphics from :P
I currently only respected the Plasma SVG icon case, i.e. when you do not use SVG graphics, it uses the generic phone icon still, as we do not yet have a icon naming spec for such cases and do not have icons either, so the tooltip and popup have the generic phone icon.
I added the HSDPA and 3G strength icons to the network.svgz icon file from network manager. See attachments.
This addresses bug 283776.
http://bugs.kde.org/show_bug.cgi?id=283776
Diffs
-----
applet/networkmanager.cpp 73a9cf4
libs/internals/uiutils.cpp f90e44e
Diff: http://git.reviewboard.kde.org/r/102827/diff/diff
Testing
-------
Compiles and works okay.
It is not yet perfect but I think it is a good start.
- The strength indicator is only updated if you click (hover?) the system tray icon. The konsole output states that the signals "Solid::Control::ModemGsmNetworkInterface::signalQualityChanged()" do not exist (but I don't know why?) and thus not being triggered
- When not connected, there is either no icon at all (I wanted to use the no-wifi connected icon as fallback) or the 3G with 50% strength (this is weird)
Screenshots
-----------
HSDPA tray icon
http://git.reviewboard.kde.org/r/102827/s/289/
Thanks,
Kai Uwe Broulik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20111012/7894fae7/attachment-0001.html>

Kai Uwe Broulik

2011-10-12 16:16:18 UTC

Permalink

Post by Kai Uwe Broulik

applet/networkmanager.cpp, line 198
<http://git.reviewboard.kde.org/r/102827/diff/1/?file=38580#file38580line198>
remove extra space.

Yes, sorry for the excessive white-space, I just forgot about that :) I will fix all of those ;)

Post by Kai Uwe Broulik

applet/networkmanager.cpp, line 238
<http://git.reviewboard.kde.org/r/102827/diff/1/?file=38580#file38580line238>
use the variable accesstechnology instead of calling this method again.

That thing was just there for debugging purpose, forgot to remove it.

Post by Kai Uwe Broulik

applet/networkmanager.cpp, line 248
<http://git.reviewboard.kde.org/r/102827/diff/1/?file=38580#file38580line248>
optimization: remove this else clause and just add 'return QString("phone");' incondicionally.

okay.

Post by Kai Uwe Broulik

applet/networkmanager.cpp, line 249
<http://git.reviewboard.kde.org/r/102827/diff/1/?file=38580#file38580line249>
I do not think there is a "phone" element in the network.svgz. It must be added for this to work, unless Plasma::Svg is smart enough to search for pixmaps when there is no element.

Nope, there is not. I will make up something for this case ;)

Post by Kai Uwe Broulik

applet/networkmanager.cpp, line 291
<http://git.reviewboard.kde.org/r/102827/diff/1/?file=38580#file38580line291>
This test is required to prevent crashes with CDMA phones.

okay.

Post by Kai Uwe Broulik

applet/networkmanager.cpp, line 292
<http://git.reviewboard.kde.org/r/102827/diff/1/?file=38580#file38580line292>
signal signalQualityChanged passes an uint variable, not int. The QObject::connect does not work because of that.

ah, thanks. Will change that.

Post by Kai Uwe Broulik

applet/networkmanager.cpp, line 293
<http://git.reviewboard.kde.org/r/102827/diff/1/?file=38580#file38580line293>
accessTechnologyChanges passes a variable of type Solid::Control::ModemInterface::AccessTechnology, not int. The QObject::connect does not work because of that.
libs/internals/uiutils.cpp, line 125
<http://git.reviewboard.kde.org/r/102827/diff/1/?file=38581#file38581line125>
This comment is not necessary, remove it. Uutils::iconName() is for pixmap icons only, not svg.

Okay was just thinking because the WiFi icon also has various icons for the signal strength as non-svg as well, but okay, I will just leave the "phone" here.

- Kai Uwe

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102827/#review7264
-----------------------------------------------------------

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20111012/ae3197ca/attachment-0001.html>

Lamarque Vieira Souza

2011-10-12 15:49:43 UTC

Permalink

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20111012/475efffd/attachment-0001.html>

Kai Uwe Broulik

2011-10-12 16:16:35 UTC

Permalink

Post by Kai Uwe Broulik

Post by Lamarque Vieira Souza
the network.svgz is incomplete, it still needs the bars for LTE, EDGE, GPRS. The string "3G" should be changed to "UMTS" and HSPA is not exactly the same as HSDPA.

I was yet too lazy adding them because when I change the look of one I have to change lots of bars, and I did so already four times or so but I will add the missing ones.
Okay, I just thought "3G" looks cooler than UMTS, my phone just has "G", "E", "3G" and "H" for those cases. Well HSPA is HSDPA+HSUPA and you usually use both ;) And I considered "HSDPA" too long to be properly readable in the tray icon, but I will change that.
And I am not an artist but I noticed that my Inkscape skills are not as bad as I thought *g*

- Kai Uwe

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102827/#review7265
-----------------------------------------------------------

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20111012/ced7e87c/attachment-0001.html>

Kai Uwe Broulik

2011-10-12 17:57:01 UTC

Permalink

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102827/
-----------------------------------------------------------

(Updated Oct. 12, 2011, 5:57 p.m.)

Review request for Network Management.

Changes
-------

Fully working updated patch.
Now using Enumerator instead of string comparison for accessTechnology.
Fixed signals, so the strength is updated instantly.
Indentation/White-spaces fixed

One thing to note: When I disconnect it, the icon changes to "UMTS" instead of blank or no access technology or whatever, I do think this is an issue in ModemManager that it does not reset the AccessTechnology when disconnected or so, other than that it works.

Description
-------

As I now use a Surfstick to get to the internet, I found it handy to see the signal strength right in system tray like WiFi connections do, rather than opening the popup all the time.
This patch resolves this issue by making the system tray show the signal strength as well as the access technology (Edge, umts, etc) in a similar way like Plasma Active's (fake?) mobilesignal widget does, where I also borrowed the graphics from :P
I currently only respected the Plasma SVG icon case, i.e. when you do not use SVG graphics, it uses the generic phone icon still, as we do not yet have a icon naming spec for such cases and do not have icons either, so the tooltip and popup have the generic phone icon.

I added the HSDPA and 3G strength icons to the network.svgz icon file from network manager. See attachments.

This addresses bug 283776.
http://bugs.kde.org/show_bug.cgi?id=283776

Diffs (updated)
-----

applet/networkmanager.cpp 73a9cf4

Diff: http://git.reviewboard.kde.org/r/102827/diff/diff

Testing
-------

Compiles and works okay.
It is not yet perfect but I think it is a good start.

Known issues:
- The strength indicator is only updated if you click (hover?) the system tray icon. The konsole output states that the signals "Solid::Control::ModemGsmNetworkInterface::signalQualityChanged()" do not exist (but I don't know why?) and thus not being triggered
- When not connected, there is either no icon at all (I wanted to use the no-wifi connected icon as fallback) or the 3G with 50% strength (this is weird)

Screenshots
-----------

HSDPA tray icon
http://git.reviewboard.kde.org/r/102827/s/289/

Thanks,

Kai Uwe Broulik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20111012/44313f41/attachment-0001.html>

Kai Uwe Broulik

2011-10-12 17:58:44 UTC

Permalink

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102827/
-----------------------------------------------------------

(Updated Oct. 12, 2011, 5:58 p.m.)

Review request for Network Management.

Changes
-------

Reworked the indicator to be a "staircase"-like indicator and it now features indicators for all access technologies (HSPA, HSUPA, HSDPA, UMTS, EDGE, GPRS)

Description
-------

As I now use a Surfstick to get to the internet, I found it handy to see the signal strength right in system tray like WiFi connections do, rather than opening the popup all the time.
This patch resolves this issue by making the system tray show the signal strength as well as the access technology (Edge, umts, etc) in a similar way like Plasma Active's (fake?) mobilesignal widget does, where I also borrowed the graphics from :P
I currently only respected the Plasma SVG icon case, i.e. when you do not use SVG graphics, it uses the generic phone icon still, as we do not yet have a icon naming spec for such cases and do not have icons either, so the tooltip and popup have the generic phone icon.

I added the HSDPA and 3G strength icons to the network.svgz icon file from network manager. See attachments.

This addresses bug 283776.
http://bugs.kde.org/show_bug.cgi?id=283776

Diffs
-----

applet/networkmanager.cpp 73a9cf4

Diff: http://git.reviewboard.kde.org/r/102827/diff/diff

Testing
-------

Compiles and works okay.
It is not yet perfect but I think it is a good start.

Known issues:
- The strength indicator is only updated if you click (hover?) the system tray icon. The konsole output states that the signals "Solid::Control::ModemGsmNetworkInterface::signalQualityChanged()" do not exist (but I don't know why?) and thus not being triggered
- When not connected, there is either no icon at all (I wanted to use the no-wifi connected icon as fallback) or the 3G with 50% strength (this is weird)

Screenshots
-----------

HSDPA tray icon
http://git.reviewboard.kde.org/r/102827/s/289/

Thanks,

Kai Uwe Broulik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20111012/726d9ea0/attachment-0001.html>

Lamarque Vieira Souza

2011-10-12 19:30:17 UTC

Permalink

Post by Kai Uwe Broulik
-----------------------------------------------------------
http://git.reviewboard.kde.org/r/102827/
-----------------------------------------------------------
(Updated Oct. 12, 2011, 5:58 p.m.)
Review request for Network Management.
Description
-------
As I now use a Surfstick to get to the internet, I found it handy to see the signal strength right in system tray like WiFi connections do, rather than opening the popup all the time.
This patch resolves this issue by making the system tray show the signal strength as well as the access technology (Edge, umts, etc) in a similar way like Plasma Active's (fake?) mobilesignal widget does, where I also borrowed the graphics from :P
I currently only respected the Plasma SVG icon case, i.e. when you do not use SVG graphics, it uses the generic phone icon still, as we do not yet have a icon naming spec for such cases and do not have icons either, so the tooltip and popup have the generic phone icon.
I added the HSDPA and 3G strength icons to the network.svgz icon file from network manager. See attachments.
This addresses bug 283776.
http://bugs.kde.org/show_bug.cgi?id=283776
Diffs
-----
applet/networkmanager.cpp 73a9cf4
Diff: http://git.reviewboard.kde.org/r/102827/diff/diff
Testing
-------
Compiles and works okay.
It is not yet perfect but I think it is a good start.
- The strength indicator is only updated if you click (hover?) the system tray icon. The konsole output states that the signals "Solid::Control::ModemGsmNetworkInterface::signalQualityChanged()" do not exist (but I don't know why?) and thus not being triggered
- When not connected, there is either no icon at all (I wanted to use the no-wifi connected icon as fallback) or the 3G with 50% strength (this is weird)
Screenshots
-----------
HSDPA tray icon
http://git.reviewboard.kde.org/r/102827/s/289/
Thanks,
Kai Uwe Broulik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20111012/f032566e/attachment.html>

Kai Uwe Broulik

2011-10-13 08:38:11 UTC

Permalink

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102827/
-----------------------------------------------------------

(Updated Oct. 13, 2011, 8:38 a.m.)

Review request for Network Management.

Changes
-------

Updated Diff so it can be applied to current nm09 branch.

Description
-------

As I now use a Surfstick to get to the internet, I found it handy to see the signal strength right in system tray like WiFi connections do, rather than opening the popup all the time.
This patch resolves this issue by making the system tray show the signal strength as well as the access technology (Edge, umts, etc) in a similar way like Plasma Active's (fake?) mobilesignal widget does, where I also borrowed the graphics from :P
I currently only respected the Plasma SVG icon case, i.e. when you do not use SVG graphics, it uses the generic phone icon still, as we do not yet have a icon naming spec for such cases and do not have icons either, so the tooltip and popup have the generic phone icon.

I added the HSDPA and 3G strength icons to the network.svgz icon file from network manager. See attachments.

This addresses bug 283776.
http://bugs.kde.org/show_bug.cgi?id=283776

Diffs (updated)
-----

applet/networkmanager.cpp 8c2dc2e

Diff: http://git.reviewboard.kde.org/r/102827/diff/diff

Testing
-------

Compiles and works okay.
It is not yet perfect but I think it is a good start.

Known issues:
- The strength indicator is only updated if you click (hover?) the system tray icon. The konsole output states that the signals "Solid::Control::ModemGsmNetworkInterface::signalQualityChanged()" do not exist (but I don't know why?) and thus not being triggered
- When not connected, there is either no icon at all (I wanted to use the no-wifi connected icon as fallback) or the 3G with 50% strength (this is weird)

Screenshots
-----------

HSDPA tray icon
http://git.reviewboard.kde.org/r/102827/s/289/

Thanks,

Kai Uwe Broulik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20111013/b166fb54/attachment-0001.html>

Lamarque Vieira Souza

2011-10-13 17:32:13 UTC

Permalink

Post by Kai Uwe Broulik
-----------------------------------------------------------
http://git.reviewboard.kde.org/r/102827/
-----------------------------------------------------------
(Updated Oct. 13, 2011, 8:38 a.m.)
Review request for Network Management.
Description
-------
As I now use a Surfstick to get to the internet, I found it handy to see the signal strength right in system tray like WiFi connections do, rather than opening the popup all the time.
This patch resolves this issue by making the system tray show the signal strength as well as the access technology (Edge, umts, etc) in a similar way like Plasma Active's (fake?) mobilesignal widget does, where I also borrowed the graphics from :P
I currently only respected the Plasma SVG icon case, i.e. when you do not use SVG graphics, it uses the generic phone icon still, as we do not yet have a icon naming spec for such cases and do not have icons either, so the tooltip and popup have the generic phone icon.
I added the HSDPA and 3G strength icons to the network.svgz icon file from network manager. See attachments.
This addresses bug 283776.
http://bugs.kde.org/show_bug.cgi?id=283776
Diffs
-----
applet/networkmanager.cpp 8c2dc2e
Diff: http://git.reviewboard.kde.org/r/102827/diff/diff
Testing
-------
Compiles and works okay.
It is not yet perfect but I think it is a good start.
- The strength indicator is only updated if you click (hover?) the system tray icon. The konsole output states that the signals "Solid::Control::ModemGsmNetworkInterface::signalQualityChanged()" do not exist (but I don't know why?) and thus not being triggered
- When not connected, there is either no icon at all (I wanted to use the no-wifi connected icon as fallback) or the 3G with 50% strength (this is weird)
Screenshots
-----------
HSDPA tray icon
http://git.reviewboard.kde.org/r/102827/s/289/
Thanks,
Kai Uwe Broulik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20111013/e61e61be/attachment-0001.html>

Kai Uwe Broulik

2011-10-14 19:04:11 UTC

Permalink

Post by Kai Uwe Broulik

Post by Lamarque Vieira Souza
The patch works, but the icon for unknown access technology is too similar to nm-applet's wifi icon and may cause confusion. Maybe we should add an interrogation sign (?) to indicate the unknown access technology.

I think it's common fashion to have that antenna with "rounded waves" as WiFi icon and the staircase bars as mobile, it's found that way on most (if not all) smartphones.
Concerning that access technology: I did not want to confuse users with unneccessary details, I think people don't care about access technology. If it is known, it will be displayed, if it is not known, I doubt it would do anything except for adding clutter/distraction if there was a question mark at that position.

- Kai Uwe

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102827/#review7290
-----------------------------------------------------------

Post by Kai Uwe Broulik
-----------------------------------------------------------
http://git.reviewboard.kde.org/r/102827/
-----------------------------------------------------------
(Updated Oct. 13, 2011, 8:38 a.m.)
Review request for Network Management.
Description
-------
As I now use a Surfstick to get to the internet, I found it handy to see the signal strength right in system tray like WiFi connections do, rather than opening the popup all the time.
This patch resolves this issue by making the system tray show the signal strength as well as the access technology (Edge, umts, etc) in a similar way like Plasma Active's (fake?) mobilesignal widget does, where I also borrowed the graphics from :P
I currently only respected the Plasma SVG icon case, i.e. when you do not use SVG graphics, it uses the generic phone icon still, as we do not yet have a icon naming spec for such cases and do not have icons either, so the tooltip and popup have the generic phone icon.
I added the HSDPA and 3G strength icons to the network.svgz icon file from network manager. See attachments.
This addresses bug 283776.
http://bugs.kde.org/show_bug.cgi?id=283776
Diffs
-----
applet/networkmanager.cpp 8c2dc2e
Diff: http://git.reviewboard.kde.org/r/102827/diff/diff
Testing
-------
Compiles and works okay.
It is not yet perfect but I think it is a good start.
- The strength indicator is only updated if you click (hover?) the system tray icon. The konsole output states that the signals "Solid::Control::ModemGsmNetworkInterface::signalQualityChanged()" do not exist (but I don't know why?) and thus not being triggered
- When not connected, there is either no icon at all (I wanted to use the no-wifi connected icon as fallback) or the 3G with 50% strength (this is weird)
Screenshots
-----------
HSDPA tray icon
http://git.reviewboard.kde.org/r/102827/s/289/
Thanks,
Kai Uwe Broulik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20111014/84afc554/attachment-0001.html>

Commit Hook

2011-10-15 23:28:21 UTC

Permalink

Post by Kai Uwe Broulik
-----------------------------------------------------------
http://git.reviewboard.kde.org/r/102827/
-----------------------------------------------------------
(Updated Oct. 13, 2011, 8:38 a.m.)
Review request for Network Management.
Description
-------
As I now use a Surfstick to get to the internet, I found it handy to see the signal strength right in system tray like WiFi connections do, rather than opening the popup all the time.
This patch resolves this issue by making the system tray show the signal strength as well as the access technology (Edge, umts, etc) in a similar way like Plasma Active's (fake?) mobilesignal widget does, where I also borrowed the graphics from :P
I currently only respected the Plasma SVG icon case, i.e. when you do not use SVG graphics, it uses the generic phone icon still, as we do not yet have a icon naming spec for such cases and do not have icons either, so the tooltip and popup have the generic phone icon.
I added the HSDPA and 3G strength icons to the network.svgz icon file from network manager. See attachments.
This addresses bug 283776.
http://bugs.kde.org/show_bug.cgi?id=283776
Diffs
-----
applet/networkmanager.cpp 8c2dc2e
Diff: http://git.reviewboard.kde.org/r/102827/diff/diff
Testing
-------
Compiles and works okay.
It is not yet perfect but I think it is a good start.
- The strength indicator is only updated if you click (hover?) the system tray icon. The konsole output states that the signals "Solid::Control::ModemGsmNetworkInterface::signalQualityChanged()" do not exist (but I don't know why?) and thus not being triggered
- When not connected, there is either no icon at all (I wanted to use the no-wifi connected icon as fallback) or the 3G with 50% strength (this is weird)
Screenshots
-----------
HSDPA tray icon
http://git.reviewboard.kde.org/r/102827/s/289/
Thanks,
Kai Uwe Broulik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20111015/2fd97af5/attachment.html>