Discussion:
Review Request: libnm-qt requires libnm-glib to be built
Ralf Jung
2012-03-06 11:31:22 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104171/
-----------------------------------------------------------

Review request for Network Management and Lamarque Vieira Souza.


Description
-------

libnm-qt requires libnm-glib to be built, so cmake should check its existence.


Diffs
-----

CMakeLists.txt ef7ea12
FindNetworkManager.cmake ced2017

Diff: http://git.reviewboard.kde.org/r/104171/diff/


Testing
-------

* without libnm-glib installed, cmake now complains (instead of cmake completing successfully, and the build failing later, which was the case before)
* with libnm-glib installed, compilation works fine


Thanks,

Ralf Jung

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20120306/18a3c979/attachment.html>
Commit Hook
2012-03-16 16:21:21 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104171/#review11484
-----------------------------------------------------------


This review has been submitted with commit 6a52335473771bb3a83262e63806356dcdd415c8 by Lamarque V. Souza to branch master.

- Commit Hook
Post by Ralf Jung
-----------------------------------------------------------
http://git.reviewboard.kde.org/r/104171/
-----------------------------------------------------------
(Updated March 6, 2012, 11:31 a.m.)
Review request for Network Management and Lamarque Vieira Souza.
Description
-------
libnm-qt requires libnm-glib to be built, so cmake should check its existence.
Diffs
-----
CMakeLists.txt ef7ea12
FindNetworkManager.cmake ced2017
Diff: http://git.reviewboard.kde.org/r/104171/diff/
Testing
-------
* without libnm-glib installed, cmake now complains (instead of cmake completing successfully, and the build failing later, which was the case before)
* with libnm-glib installed, compilation works fine
Thanks,
Ralf Jung
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20120316/ae262394/attachment.html>
Loading...