Discussion:
Review Request: vpnc: fix storing/loading of secrets type
Andrey Borzenkov
2011-03-14 18:30:38 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100857/
-----------------------------------------------------------

Review request for Network Management.


Summary
-------

secretsType is expected to have the same keys as secrets themselves.
vpnc was erroneously using old setting names for them, so secrets
were always saved even if user requested type "do not save" in config.

Group storage type was always ignored due to copy'n'paste error


Diffs
-----

vpnplugins/vpnc/vpncauth.cpp eeeb00d
vpnplugins/vpnc/vpncwidget.cpp 71c828b

Diff: http://git.reviewboard.kde.org/r/100857/diff


Testing
-------

Tested with current GIT master.


Thanks,

Andrey

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-networkmanager/attachments/20110314/cc190d0c/attachment.htm
Lamarque Vieira Souza
2011-03-14 18:47:49 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100857/#review1948
-----------------------------------------------------------



vpnplugins/vpnc/vpncauth.cpp
<http://git.reviewboard.kde.org/r/100857/#comment1638>

Does this patch fix http://bugs.kde.org/241798 ? If so could you please add that bug in your review request's header?


- Lamarque Vieira
Post by Andrey Borzenkov
-----------------------------------------------------------
http://git.reviewboard.kde.org/r/100857/
-----------------------------------------------------------
(Updated March 14, 2011, 6:30 p.m.)
Review request for Network Management.
Summary
-------
secretsType is expected to have the same keys as secrets themselves.
vpnc was erroneously using old setting names for them, so secrets
were always saved even if user requested type "do not save" in config.
Group storage type was always ignored due to copy'n'paste error
Diffs
-----
vpnplugins/vpnc/vpncauth.cpp eeeb00d
vpnplugins/vpnc/vpncwidget.cpp 71c828b
Diff: http://git.reviewboard.kde.org/r/100857/diff
Testing
-------
Tested with current GIT master.
Thanks,
Andrey
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-networkmanager/attachments/20110314/6ebc6a9e/attachment.htm
Sebastian Kügler
2011-03-15 10:33:45 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100857/#review1964
-----------------------------------------------------------

Ship it!


- Sebastian
Post by Andrey Borzenkov
-----------------------------------------------------------
http://git.reviewboard.kde.org/r/100857/
-----------------------------------------------------------
(Updated March 14, 2011, 6:30 p.m.)
Review request for Network Management.
Summary
-------
secretsType is expected to have the same keys as secrets themselves.
vpnc was erroneously using old setting names for them, so secrets
were always saved even if user requested type "do not save" in config.
Group storage type was always ignored due to copy'n'paste error
Diffs
-----
vpnplugins/vpnc/vpncauth.cpp eeeb00d
vpnplugins/vpnc/vpncwidget.cpp 71c828b
Diff: http://git.reviewboard.kde.org/r/100857/diff
Testing
-------
Tested with current GIT master.
Thanks,
Andrey
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-networkmanager/attachments/20110315/e469b716/attachment.htm
Loading...