libnm-qt: addConnection QUuid bug?

[Christophe Oosterlynck]

Hi,

I just started using libnm-qt. I want to add a new connection using
NetworkManager::Settings::addConnection(...). This returns a string = uuid.
This should probably be used when reacting to the connectionAddComplete()
signal to check which connection request it is about. The id returned by
addConnection() is always 0...0. Shouldn't QUuid::CreateUuid().toString()
[1] be used instead of QUuid().toString() [2]?

[1] http://qt-project.org/doc/qt-4.8/quuid.html#createUuid
[2]
https://projects.kde.org/projects/kdereview/libnm-qt/repository/revisions/master/entry/settings.cpp#L79

Best regards,

Christophe
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20120803/63842939/attachment.html>

[Lamarque V. Souza]

Post by Christophe Oosterlynck
Hi,

Hi,

Post by Christophe Oosterlynck
I just started using libnm-qt. I want to add a new connection using
NetworkManager::Settings::addConnection(...). This returns a string = uuid.
This should probably be used when reacting to the connectionAddComplete()
signal to check which connection request it is about. The id returned by
addConnection() is always 0...0. Shouldn't QUuid::CreateUuid().toString()

I have fixed this problem but keep in mind that the part of the code is
not tested yet. I still need to port the DBus parsing code from Plasma NM to
libnm-qt so that we do not need to parse the QVariantMapMap all the time like
I did in this case. If you want to test the part of the code keep sending the
problem that I will try to fix them.

[1] http://lamarque-lvs.blogspot.com/2012/07/improving-qtnetworkmanager-
former-libnm.html