Discussion:
Review Request: Use KStandardDirs to find openvpn binary
Rajeesh K Nambiar
2011-06-09 11:02:06 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101553/
-----------------------------------------------------------

Review request for Network Management.


Summary
-------

Make use of KStandardDirs::findExe to locate openvpn binary instead of hard-coding.


Diffs
-----

vpnplugins/openvpn/openvpnwidget.cpp 0e59277

Diff: http://git.reviewboard.kde.org/r/101553/diff


Testing
-------

Tested against NM-0.8.4


Thanks,

Rajeesh

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-networkmanager/attachments/20110609/4e4ca17c/attachment.htm
Commit Hook
2011-06-09 20:09:43 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101553/#review3809
-----------------------------------------------------------


This review has been submitted with commit 9e6c55228b9f5aa3ab8da1414e787fb76c96478f by Lamarque V. Souza.

- Commit
Post by Rajeesh K Nambiar
-----------------------------------------------------------
http://git.reviewboard.kde.org/r/101553/
-----------------------------------------------------------
(Updated June 9, 2011, 11:02 a.m.)
Review request for Network Management.
Summary
-------
Make use of KStandardDirs::findExe to locate openvpn binary instead of hard-coding.
Diffs
-----
vpnplugins/openvpn/openvpnwidget.cpp 0e59277
Diff: http://git.reviewboard.kde.org/r/101553/diff
Testing
-------
Tested against NM-0.8.4
Thanks,
Rajeesh
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-networkmanager/attachments/20110609/149874ce/attachment.htm
Loading...