Review Request: Improve Wireless Auth dialog

Discussion:

David Edmundson

2012-09-13 09:52:11 UTC

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106437/
-----------------------------------------------------------

Review request for Network Management.

Description
-------

Fix a bug in which the wireless password prompt dialog would be shown at an incorrect size

Added a title and icon to the dialog so that it's clear when it pops up to the
user what the prompt is for.

Diffs
-----

libs/ui/CMakeLists.txt 42ae858
libs/ui/security/wirelesssecurityauth.cpp b61d14a
libs/ui/security/wirelesssecurityauth.ui PRE-CREATION

Diff: http://git.reviewboard.kde.org/r/106437/diff/

Testing
-------

Tested with multiple WPA and WEP connections.

Screenshots
-----------

After
http://git.reviewboard.kde.org/r/106437/s/726/
Before
http://git.reviewboard.kde.org/r/106437/s/727/

Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20120913/8b4eda33/attachment.html>

Sebastian Kügler

2012-09-15 13:15:51 UTC

Permalink

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106437/#review18995
-----------------------------------------------------------

Ship it!

Nice improvement. That one has been bugging me for a while, too. Bonus points for removing a C++ layout and moving it into a .ui.

- Sebastian K?gler

Post by David Edmundson
-----------------------------------------------------------
http://git.reviewboard.kde.org/r/106437/
-----------------------------------------------------------
(Updated Sept. 13, 2012, 9:52 a.m.)
Review request for Network Management.
Description
-------
Fix a bug in which the wireless password prompt dialog would be shown at an incorrect size
Added a title and icon to the dialog so that it's clear when it pops up to the
user what the prompt is for.
Diffs
-----
libs/ui/CMakeLists.txt 42ae858
libs/ui/security/wirelesssecurityauth.cpp b61d14a
libs/ui/security/wirelesssecurityauth.ui PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/106437/diff/
Testing
-------
Tested with multiple WPA and WEP connections.
Screenshots
-----------
After
http://git.reviewboard.kde.org/r/106437/s/726/
Before
http://git.reviewboard.kde.org/r/106437/s/727/
Thanks,
David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20120915/49739fa7/attachment.html>

Lamarque Vieira Souza

2012-09-15 17:41:01 UTC

Permalink

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106437/#review19002
-----------------------------------------------------------

libs/ui/security/wirelesssecurityauth.cpp
<http://git.reviewboard.kde.org/r/106437/#comment15087>

move this include to after #include "wpaauthwidget.h"

libs/ui/security/wirelesssecurityauth.cpp
<http://git.reviewboard.kde.org/r/106437/#comment15086>

Use i18nc here with "@title:window" as first parameter.

libs/ui/security/wirelesssecurityauth.cpp
<http://git.reviewboard.kde.org/r/106437/#comment15088>

Use IconSize(KIconLoader::Dialog) instead of hard-coded value 60.

libs/ui/security/wirelesssecurityauth.cpp
<http://git.reviewboard.kde.org/r/106437/#comment15085>

how is this QWidget deallocated if you are not passing a parent?

- Lamarque Vieira Souza

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20120915/5eead8b1/attachment-0001.html>

Commit Hook

2012-09-16 23:00:55 UTC

Permalink

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106437/#review19045
-----------------------------------------------------------

This review has been submitted with commit b90de8c9ea12b2e1a455a229629fe802d0667e48 by David Edmundson to branch master.

- Commit Hook

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20120916/52fa2e3b/attachment.html>

Commit Hook

2012-09-16 23:00:55 UTC

Permalink

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106437/#review19045
-----------------------------------------------------------

This review has been submitted with commit 5ad8668dcba714fff7799ab48b00706709b0dd8f by David Edmundson to branch master.

- Commit Hook

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20120916/2c2014ec/attachment.html>

Commit Hook

2012-09-16 23:20:27 UTC

Permalink

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106437/#review19046
-----------------------------------------------------------

This review has been submitted with commit aa4705107cc154189318169cd113cc6b6b26ad3c by David Edmundson to branch nm09.

- Commit Hook

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20120916/fc08c0cb/attachment.html>

Commit Hook

2012-09-16 23:20:28 UTC

Permalink

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106437/#review19047
-----------------------------------------------------------

This review has been submitted with commit e5b08ce15babf45609e01987b914bca0ce30107b by David Edmundson to branch nm09.

- Commit Hook

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20120916/c07ea286/attachment-0001.html>