Review Request 126035: [plasma-nm] Add --import-vpn argument to connection editor

[Jan Grulich]

Ship It!

Btw. there is already a bug opened for .ovpn files association ? https://bugs.kde.org/show_bug.cgi?id=350413


- Jan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126035/#review88280
-----------------------------------------------------------

-----------------------------------------------------------
https://git.reviewboard.kde.org/r/126035/
-----------------------------------------------------------
(Updated Lis. 11, 2015, 10:31 odp.)
Review request for Network Management and Jan Grulich.
Repository: plasma-nm
Description
-------
This could allow us to associate .ovpn files (and potentially other vpn configuration files) and have double clicking them set them up automatically
Diffs
-----
editor/connectioneditor.h 5f68117
editor/connectioneditor.cpp 0eaeafe
editor/main.cpp a5ec1e2
Diff: https://git.reviewboard.kde.org/r/126035/diff/
Testing
-------
Ran kde5-nm-connection-editor --import-vn ~/foo.openvpn, got asked whether I wanted to copy that to some other folder, and then the connection was created.
Also, while at it I added the help and version command line parameters
Thanks,
Kai Uwe Broulik

[Kai Uwe Broulik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126035/
-----------------------------------------------------------

Review request for Network Management and Jan Grulich.


Repository: plasma-nm


Description
-------

This could allow us to associate .ovpn files (and potentially other vpn configuration files) and have double clicking them set them up automatically


Diffs
-----

editor/connectioneditor.h 5f68117
editor/connectioneditor.cpp 0eaeafe
editor/main.cpp a5ec1e2

Diff: https://git.reviewboard.kde.org/r/126035/diff/


Testing
-------

Ran kde5-nm-connection-editor --import-vn ~/foo.openvpn, got asked whether I wanted to copy that to some other folder, and then the connection was created.

Also, while at it I added the help and version command line parameters


Thanks,

Kai Uwe Broulik

[Kai Uwe Broulik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126035/
-----------------------------------------------------------

(Updated Nov. 16, 2015, 8:21 p.m.)


Status
------

This change has been marked as submitted.


Review request for Network Management and Jan Grulich.


Changes
-------

Submitted with commit 8515b1b1809c12e56e89a5fcffd63cb834c13dcd by Kai Uwe Broulik to branch master.


Repository: plasma-nm


Description
-------

This could allow us to associate .ovpn files (and potentially other vpn configuration files) and have double clicking them set them up automatically


Diffs
-----

editor/connectioneditor.h 5f68117
editor/connectioneditor.cpp 0eaeafe
editor/main.cpp a5ec1e2

Diff: https://git.reviewboard.kde.org/r/126035/diff/


Testing
-------

Ran kde5-nm-connection-editor --import-vn ~/foo.openvpn, got asked whether I wanted to copy that to some other folder, and then the connection was created.

Also, while at it I added the help and version command line parameters


Thanks,

Kai Uwe Broulik

[Kai Uwe Broulik]

Post by Jan Grulich

Ship It!

Btw. there is already a bug opened for .ovpn files association ? https://bugs.kde.org/show_bug.cgi?id=350413

Yes, this patch is a prerequisite for this but the actual association has to be done differently. I don't even see a ovpn in shared-mime-data. We would need to ship another .desktop file for connection editor too.


- Kai Uwe


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126035/#review88280
-----------------------------------------------------------

Post by Jan Grulich
-----------------------------------------------------------
https://git.reviewboard.kde.org/r/126035/
-----------------------------------------------------------
(Updated Nov. 11, 2015, 10:31 nachm.)
Review request for Network Management and Jan Grulich.
Repository: plasma-nm
Description
-------
This could allow us to associate .ovpn files (and potentially other vpn configuration files) and have double clicking them set them up automatically
Diffs
-----
editor/connectioneditor.h 5f68117
editor/connectioneditor.cpp 0eaeafe
editor/main.cpp a5ec1e2
Diff: https://git.reviewboard.kde.org/r/126035/diff/
Testing
-------
Ran kde5-nm-connection-editor --import-vn ~/foo.openvpn, got asked whether I wanted to copy that to some other folder, and then the connection was created.
Also, while at it I added the help and version command line parameters
Thanks,
Kai Uwe Broulik