Review Request: Don’t show Access technology in tray icon while connecting as it obscures the connecting progress bar

Discussion:

Lamarque Vieira Souza

2012-01-30 17:18:34 UTC

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103828/#review10237
-----------------------------------------------------------

applet/networkmanager.cpp
<http://git.reviewboard.kde.org/r/103828/#comment8431>

remove trailing whitespace.

applet/networkmanager.cpp
<http://git.reviewboard.kde.org/r/103828/#comment8432>

this call type is known for freezing the entire plasma desktop. I need to re-implement it before you can use it here.

I also need to simplify this method. There are too many if's and switch's there.

- Lamarque Vieira Souza

-----------------------------------------------------------
http://git.reviewboard.kde.org/r/103828/
-----------------------------------------------------------
(Updated Jan. 30, 2012, 4:03 p.m.)
Review request for Network Management and Lamarque Vieira Souza.
Description
-------
On the KDE 4.8 release party some people argued that the access technology that is displayed below the signal strength bars makes the "connecting progress bar" hard to spot. This resolves this by hiding the access technology when not fully connected, i.e. when the bar is visible.
Also, my modem did always announce "UMTS" access technology and only when it is fully connected, then it changes to whatever HSDPA or GPRS is used.
You need the attached network2.svgz to have the appropriate icons for the above case.
Diffs
-----
applet/networkmanager.cpp e75f2d5
Diff: http://git.reviewboard.kde.org/r/103828/diff/diff
Testing
-------
Works as expected. When connecting, only the signal strength is shown but no access technology.
Thanks,
Kai Uwe Broulik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20120130/cb992e83/attachment.html>

Lamarque Vieira Souza

2012-01-30 18:57:46 UTC

Permalink

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103828/#review10248
-----------------------------------------------------------

applet/networkmanager.cpp
<http://git.reviewboard.kde.org/r/103828/#comment8441>

I think is the misspelling you talked about, right?

applet/networkmanager.cpp
<http://git.reviewboard.kde.org/r/103828/#comment8442>

I fixed this misspelling a hour ago. Update the git repo first when creating the next patch.

- Lamarque Vieira Souza

Post by Lamarque Vieira Souza
-----------------------------------------------------------
http://git.reviewboard.kde.org/r/103828/
-----------------------------------------------------------
(Updated Jan. 30, 2012, 6:50 p.m.)
Review request for Network Management and Lamarque Vieira Souza.
Description
-------
On the KDE 4.8 release party some people argued that the access technology that is displayed below the signal strength bars makes the "connecting progress bar" hard to spot. This resolves this by hiding the access technology when not fully connected, i.e. when the bar is visible.
Also, my modem did always announce "UMTS" access technology and only when it is fully connected, then it changes to whatever HSDPA or GPRS is used.
You need the attached network2.svgz to have the appropriate icons for the above case.
Diffs
-----
applet/networkmanager.cpp e75f2d5
Diff: http://git.reviewboard.kde.org/r/103828/diff/diff
Testing
-------
Works as expected. When connecting, only the signal strength is shown but no access technology.
Thanks,
Kai Uwe Broulik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20120130/10f41a46/attachment.html>

Commit Hook

2012-01-30 20:07:04 UTC

Permalink

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103828/#review10249
-----------------------------------------------------------

This review has been submitted with commit e3a5cb786f3e9cc931fc77903bcd42607dc83e3d by Lamarque V. Souza to branch master.

- Commit Hook

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20120130/b90e1f11/attachment-0001.html>

Commit Hook

2012-01-30 20:07:10 UTC

Permalink

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103828/#review10250
-----------------------------------------------------------

This review has been submitted with commit 11314591fa52dbdaabd88cbb305f47c5d9982c88 by Lamarque V. Souza to branch nm09.

- Commit Hook

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20120130/b0eed15d/attachment.html>

Kai Uwe Broulik

2012-01-30 15:39:54 UTC

Permalink

Kai Uwe Broulik

2012-01-30 16:03:00 UTC

Permalink

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103828/
-----------------------------------------------------------

(Updated Jan. 30, 2012, 4:03 p.m.)

Review request for Network Management and Lamarque Vieira Souza.

Changes
-------

Corrected and added some missing stuff:
- When disconnected it falls back to the generic cellphone icon instead of the empty bars with the space that is actually meant for the progress bar
- When technology unknown or gprs and no signal strength available it keeps the cellphone icon while connecting (makes code a bit dirty unfortunately) to avoid flickering, i.e. changing from the cellphone icon to the empty signal bars while connecting and back to the cellphone when connected

Description
-------

On the KDE 4.8 release party some people argued that the access technology that is displayed below the signal strength bars makes the "connecting progress bar" hard to spot. This resolves this by hiding the access technology when not fully connected, i.e. when the bar is visible.
Also, my modem did always announce "UMTS" access technology and only when it is fully connected, then it changes to whatever HSDPA or GPRS is used.

You need the attached network2.svgz to have the appropriate icons for the above case.

Diffs (updated)
-----

applet/networkmanager.cpp e75f2d5

Diff: http://git.reviewboard.kde.org/r/103828/diff/diff

Testing
-------

Works as expected. When connecting, only the signal strength is shown but no access technology.

Thanks,

Kai Uwe Broulik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20120130/8b398238/attachment.html>

Kai Uwe Broulik

2012-01-30 18:50:25 UTC

Permalink

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103828/
-----------------------------------------------------------

(Updated Jan. 30, 2012, 6:50 p.m.)

Review request for Network Management and Lamarque Vieira Souza.

Changes
-------

Patch by Lamarque V. Souza based on my initial patch (typos fixed).

Description
-------

On the KDE 4.8 release party some people argued that the access technology that is displayed below the signal strength bars makes the "connecting progress bar" hard to spot. This resolves this by hiding the access technology when not fully connected, i.e. when the bar is visible.
Also, my modem did always announce "UMTS" access technology and only when it is fully connected, then it changes to whatever HSDPA or GPRS is used.

You need the attached network2.svgz to have the appropriate icons for the above case.

Diffs (updated)
-----

applet/networkmanager.cpp e75f2d5

Diff: http://git.reviewboard.kde.org/r/103828/diff/diff

Testing
-------

Works as expected. When connecting, only the signal strength is shown but no access technology.

Thanks,

Kai Uwe Broulik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20120130/17d65f38/attachment.html>