Discussion:
Review Request 124998: Add new properties from the latest NM snapshot/releases
Jan Grulich
2015-08-31 09:10:25 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124998/
-----------------------------------------------------------

Review request for Network Management, Lukáš Tinkl and Lamarque Souza.


Repository: networkmanager-qt


Description
-------

This patch adds properties introduced in either one of the latest stable releases of NM or in the development version.


Diffs
-----

src/accesspoint.h 4ee967f
src/accesspoint.cpp abcd8c9
src/accesspoint_p.h 00ba46a
src/dbus/introspection/nm-active-connection.xml 92fa760
src/dbus/introspection/nm-device-wifi.xml 780273f
src/dbus/introspection/nm-device.xml 74eced6
src/dbus/introspection/nm-ip4-config.xml e0f5cd9
src/dbus/introspection/nm-ip6-config.xml a5d4883
src/dbus/introspection/nm-manager.xml 9c5b073
src/dbus/nm-access-pointinterface.h 0c44cb9
src/dbus/nm-deviceinterface.h 35e9622
src/dbus/nm-ip4-configinterface.h 3e4d962
src/dbus/nm-ip6-configinterface.h f7e3d47
src/dbus/nm-managerinterface.h 09d468f
src/device.h 2ce303e
src/device.cpp ac06f4e
src/device_p.h 3def11f
src/generictypes.h b5b4072
src/ipconfig.h f9207c9
src/ipconfig.cpp 46f8572
src/manager.h 80030a2
src/manager.cpp 04fdbc3
src/manager_p.h e7a27aa
src/wirelessdevice.h e205a64

Diff: https://git.reviewboard.kde.org/r/124998/diff/


Testing
-------


Thanks,

Jan Grulich
Lamarque Souza
2015-08-31 12:47:56 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124998/#review84639
-----------------------------------------------------------



src/accesspoint.h (line 126)
<https://git.reviewboard.kde.org/r/124998/#comment58566>

Add a "@since 5.14.0" to indicate the frameworks version this method was added.



src/accesspoint.h (line 191)
<https://git.reviewboard.kde.org/r/124998/#comment58567>

Add a "@see lastSeen" tag here.



src/device.h (line 136)
<https://git.reviewboard.kde.org/r/124998/#comment58568>

Documentation?



src/device.h (line 369)
<https://git.reviewboard.kde.org/r/124998/#comment58569>

@since 5.14.0



src/device.h (line 377)
<https://git.reviewboard.kde.org/r/124998/#comment58570>

@since 5.14.0



src/device.h (line 531)
<https://git.reviewboard.kde.org/r/124998/#comment58571>

@since 5.14.0



src/device.h (line 536)
<https://git.reviewboard.kde.org/r/124998/#comment58572>

@since 5.14.0



src/ipconfig.h (line 123)
<https://git.reviewboard.kde.org/r/124998/#comment58573>

@since 5.14.0



src/manager.h (line 203)
<https://git.reviewboard.kde.org/r/124998/#comment58574>

@since 5.14.0



src/manager.h (line 392)
<https://git.reviewboard.kde.org/r/124998/#comment58575>

@see Device::metered
@since 5.14.0


- Lamarque Souza
Post by Jan Grulich
-----------------------------------------------------------
https://git.reviewboard.kde.org/r/124998/
-----------------------------------------------------------
(Updated Aug. 31, 2015, 9:10 a.m.)
Review request for Network Management, Lukáš Tinkl and Lamarque Souza.
Repository: networkmanager-qt
Description
-------
This patch adds properties introduced in either one of the latest stable releases of NM or in the development version.
Diffs
-----
src/accesspoint.h 4ee967f
src/accesspoint.cpp abcd8c9
src/accesspoint_p.h 00ba46a
src/dbus/introspection/nm-active-connection.xml 92fa760
src/dbus/introspection/nm-device-wifi.xml 780273f
src/dbus/introspection/nm-device.xml 74eced6
src/dbus/introspection/nm-ip4-config.xml e0f5cd9
src/dbus/introspection/nm-ip6-config.xml a5d4883
src/dbus/introspection/nm-manager.xml 9c5b073
src/dbus/nm-access-pointinterface.h 0c44cb9
src/dbus/nm-deviceinterface.h 35e9622
src/dbus/nm-ip4-configinterface.h 3e4d962
src/dbus/nm-ip6-configinterface.h f7e3d47
src/dbus/nm-managerinterface.h 09d468f
src/device.h 2ce303e
src/device.cpp ac06f4e
src/device_p.h 3def11f
src/generictypes.h b5b4072
src/ipconfig.h f9207c9
src/ipconfig.cpp 46f8572
src/manager.h 80030a2
src/manager.cpp 04fdbc3
src/manager_p.h e7a27aa
src/wirelessdevice.h e205a64
Diff: https://git.reviewboard.kde.org/r/124998/diff/
Testing
-------
Thanks,
Jan Grulich
Jan Grulich
2015-08-31 13:00:53 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124998/
-----------------------------------------------------------

(Updated Srp. 31, 2015, 1 odp.)


Review request for Network Management, Lukáš Tinkl and Lamarque Souza.


Changes
-------

Updated documentation, added @since 5.14.0 tags.


Repository: networkmanager-qt


Description
-------

This patch adds properties introduced in either one of the latest stable releases of NM or in the development version.


Diffs (updated)
-----

src/device.h 2ce303e
src/device.cpp ac06f4e
src/dbus/nm-managerinterface.h 09d468f
src/dbus/nm-ip6-configinterface.h f7e3d47
src/dbus/nm-ip4-configinterface.h 3e4d962
src/dbus/nm-deviceinterface.h 35e9622
src/dbus/nm-access-pointinterface.h 0c44cb9
src/dbus/introspection/nm-manager.xml 9c5b073
src/dbus/introspection/nm-ip6-config.xml a5d4883
src/dbus/introspection/nm-ip4-config.xml e0f5cd9
src/dbus/introspection/nm-device.xml 74eced6
src/dbus/introspection/nm-device-wifi.xml 780273f
src/dbus/introspection/nm-active-connection.xml 92fa760
src/accesspoint_p.h 00ba46a
src/accesspoint.h 4ee967f
src/accesspoint.cpp abcd8c9
src/device_p.h 3def11f
src/generictypes.h b5b4072
src/ipconfig.h f9207c9
src/ipconfig.cpp 46f8572
src/manager.h 80030a2
src/manager.cpp 04fdbc3
src/manager_p.h e7a27aa
src/wirelessdevice.h e205a64

Diff: https://git.reviewboard.kde.org/r/124998/diff/


Testing
-------


Thanks,

Jan Grulich
Lamarque Souza
2015-08-31 13:37:54 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124998/#review84646
-----------------------------------------------------------

Ship it!


Ship It!

- Lamarque Souza
Post by Jan Grulich
-----------------------------------------------------------
https://git.reviewboard.kde.org/r/124998/
-----------------------------------------------------------
(Updated Aug. 31, 2015, 1 p.m.)
Review request for Network Management, Lukáš Tinkl and Lamarque Souza.
Repository: networkmanager-qt
Description
-------
This patch adds properties introduced in either one of the latest stable releases of NM or in the development version.
Diffs
-----
src/device.h 2ce303e
src/device.cpp ac06f4e
src/dbus/nm-managerinterface.h 09d468f
src/dbus/nm-ip6-configinterface.h f7e3d47
src/dbus/nm-ip4-configinterface.h 3e4d962
src/dbus/nm-deviceinterface.h 35e9622
src/dbus/nm-access-pointinterface.h 0c44cb9
src/dbus/introspection/nm-manager.xml 9c5b073
src/dbus/introspection/nm-ip6-config.xml a5d4883
src/dbus/introspection/nm-ip4-config.xml e0f5cd9
src/dbus/introspection/nm-device.xml 74eced6
src/dbus/introspection/nm-device-wifi.xml 780273f
src/dbus/introspection/nm-active-connection.xml 92fa760
src/accesspoint_p.h 00ba46a
src/accesspoint.h 4ee967f
src/accesspoint.cpp abcd8c9
src/device_p.h 3def11f
src/generictypes.h b5b4072
src/ipconfig.h f9207c9
src/ipconfig.cpp 46f8572
src/manager.h 80030a2
src/manager.cpp 04fdbc3
src/manager_p.h e7a27aa
src/wirelessdevice.h e205a64
Diff: https://git.reviewboard.kde.org/r/124998/diff/
Testing
-------
Thanks,
Jan Grulich
Jan Grulich
2015-08-31 14:52:50 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124998/
-----------------------------------------------------------

(Updated Aug. 31, 2015, 2:52 p.m.)


Status
------

This change has been marked as submitted.


Review request for Network Management, Lukáš Tinkl and Lamarque Souza.


Changes
-------

Submitted with commit 7e57f90c85295e3596aa1b618fa148892bb46f0d by Jan Grulich to branch master.


Repository: networkmanager-qt


Description
-------

This patch adds properties introduced in either one of the latest stable releases of NM or in the development version.


Diffs
-----

src/device.h 2ce303e
src/device.cpp ac06f4e
src/dbus/nm-managerinterface.h 09d468f
src/dbus/nm-ip6-configinterface.h f7e3d47
src/dbus/nm-ip4-configinterface.h 3e4d962
src/dbus/nm-deviceinterface.h 35e9622
src/dbus/nm-access-pointinterface.h 0c44cb9
src/dbus/introspection/nm-manager.xml 9c5b073
src/dbus/introspection/nm-ip6-config.xml a5d4883
src/dbus/introspection/nm-ip4-config.xml e0f5cd9
src/dbus/introspection/nm-device.xml 74eced6
src/dbus/introspection/nm-device-wifi.xml 780273f
src/dbus/introspection/nm-active-connection.xml 92fa760
src/accesspoint_p.h 00ba46a
src/accesspoint.h 4ee967f
src/accesspoint.cpp abcd8c9
src/device_p.h 3def11f
src/generictypes.h b5b4072
src/ipconfig.h f9207c9
src/ipconfig.cpp 46f8572
src/manager.h 80030a2
src/manager.cpp 04fdbc3
src/manager_p.h e7a27aa
src/wirelessdevice.h e205a64

Diff: https://git.reviewboard.kde.org/r/124998/diff/


Testing
-------


Thanks,

Jan Grulich

Loading...