Review Request 119392: Missing Control For ModemManager

Discussion:

Ömer Fadıl Usta

2014-07-22 01:53:53 UTC

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119392/
-----------------------------------------------------------

Review request for Network Management.

Repository: plasma-nm

Description
-------

There was a missing control whether if Modemmanager exist or not before creating a ref

Diffs
-----

kded/service.cpp a12ff76

Diff: https://git.reviewboard.kde.org/r/119392/diff/

Testing
-------

Thanks,

?mer Fad?l Usta

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20140722/93cdeb5a/attachment.html>

Ömer Fadıl Usta

2014-07-22 01:59:32 UTC

Permalink

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119392/
-----------------------------------------------------------

(Updated July 22, 2014, 4:59 a.m.)

Review request for Network Management and Jan Grulich.

Repository: plasma-nm

Description
-------

There was a missing control whether if Modemmanager exist or not before creating a ref

Diffs
-----

kded/service.cpp a12ff76

Diff: https://git.reviewboard.kde.org/r/119392/diff/

Testing
-------

Thanks,

?mer Fad?l Usta

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20140722/2c3a8c1a/attachment.html>

Jan Grulich

2014-07-22 07:09:45 UTC

Permalink

Post by Ãmer FadÄ±l Usta
-----------------------------------------------------------
https://git.reviewboard.kde.org/r/119392/
-----------------------------------------------------------
(Updated ?ec. 22, 2014, 1:59 dop.)
Review request for Network Management and Jan Grulich.
Repository: plasma-nm
Description
-------
There was a missing control whether if Modemmanager exist or not before creating a ref
Diffs
-----
kded/service.cpp a12ff76
Diff: https://git.reviewboard.kde.org/r/119392/diff/
Testing
-------
Thanks,
?mer Fad?l Usta

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20140722/c235e8d1/attachment.html>

Jan Grulich

2014-07-22 07:10:42 UTC

Permalink

Post by Ãmer FadÄ±l Usta

Post by Jan Grulich
Ship It!

Can you please push it to master, Plasma/5.0 and 0.9.3 branches? Thanks a lot.

- Jan

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119392/#review62842
-----------------------------------------------------------

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20140722/c81b7491/attachment.html>

Ömer Fadıl Usta

2014-07-22 08:03:46 UTC

Permalink

Post by Jan Grulich

Post by Jan Grulich
Ship It!

Can you please push it to master, Plasma/5.0 and 0.9.3 branches? Thanks a lot.

committed to 0.9.3 then cherrypicked to Plasma/5.0 then again cherrypicked to master
I hope i did correctly

- ?mer Fad?l

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119392/#review62842
-----------------------------------------------------------

Post by Jan Grulich
-----------------------------------------------------------
https://git.reviewboard.kde.org/r/119392/
-----------------------------------------------------------
(Updated July 22, 2014, 10:49 a.m.)
Review request for Network Management and Jan Grulich.
Repository: plasma-nm
Description
-------
There was a missing control whether if Modemmanager exist or not before creating a ref
Diffs
-----
kded/service.cpp a12ff76
Diff: https://git.reviewboard.kde.org/r/119392/diff/
Testing
-------
Thanks,
?mer Fad?l Usta

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20140722/789acec2/attachment.html>

Jan Grulich

2014-07-22 08:09:36 UTC

Permalink

Post by Jan Grulich

Post by Jan Grulich
Ship It!

Can you please push it to master, Plasma/5.0 and 0.9.3 branches? Thanks a lot.
committed to 0.9.3 then cherrypicked to Plasma/5.0 then again cherrypicked to master
I hope i did correctly

Yes, thanks.

- Jan

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119392/#review62842
-----------------------------------------------------------

Post by Jan Grulich
-----------------------------------------------------------
https://git.reviewboard.kde.org/r/119392/
-----------------------------------------------------------
(Updated ?ec. 22, 2014, 7:49 dop.)
Review request for Network Management and Jan Grulich.
Repository: plasma-nm
Description
-------
There was a missing control whether if Modemmanager exist or not before creating a ref
Diffs
-----
kded/service.cpp a12ff76
Diff: https://git.reviewboard.kde.org/r/119392/diff/
Testing
-------
Thanks,
?mer Fad?l Usta

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20140722/a7dcad12/attachment.html>

Ömer Fadıl Usta

2014-07-22 07:49:59 UTC

Permalink

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119392/
-----------------------------------------------------------

(Updated July 22, 2014, 7:49 a.m.)

Status
------

This change has been marked as submitted.

Review request for Network Management and Jan Grulich.

Repository: plasma-nm

Description
-------

There was a missing control whether if Modemmanager exist or not before creating a ref

Diffs
-----

kded/service.cpp a12ff76

Diff: https://git.reviewboard.kde.org/r/119392/diff/

Testing
-------

Thanks,

?mer Fad?l Usta

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20140722/7b53721c/attachment-0001.html>