Review Request 118516: Load the networkmanager applet on demand

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118516/
-----------------------------------------------------------

Review request for Network Management and Plasma.


Repository: plasma-nm


Description
-------

This makes the networkmanagement applet load automatically when the dbus service org.freedesktop.NetworkManager is present and unloads it when it's not.
In a normal setup shouldn't make much difference, but would automatically disable it for workstations when a fixed ip or dhcp over ethernet is used instead of networkmanager


Diffs
-----

applet/metadata.desktop 7eafa44

Diff: https://git.reviewboard.kde.org/r/118516/diff/


Testing
-------


Thanks,

Marco Martin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20140604/0a30b1fe/attachment.html>

[Lukáš Tinkl]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118516/#review59153
-----------------------------------------------------------


How would you connect to a VPN in that case?

- Luk?? Tinkl

Post by Marco Martin
-----------------------------------------------------------
https://git.reviewboard.kde.org/r/118516/
-----------------------------------------------------------
(Updated June 4, 2014, 12:59 p.m.)
Review request for Network Management and Plasma.
Repository: plasma-nm
Description
-------
This makes the networkmanagement applet load automatically when the dbus service org.freedesktop.NetworkManager is present and unloads it when it's not.
In a normal setup shouldn't make much difference, but would automatically disable it for workstations when a fixed ip or dhcp over ethernet is used instead of networkmanager
Diffs
-----
applet/metadata.desktop 7eafa44
Diff: https://git.reviewboard.kde.org/r/118516/diff/
Testing
-------
Thanks,
Marco Martin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20140604/80b99b5f/attachment.html>

[Marco Martin]

Post by Marco Martin

Post by Lukáš Tinkl
How would you connect to a VPN in that case?

Is networkmanager used to connect a VPN?
(and more generally, are there any features in the plasmoid that can be used without networkmanager running?)


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118516/#review59153
-----------------------------------------------------------

Post by Marco Martin
-----------------------------------------------------------
https://git.reviewboard.kde.org/r/118516/
-----------------------------------------------------------
(Updated June 4, 2014, 10:59 a.m.)
Review request for Network Management and Plasma.
Repository: plasma-nm
Description
-------
This makes the networkmanagement applet load automatically when the dbus service org.freedesktop.NetworkManager is present and unloads it when it's not.
In a normal setup shouldn't make much difference, but would automatically disable it for workstations when a fixed ip or dhcp over ethernet is used instead of networkmanager
Diffs
-----
applet/metadata.desktop 7eafa44
Diff: https://git.reviewboard.kde.org/r/118516/diff/
Testing
-------
Thanks,
Marco Martin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20140604/789e5e68/attachment.html>

[Lukáš Tinkl]

Post by Marco Martin

Post by Lukáš Tinkl
How would you connect to a VPN in that case?

Is networkmanager used to connect a VPN?
(and more generally, are there any features in the plasmoid that can be used without networkmanager running?)

Yes it is and I think in that case the NM process is started on demand when you activate a VPN connection.

I can't think of any other features using this.


- Luk??


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118516/#review59153
-----------------------------------------------------------

Post by Marco Martin
-----------------------------------------------------------
https://git.reviewboard.kde.org/r/118516/
-----------------------------------------------------------
(Updated June 4, 2014, 12:59 p.m.)
Review request for Network Management and Plasma.
Repository: plasma-nm
Description
-------
This makes the networkmanagement applet load automatically when the dbus service org.freedesktop.NetworkManager is present and unloads it when it's not.
In a normal setup shouldn't make much difference, but would automatically disable it for workstations when a fixed ip or dhcp over ethernet is used instead of networkmanager
Diffs
-----
applet/metadata.desktop 7eafa44
Diff: https://git.reviewboard.kde.org/r/118516/diff/
Testing
-------
Thanks,
Marco Martin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20140604/0009f2ce/attachment.html>

[Marco Martin]

Post by Marco Martin

Post by Lukáš Tinkl
How would you connect to a VPN in that case?

Is networkmanager used to connect a VPN?
(and more generally, are there any features in the plasmoid that can be used without networkmanager running?)
Yes it is and I think in that case the NM process is started on demand when you activate a VPN connection.
I can't think of any other features using this.

Ok, if it's started on demand (can you confirm that?) then means the applet is useful without networkmanager running, so the dbus activation doesn't apply there.


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118516/#review59153
-----------------------------------------------------------

Post by Marco Martin
-----------------------------------------------------------
https://git.reviewboard.kde.org/r/118516/
-----------------------------------------------------------
(Updated June 4, 2014, 10:59 a.m.)
Review request for Network Management and Plasma.
Repository: plasma-nm
Description
-------
This makes the networkmanagement applet load automatically when the dbus service org.freedesktop.NetworkManager is present and unloads it when it's not.
In a normal setup shouldn't make much difference, but would automatically disable it for workstations when a fixed ip or dhcp over ethernet is used instead of networkmanager
Diffs
-----
applet/metadata.desktop 7eafa44
Diff: https://git.reviewboard.kde.org/r/118516/diff/
Testing
-------
Thanks,
Marco Martin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20140604/4007546a/attachment-0001.html>

[Sebastian Kügler]

Post by Marco Martin

Post by Lukáš Tinkl
How would you connect to a VPN in that case?

Is networkmanager used to connect a VPN?
(and more generally, are there any features in the plasmoid that can be used without networkmanager running?)
Yes it is and I think in that case the NM process is started on demand when you activate a VPN connection.
I can't think of any other features using this.
Ok, if it's started on demand (can you confirm that?) then means the applet is useful without networkmanager running, so the dbus activation doesn't apply there.

I've never seen the NetworkManager process (and thus its dbus interface) being started on demand by activating a connection. (Doesn't mean it does, just that my use-cases are different, and it deserves a second look). The applet bails out with an error if NetworkManager isn't started, it won't list anything (not even VPN connections) in that case.

The approach to load it on-demand seems fine to me.


- Sebastian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118516/#review59153
-----------------------------------------------------------

Post by Marco Martin
-----------------------------------------------------------
https://git.reviewboard.kde.org/r/118516/
-----------------------------------------------------------
(Updated June 4, 2014, 10:59 a.m.)
Review request for Network Management and Plasma.
Repository: plasma-nm
Description
-------
This makes the networkmanagement applet load automatically when the dbus service org.freedesktop.NetworkManager is present and unloads it when it's not.
In a normal setup shouldn't make much difference, but would automatically disable it for workstations when a fixed ip or dhcp over ethernet is used instead of networkmanager
Diffs
-----
applet/metadata.desktop 7eafa44
Diff: https://git.reviewboard.kde.org/r/118516/diff/
Testing
-------
Thanks,
Marco Martin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20140604/db842dd4/attachment.html>

[Jan Grulich]

Post by Marco Martin

Post by Lukáš Tinkl
How would you connect to a VPN in that case?

Is networkmanager used to connect a VPN?
(and more generally, are there any features in the plasmoid that can be used without networkmanager running?)
Yes it is and I think in that case the NM process is started on demand when you activate a VPN connection.
I can't think of any other features using this.
Ok, if it's started on demand (can you confirm that?) then means the applet is useful without networkmanager running, so the dbus activation doesn't apply there.
I've never seen the NetworkManager process (and thus its dbus interface) being started on demand by activating a connection. (Doesn't mean it does, just that my use-cases are different, and it deserves a second look). The applet bails out with an error if NetworkManager isn't started, it won't list anything (not even VPN connections) in that case.
The approach to load it on-demand seems fine to me.

You can use VPN connections without NetworkManager and I think that this patch makes sense, because plasma-nm is useless when NetworkManager is running.


- Jan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118516/#review59153
-----------------------------------------------------------

Post by Marco Martin
-----------------------------------------------------------
https://git.reviewboard.kde.org/r/118516/
-----------------------------------------------------------
(Updated June 4, 2014, 10:59 a.m.)
Review request for Network Management and Plasma.
Repository: plasma-nm
Description
-------
This makes the networkmanagement applet load automatically when the dbus service org.freedesktop.NetworkManager is present and unloads it when it's not.
In a normal setup shouldn't make much difference, but would automatically disable it for workstations when a fixed ip or dhcp over ethernet is used instead of networkmanager
Diffs
-----
applet/metadata.desktop 7eafa44
Diff: https://git.reviewboard.kde.org/r/118516/diff/
Testing
-------
Thanks,
Marco Martin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20140604/2b8c8688/attachment.html>

[Marco Martin]

Post by Marco Martin

Post by Lukáš Tinkl
How would you connect to a VPN in that case?

Is networkmanager used to connect a VPN?
(and more generally, are there any features in the plasmoid that can be used without networkmanager running?)
Yes it is and I think in that case the NM process is started on demand when you activate a VPN connection.
I can't think of any other features using this.
Ok, if it's started on demand (can you confirm that?) then means the applet is useful without networkmanager running, so the dbus activation doesn't apply there.
I've never seen the NetworkManager process (and thus its dbus interface) being started on demand by activating a connection. (Doesn't mean it does, just that my use-cases are different, and it deserves a second look). The applet bails out with an error if NetworkManager isn't started, it won't list anything (not even VPN connections) in that case.
The approach to load it on-demand seems fine to me.
You can use VPN connections without NetworkManager and I think that this patch makes sense, because plasma-nm is useless when NetworkManager is running.

So I pushed it for now. IF it causes problems can always be reverted


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118516/#review59153
-----------------------------------------------------------

Post by Marco Martin
-----------------------------------------------------------
https://git.reviewboard.kde.org/r/118516/
-----------------------------------------------------------
(Updated June 4, 2014, 12:13 p.m.)
Review request for Network Management and Plasma.
Repository: plasma-nm
Description
-------
This makes the networkmanagement applet load automatically when the dbus service org.freedesktop.NetworkManager is present and unloads it when it's not.
In a normal setup shouldn't make much difference, but would automatically disable it for workstations when a fixed ip or dhcp over ethernet is used instead of networkmanager
Diffs
-----
applet/metadata.desktop 7eafa44
Diff: https://git.reviewboard.kde.org/r/118516/diff/
Testing
-------
Thanks,
Marco Martin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20140604/9e5627b8/attachment-0001.html>

[Hrvoje Senjan]

Post by Marco Martin

Post by Lukáš Tinkl
How would you connect to a VPN in that case?

Is networkmanager used to connect a VPN?
(and more generally, are there any features in the plasmoid that can be used without networkmanager running?)
Yes it is and I think in that case the NM process is started on demand when you activate a VPN connection.
I can't think of any other features using this.
Ok, if it's started on demand (can you confirm that?) then means the applet is useful without networkmanager running, so the dbus activation doesn't apply there.
I've never seen the NetworkManager process (and thus its dbus interface) being started on demand by activating a connection. (Doesn't mean it does, just that my use-cases are different, and it deserves a second look). The applet bails out with an error if NetworkManager isn't started, it won't list anything (not even VPN connections) in that case.
The approach to load it on-demand seems fine to me.
You can use VPN connections without NetworkManager and I think that this patch makes sense, because plasma-nm is useless when NetworkManager is running.
So I pushed it for now. IF it causes problems can always be reverted

seems is not working as expected (here at least)
i have org.freedesktop.NetworkManager at system bus, but applet isn't loaded


- Hrvoje


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118516/#review59153
-----------------------------------------------------------

Post by Marco Martin
-----------------------------------------------------------
https://git.reviewboard.kde.org/r/118516/
-----------------------------------------------------------
(Updated June 4, 2014, 2:13 p.m.)
Review request for Network Management and Plasma.
Repository: plasma-nm
Description
-------
This makes the networkmanagement applet load automatically when the dbus service org.freedesktop.NetworkManager is present and unloads it when it's not.
In a normal setup shouldn't make much difference, but would automatically disable it for workstations when a fixed ip or dhcp over ethernet is used instead of networkmanager
Diffs
-----
applet/metadata.desktop 7eafa44
Diff: https://git.reviewboard.kde.org/r/118516/diff/
Testing
-------
Thanks,
Marco Martin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20140604/e4232139/attachment.html>

[Marco Martin]

Post by Marco Martin

Post by Lukáš Tinkl
How would you connect to a VPN in that case?

Is networkmanager used to connect a VPN?
(and more generally, are there any features in the plasmoid that can be used without networkmanager running?)
Yes it is and I think in that case the NM process is started on demand when you activate a VPN connection.
I can't think of any other features using this.
Ok, if it's started on demand (can you confirm that?) then means the applet is useful without networkmanager running, so the dbus activation doesn't apply there.
I've never seen the NetworkManager process (and thus its dbus interface) being started on demand by activating a connection. (Doesn't mean it does, just that my use-cases are different, and it deserves a second look). The applet bails out with an error if NetworkManager isn't started, it won't list anything (not even VPN connections) in that case.
The approach to load it on-demand seems fine to me.
You can use VPN connections without NetworkManager and I think that this patch makes sense, because plasma-nm is useless when NetworkManager is running.
So I pushed it for now. IF it causes problems can always be reverted
seems is not working as expected (here at least)
i have org.freedesktop.NetworkManager at system bus, but applet isn't loaded

Ah, right, it was monitoring only the session bus.
Does it work correctly with the latest plasma-workspace revision?


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118516/#review59153
-----------------------------------------------------------

Post by Marco Martin
-----------------------------------------------------------
https://git.reviewboard.kde.org/r/118516/
-----------------------------------------------------------
(Updated June 4, 2014, 12:13 p.m.)
Review request for Network Management and Plasma.
Repository: plasma-nm
Description
-------
This makes the networkmanagement applet load automatically when the dbus service org.freedesktop.NetworkManager is present and unloads it when it's not.
In a normal setup shouldn't make much difference, but would automatically disable it for workstations when a fixed ip or dhcp over ethernet is used instead of networkmanager
Diffs
-----
applet/metadata.desktop 7eafa44
Diff: https://git.reviewboard.kde.org/r/118516/diff/
Testing
-------
Thanks,
Marco Martin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20140604/0237486d/attachment.html>

[Hrvoje Senjan]

Post by Marco Martin

Post by Lukáš Tinkl
How would you connect to a VPN in that case?

Is networkmanager used to connect a VPN?
(and more generally, are there any features in the plasmoid that can be used without networkmanager running?)
Yes it is and I think in that case the NM process is started on demand when you activate a VPN connection.
I can't think of any other features using this.
Ok, if it's started on demand (can you confirm that?) then means the applet is useful without networkmanager running, so the dbus activation doesn't apply there.
I've never seen the NetworkManager process (and thus its dbus interface) being started on demand by activating a connection. (Doesn't mean it does, just that my use-cases are different, and it deserves a second look). The applet bails out with an error if NetworkManager isn't started, it won't list anything (not even VPN connections) in that case.
The approach to load it on-demand seems fine to me.
You can use VPN connections without NetworkManager and I think that this patch makes sense, because plasma-nm is useless when NetworkManager is running.
So I pushed it for now. IF it causes problems can always be reverted
seems is not working as expected (here at least)
i have org.freedesktop.NetworkManager at system bus, but applet isn't loaded
Ah, right, it was monitoring only the session bus.
Does it work correctly with the latest plasma-workspace revision?

that was fast! yes it does =)


- Hrvoje


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118516/#review59153
-----------------------------------------------------------

Post by Marco Martin
-----------------------------------------------------------
https://git.reviewboard.kde.org/r/118516/
-----------------------------------------------------------
(Updated June 4, 2014, 2:13 p.m.)
Review request for Network Management and Plasma.
Repository: plasma-nm
Description
-------
This makes the networkmanagement applet load automatically when the dbus service org.freedesktop.NetworkManager is present and unloads it when it's not.
In a normal setup shouldn't make much difference, but would automatically disable it for workstations when a fixed ip or dhcp over ethernet is used instead of networkmanager
Diffs
-----
applet/metadata.desktop 7eafa44
Diff: https://git.reviewboard.kde.org/r/118516/diff/
Testing
-------
Thanks,
Marco Martin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20140604/fa8e30e6/attachment-0001.html>

[Jan Grulich]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118516/#review59176
-----------------------------------------------------------

Ship it!


Ship It!

- Jan Grulich

Post by Marco Martin
-----------------------------------------------------------
https://git.reviewboard.kde.org/r/118516/
-----------------------------------------------------------
(Updated June 4, 2014, 10:59 a.m.)
Review request for Network Management and Plasma.
Repository: plasma-nm
Description
-------
This makes the networkmanagement applet load automatically when the dbus service org.freedesktop.NetworkManager is present and unloads it when it's not.
In a normal setup shouldn't make much difference, but would automatically disable it for workstations when a fixed ip or dhcp over ethernet is used instead of networkmanager
Diffs
-----
applet/metadata.desktop 7eafa44
Diff: https://git.reviewboard.kde.org/r/118516/diff/
Testing
-------
Thanks,
Marco Martin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20140604/06d42e9b/attachment.html>

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118516/#review59180
-----------------------------------------------------------


This review has been submitted with commit f4d83f8b32b88592e1d2a0fa064ac9c9dd195300 by Marco Martin to branch frameworks.

- Commit Hook

Post by Marco Martin
-----------------------------------------------------------
https://git.reviewboard.kde.org/r/118516/
-----------------------------------------------------------
(Updated June 4, 2014, 10:59 a.m.)
Review request for Network Management and Plasma.
Repository: plasma-nm
Description
-------
This makes the networkmanagement applet load automatically when the dbus service org.freedesktop.NetworkManager is present and unloads it when it's not.
In a normal setup shouldn't make much difference, but would automatically disable it for workstations when a fixed ip or dhcp over ethernet is used instead of networkmanager
Diffs
-----
applet/metadata.desktop 7eafa44
Diff: https://git.reviewboard.kde.org/r/118516/diff/
Testing
-------
Thanks,
Marco Martin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20140604/18f86e8b/attachment.html>

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118516/
-----------------------------------------------------------

(Updated June 4, 2014, 12:13 p.m.)


Status
------

This change has been marked as submitted.


Review request for Network Management and Plasma.


Repository: plasma-nm


Description
-------

This makes the networkmanagement applet load automatically when the dbus service org.freedesktop.NetworkManager is present and unloads it when it's not.
In a normal setup shouldn't make much difference, but would automatically disable it for workstations when a fixed ip or dhcp over ethernet is used instead of networkmanager


Diffs
-----

applet/metadata.desktop 7eafa44

Diff: https://git.reviewboard.kde.org/r/118516/diff/


Testing
-------


Thanks,

Marco Martin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20140604/010acff6/attachment.html>

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118516/#review59181
-----------------------------------------------------------


This review has been submitted with commit 2bdef2e97c10d7a9deb015376f66376074949485 by Marco Martin to branch master.

- Commit Hook

Post by Marco Martin
-----------------------------------------------------------
https://git.reviewboard.kde.org/r/118516/
-----------------------------------------------------------
(Updated June 4, 2014, 12:13 p.m.)
Review request for Network Management and Plasma.
Repository: plasma-nm
Description
-------
This makes the networkmanagement applet load automatically when the dbus service org.freedesktop.NetworkManager is present and unloads it when it's not.
In a normal setup shouldn't make much difference, but would automatically disable it for workstations when a fixed ip or dhcp over ethernet is used instead of networkmanager
Diffs
-----
applet/metadata.desktop 7eafa44
Diff: https://git.reviewboard.kde.org/r/118516/diff/
Testing
-------
Thanks,
Marco Martin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20140604/353836c6/attachment.html>