Discussion:
Review Request: Add IPv6 support to NetworkManagement
Ilia Kats
2011-04-13 21:46:29 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101117/
-----------------------------------------------------------

Review request for Network Management.


Summary
-------

The last IPv4 blocks have been assigned, so IPv6-support in KDE network management is long overdue. Attached patch makes that possible.


Diffs
-----

backends/NetworkManager/CMakeLists.txt f6ff372
backends/NetworkManager/connectiondbus.cpp 4a142e9
backends/NetworkManager/settings/ipv4dbus.cpp f77d421
backends/NetworkManager/settings/ipv6dbus.h PRE-CREATION
backends/NetworkManager/settings/ipv6dbus.cpp PRE-CREATION
libs/internals/CMakeLists.txt d5a0dab
libs/internals/connection.cpp 3cd7e78
libs/internals/connectionpersistence.cpp 8396464
libs/internals/schemas/ipv4.kcfg a069ef8
libs/internals/schemas/ipv6.kcfg PRE-CREATION
libs/internals/schemas/ipv6.kcfgc PRE-CREATION
libs/internals/setting.cpp 197fafc
libs/internals/settings/ipv4.h fee2987
libs/internals/settings/ipv4.cpp 6c6fd64
libs/internals/settings/ipv4persistence.cpp c30622d
libs/internals/settings/ipv6.h PRE-CREATION
libs/internals/settings/ipv6.cpp PRE-CREATION
libs/internals/settings/ipv6persistence.h PRE-CREATION
libs/internals/settings/ipv6persistence.cpp PRE-CREATION
libs/ui/CMakeLists.txt aea6563
libs/ui/gsmconnectioneditor.cpp 5a26c7c
libs/ui/ipv4.ui e107869
libs/ui/ipv4widget.cpp 732a94e
libs/ui/ipv6.ui PRE-CREATION
libs/ui/ipv6advanced.ui PRE-CREATION
libs/ui/ipv6advancedwidget.h PRE-CREATION
libs/ui/ipv6advancedwidget.cpp PRE-CREATION
libs/ui/ipv6widget.h PRE-CREATION
libs/ui/ipv6widget.cpp PRE-CREATION
libs/ui/pppoepreferences.cpp 0cabcd0
libs/ui/simpleipv6addressvalidator.h PRE-CREATION
libs/ui/simpleipv6addressvalidator.cpp PRE-CREATION
libs/ui/vpnpreferences.cpp 5274d14
libs/ui/wiredpreferences.cpp 60b7932
libs/ui/wirelesspreferences.cpp 7f901c2
solidcontrolfuture/CMakeLists.txt 4643e8d
solidcontrolfuture/networkipv6config.h PRE-CREATION
solidcontrolfuture/networkipv6config.cpp PRE-CREATION

Diff: http://git.reviewboard.kde.org/r/101117/diff


Testing
-------

Only on my local system, compared qdbus output with nm-applet and knetworkmanager, as well as created ad-hoc wlan connections and checked with ifconfig. My university's network does currently not support IPv6, so a field test could not be done.


Screenshots
-----------

Basic settings
http://git.reviewboard.kde.org/r/101117/s/125/
advanced settings
http://git.reviewboard.kde.org/r/101117/s/126/


Thanks,

Ilia

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-networkmanager/attachments/20110413/34be4f1f/attachment.htm
Ilia Kats
2011-04-14 13:38:29 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101117/
-----------------------------------------------------------

(Updated April 14, 2011, 1:38 p.m.)


Review request for Network Management.


Changes
-------

cleaned up


Summary
-------

The last IPv4 blocks have been assigned, so IPv6-support in KDE network management is long overdue. Attached patch makes that possible.


Diffs (updated)
-----

backends/NetworkManager/CMakeLists.txt f6ff372
backends/NetworkManager/connectiondbus.cpp 4a142e9
backends/NetworkManager/settings/ipv4dbus.cpp f77d421
backends/NetworkManager/settings/ipv6dbus.h PRE-CREATION
backends/NetworkManager/settings/ipv6dbus.cpp PRE-CREATION
libs/internals/CMakeLists.txt d5a0dab
libs/internals/connection.cpp 3cd7e78
libs/internals/connectionpersistence.cpp 8396464
libs/internals/schemas/ipv4.kcfg a069ef8
libs/internals/schemas/ipv6.kcfg PRE-CREATION
libs/internals/schemas/ipv6.kcfgc PRE-CREATION
libs/internals/setting.cpp 197fafc
libs/internals/settings/ipv4.h fee2987
libs/internals/settings/ipv4.cpp 6c6fd64
libs/internals/settings/ipv4persistence.cpp c30622d
libs/internals/settings/ipv6.h PRE-CREATION
libs/internals/settings/ipv6.cpp PRE-CREATION
libs/internals/settings/ipv6persistence.h PRE-CREATION
libs/internals/settings/ipv6persistence.cpp PRE-CREATION
libs/ui/CMakeLists.txt aea6563
libs/ui/gsmconnectioneditor.cpp 5a26c7c
libs/ui/ipv4.ui e107869
libs/ui/ipv4widget.cpp 732a94e
libs/ui/ipv6.ui PRE-CREATION
libs/ui/ipv6advanced.ui PRE-CREATION
libs/ui/ipv6advancedwidget.h PRE-CREATION
libs/ui/ipv6advancedwidget.cpp PRE-CREATION
libs/ui/ipv6widget.h PRE-CREATION
libs/ui/ipv6widget.cpp PRE-CREATION
libs/ui/pppoepreferences.cpp 0cabcd0
libs/ui/simpleipv6addressvalidator.h PRE-CREATION
libs/ui/simpleipv6addressvalidator.cpp PRE-CREATION
libs/ui/vpnpreferences.cpp 5274d14
libs/ui/wiredpreferences.cpp 60b7932
libs/ui/wirelesspreferences.cpp 7f901c2
solidcontrolfuture/CMakeLists.txt 4643e8d
solidcontrolfuture/networkipv6config.h PRE-CREATION
solidcontrolfuture/networkipv6config.cpp PRE-CREATION

Diff: http://git.reviewboard.kde.org/r/101117/diff


Testing
-------

Only on my local system, compared qdbus output with nm-applet and knetworkmanager, as well as created ad-hoc wlan connections and checked with ifconfig. My university's network does currently not support IPv6, so a field test could not be done.


Screenshots
-----------

Basic settings
http://git.reviewboard.kde.org/r/101117/s/125/
advanced settings
http://git.reviewboard.kde.org/r/101117/s/126/


Thanks,

Ilia

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-networkmanager/attachments/20110414/94a3b256/attachment.htm
Ilia Kats
2011-04-14 13:38:52 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101117/
-----------------------------------------------------------

(Updated April 14, 2011, 1:38 p.m.)


Review request for Network Management.


Summary
-------

The last IPv4 blocks have been assigned, so IPv6-support in KDE network management is long overdue. Attached patch makes that possible.


This addresses bug 270827.
http://bugs.kde.org/show_bug.cgi?id=270827


Diffs
-----

backends/NetworkManager/CMakeLists.txt f6ff372
backends/NetworkManager/connectiondbus.cpp 4a142e9
backends/NetworkManager/settings/ipv4dbus.cpp f77d421
backends/NetworkManager/settings/ipv6dbus.h PRE-CREATION
backends/NetworkManager/settings/ipv6dbus.cpp PRE-CREATION
libs/internals/CMakeLists.txt d5a0dab
libs/internals/connection.cpp 3cd7e78
libs/internals/connectionpersistence.cpp 8396464
libs/internals/schemas/ipv4.kcfg a069ef8
libs/internals/schemas/ipv6.kcfg PRE-CREATION
libs/internals/schemas/ipv6.kcfgc PRE-CREATION
libs/internals/setting.cpp 197fafc
libs/internals/settings/ipv4.h fee2987
libs/internals/settings/ipv4.cpp 6c6fd64
libs/internals/settings/ipv4persistence.cpp c30622d
libs/internals/settings/ipv6.h PRE-CREATION
libs/internals/settings/ipv6.cpp PRE-CREATION
libs/internals/settings/ipv6persistence.h PRE-CREATION
libs/internals/settings/ipv6persistence.cpp PRE-CREATION
libs/ui/CMakeLists.txt aea6563
libs/ui/gsmconnectioneditor.cpp 5a26c7c
libs/ui/ipv4.ui e107869
libs/ui/ipv4widget.cpp 732a94e
libs/ui/ipv6.ui PRE-CREATION
libs/ui/ipv6advanced.ui PRE-CREATION
libs/ui/ipv6advancedwidget.h PRE-CREATION
libs/ui/ipv6advancedwidget.cpp PRE-CREATION
libs/ui/ipv6widget.h PRE-CREATION
libs/ui/ipv6widget.cpp PRE-CREATION
libs/ui/pppoepreferences.cpp 0cabcd0
libs/ui/simpleipv6addressvalidator.h PRE-CREATION
libs/ui/simpleipv6addressvalidator.cpp PRE-CREATION
libs/ui/vpnpreferences.cpp 5274d14
libs/ui/wiredpreferences.cpp 60b7932
libs/ui/wirelesspreferences.cpp 7f901c2
solidcontrolfuture/CMakeLists.txt 4643e8d
solidcontrolfuture/networkipv6config.h PRE-CREATION
solidcontrolfuture/networkipv6config.cpp PRE-CREATION

Diff: http://git.reviewboard.kde.org/r/101117/diff


Testing
-------

Only on my local system, compared qdbus output with nm-applet and knetworkmanager, as well as created ad-hoc wlan connections and checked with ifconfig. My university's network does currently not support IPv6, so a field test could not be done.


Screenshots
-----------

Basic settings
http://git.reviewboard.kde.org/r/101117/s/125/
advanced settings
http://git.reviewboard.kde.org/r/101117/s/126/


Thanks,

Ilia

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-networkmanager/attachments/20110414/15642eb9/attachment-0001.htm
Lamarque Vieira Souza
2011-04-15 19:37:34 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101117/#review2666
-----------------------------------------------------------



backends/NetworkManager/settings/ipv6dbus.cpp
<http://git.reviewboard.kde.org/r/101117/#comment2362>

Why are you using a QStringList here? AddressArg is a QList<IpV6AddressMap> according to Ipv6DBus::toMap() and IpV6AddressMap is a struct, not a QString.


- Lamarque Vieira
Post by Ilia Kats
-----------------------------------------------------------
http://git.reviewboard.kde.org/r/101117/
-----------------------------------------------------------
(Updated April 14, 2011, 1:38 p.m.)
Review request for Network Management.
Summary
-------
The last IPv4 blocks have been assigned, so IPv6-support in KDE network management is long overdue. Attached patch makes that possible.
This addresses bug 270827.
http://bugs.kde.org/show_bug.cgi?id=270827
Diffs
-----
backends/NetworkManager/CMakeLists.txt f6ff372
backends/NetworkManager/connectiondbus.cpp 4a142e9
backends/NetworkManager/settings/ipv4dbus.cpp f77d421
backends/NetworkManager/settings/ipv6dbus.h PRE-CREATION
backends/NetworkManager/settings/ipv6dbus.cpp PRE-CREATION
libs/internals/CMakeLists.txt d5a0dab
libs/internals/connection.cpp 3cd7e78
libs/internals/connectionpersistence.cpp 8396464
libs/internals/schemas/ipv4.kcfg a069ef8
libs/internals/schemas/ipv6.kcfg PRE-CREATION
libs/internals/schemas/ipv6.kcfgc PRE-CREATION
libs/internals/setting.cpp 197fafc
libs/internals/settings/ipv4.h fee2987
libs/internals/settings/ipv4.cpp 6c6fd64
libs/internals/settings/ipv4persistence.cpp c30622d
libs/internals/settings/ipv6.h PRE-CREATION
libs/internals/settings/ipv6.cpp PRE-CREATION
libs/internals/settings/ipv6persistence.h PRE-CREATION
libs/internals/settings/ipv6persistence.cpp PRE-CREATION
libs/ui/CMakeLists.txt aea6563
libs/ui/gsmconnectioneditor.cpp 5a26c7c
libs/ui/ipv4.ui e107869
libs/ui/ipv4widget.cpp 732a94e
libs/ui/ipv6.ui PRE-CREATION
libs/ui/ipv6advanced.ui PRE-CREATION
libs/ui/ipv6advancedwidget.h PRE-CREATION
libs/ui/ipv6advancedwidget.cpp PRE-CREATION
libs/ui/ipv6widget.h PRE-CREATION
libs/ui/ipv6widget.cpp PRE-CREATION
libs/ui/pppoepreferences.cpp 0cabcd0
libs/ui/simpleipv6addressvalidator.h PRE-CREATION
libs/ui/simpleipv6addressvalidator.cpp PRE-CREATION
libs/ui/vpnpreferences.cpp 5274d14
libs/ui/wiredpreferences.cpp 60b7932
libs/ui/wirelesspreferences.cpp 7f901c2
solidcontrolfuture/CMakeLists.txt 4643e8d
solidcontrolfuture/networkipv6config.h PRE-CREATION
solidcontrolfuture/networkipv6config.cpp PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/101117/diff
Testing
-------
Only on my local system, compared qdbus output with nm-applet and knetworkmanager, as well as created ad-hoc wlan connections and checked with ifconfig. My university's network does currently not support IPv6, so a field test could not be done.
Screenshots
-----------
Basic settings
http://git.reviewboard.kde.org/r/101117/s/125/
advanced settings
http://git.reviewboard.kde.org/r/101117/s/126/
Thanks,
Ilia
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-networkmanager/attachments/20110415/e102e78a/attachment.htm
Ilia Kats
2011-04-15 21:45:17 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101117/
-----------------------------------------------------------

(Updated April 15, 2011, 9:45 p.m.)


Review request for Network Management.


Changes
-------

Heh. Sorry about that, guess I need sleep after all ;)
Should be fixed now, diff is rebased for current master.


Summary
-------

The last IPv4 blocks have been assigned, so IPv6-support in KDE network management is long overdue. Attached patch makes that possible.


This addresses bug 270827.
http://bugs.kde.org/show_bug.cgi?id=270827


Diffs (updated)
-----

backends/NetworkManager/CMakeLists.txt a093415
backends/NetworkManager/connectiondbus.cpp 9c3c908
backends/NetworkManager/settings/ipv4dbus.cpp 7d167e9
backends/NetworkManager/settings/ipv6dbus.h PRE-CREATION
backends/NetworkManager/settings/ipv6dbus.cpp PRE-CREATION
libs/internals/CMakeLists.txt d5a0dab
libs/internals/connection.cpp a5fe2d3
libs/internals/connectionpersistence.cpp cc84af3
libs/internals/schemas/ipv4.kcfg a069ef8
libs/internals/schemas/ipv6.kcfg PRE-CREATION
libs/internals/schemas/ipv6.kcfgc PRE-CREATION
libs/internals/setting.cpp 197fafc
libs/internals/settings/ipv4.h fee2987
libs/internals/settings/ipv4.cpp 6c6fd64
libs/internals/settings/ipv4persistence.cpp c30622d
libs/internals/settings/ipv6.h PRE-CREATION
libs/internals/settings/ipv6.cpp PRE-CREATION
libs/internals/settings/ipv6persistence.h PRE-CREATION
libs/internals/settings/ipv6persistence.cpp PRE-CREATION
libs/ui/CMakeLists.txt aea6563
libs/ui/gsmconnectioneditor.cpp 39e7d3b
libs/ui/ipv4.ui e107869
libs/ui/ipv4widget.cpp 732a94e
libs/ui/ipv6.ui PRE-CREATION
libs/ui/ipv6advanced.ui PRE-CREATION
libs/ui/ipv6advancedwidget.h PRE-CREATION
libs/ui/ipv6advancedwidget.cpp PRE-CREATION
libs/ui/ipv6widget.h PRE-CREATION
libs/ui/ipv6widget.cpp PRE-CREATION
libs/ui/pppoepreferences.cpp be503c0
libs/ui/simpleipv6addressvalidator.h PRE-CREATION
libs/ui/simpleipv6addressvalidator.cpp PRE-CREATION
libs/ui/vpnpreferences.cpp 1714a51
libs/ui/wiredpreferences.cpp 003e05d
libs/ui/wirelesspreferences.cpp 7033c40
solidcontrolfuture/CMakeLists.txt 4643e8d
solidcontrolfuture/networkipv6config.h PRE-CREATION
solidcontrolfuture/networkipv6config.cpp PRE-CREATION

Diff: http://git.reviewboard.kde.org/r/101117/diff


Testing
-------

Only on my local system, compared qdbus output with nm-applet and knetworkmanager, as well as created ad-hoc wlan connections and checked with ifconfig. My university's network does currently not support IPv6, so a field test could not be done.


Screenshots
-----------

Basic settings
http://git.reviewboard.kde.org/r/101117/s/125/
advanced settings
http://git.reviewboard.kde.org/r/101117/s/126/


Thanks,

Ilia

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-networkmanager/attachments/20110415/b10cb913/attachment.htm
Ilia Kats
2011-04-16 21:32:28 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101117/
-----------------------------------------------------------

(Updated April 16, 2011, 9:32 p.m.)


Review request for Network Management.


Changes
-------

Forgot to add IPv6-Widget to connection edits, fixed now.


Summary
-------

The last IPv4 blocks have been assigned, so IPv6-support in KDE network management is long overdue. Attached patch makes that possible.


This addresses bug 270827.
http://bugs.kde.org/show_bug.cgi?id=270827


Diffs (updated)
-----

backends/NetworkManager/CMakeLists.txt a093415
backends/NetworkManager/connectiondbus.cpp 9c3c908
backends/NetworkManager/settings/ipv4dbus.cpp 7d167e9
backends/NetworkManager/settings/ipv6dbus.h PRE-CREATION
backends/NetworkManager/settings/ipv6dbus.cpp PRE-CREATION
libs/internals/CMakeLists.txt d5a0dab
libs/internals/connection.cpp a5fe2d3
libs/internals/connectionpersistence.cpp cc84af3
libs/internals/schemas/ipv4.kcfg a069ef8
libs/internals/schemas/ipv6.kcfg PRE-CREATION
libs/internals/schemas/ipv6.kcfgc PRE-CREATION
libs/internals/setting.cpp 197fafc
libs/internals/settings/ipv4.h fee2987
libs/internals/settings/ipv4.cpp 6c6fd64
libs/internals/settings/ipv4persistence.cpp c30622d
libs/internals/settings/ipv6.h PRE-CREATION
libs/internals/settings/ipv6.cpp PRE-CREATION
libs/internals/settings/ipv6persistence.h PRE-CREATION
libs/internals/settings/ipv6persistence.cpp PRE-CREATION
libs/ui/CMakeLists.txt aea6563
libs/ui/gsmconnectioneditor.cpp 39e7d3b
libs/ui/ipv4.ui e107869
libs/ui/ipv4widget.cpp 732a94e
libs/ui/ipv6.ui PRE-CREATION
libs/ui/ipv6advanced.ui PRE-CREATION
libs/ui/ipv6advancedwidget.h PRE-CREATION
libs/ui/ipv6advancedwidget.cpp PRE-CREATION
libs/ui/ipv6widget.h PRE-CREATION
libs/ui/ipv6widget.cpp PRE-CREATION
libs/ui/pppoepreferences.cpp be503c0
libs/ui/simpleipv6addressvalidator.h PRE-CREATION
libs/ui/simpleipv6addressvalidator.cpp PRE-CREATION
libs/ui/vpnpreferences.cpp 1714a51
libs/ui/wiredpreferences.cpp 003e05d
libs/ui/wirelesspreferences.cpp 7033c40
solidcontrolfuture/CMakeLists.txt 4643e8d
solidcontrolfuture/networkipv6config.h PRE-CREATION
solidcontrolfuture/networkipv6config.cpp PRE-CREATION

Diff: http://git.reviewboard.kde.org/r/101117/diff


Testing
-------

Only on my local system, compared qdbus output with nm-applet and knetworkmanager, as well as created ad-hoc wlan connections and checked with ifconfig. My university's network does currently not support IPv6, so a field test could not be done.


Screenshots
-----------

Basic settings
http://git.reviewboard.kde.org/r/101117/s/125/
advanced settings
http://git.reviewboard.kde.org/r/101117/s/126/


Thanks,

Ilia

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-networkmanager/attachments/20110416/d0a86a61/attachment.htm
Lamarque Vieira Souza
2011-04-16 23:49:34 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101117/#review2690
-----------------------------------------------------------



solidcontrolfuture/networkipv6config.cpp
<http://git.reviewboard.kde.org/r/101117/#comment2373>

Remove extra space.



solidcontrolfuture/networkipv6config.cpp
<http://git.reviewboard.kde.org/r/101117/#comment2375>

You are comparing addresses here, is that what you want? I think the compiler would complaing if you write a code like this:

obj = obj;

or at least it would optimise this by removing this line from the code. I think this line will have no effect since the if will always be false.



solidcontrolfuture/networkipv6config.cpp
<http://git.reviewboard.kde.org/r/101117/#comment2376>

Comparing addresses.



solidcontrolfuture/networkipv6config.cpp
<http://git.reviewboard.kde.org/r/101117/#comment2374>

Comparing addresses again here.


- Lamarque Vieira
Post by Ilia Kats
-----------------------------------------------------------
http://git.reviewboard.kde.org/r/101117/
-----------------------------------------------------------
(Updated April 16, 2011, 9:32 p.m.)
Review request for Network Management.
Summary
-------
The last IPv4 blocks have been assigned, so IPv6-support in KDE network management is long overdue. Attached patch makes that possible.
This addresses bug 270827.
http://bugs.kde.org/show_bug.cgi?id=270827
Diffs
-----
backends/NetworkManager/CMakeLists.txt a093415
backends/NetworkManager/connectiondbus.cpp 9c3c908
backends/NetworkManager/settings/ipv4dbus.cpp 7d167e9
backends/NetworkManager/settings/ipv6dbus.h PRE-CREATION
backends/NetworkManager/settings/ipv6dbus.cpp PRE-CREATION
libs/internals/CMakeLists.txt d5a0dab
libs/internals/connection.cpp a5fe2d3
libs/internals/connectionpersistence.cpp cc84af3
libs/internals/schemas/ipv4.kcfg a069ef8
libs/internals/schemas/ipv6.kcfg PRE-CREATION
libs/internals/schemas/ipv6.kcfgc PRE-CREATION
libs/internals/setting.cpp 197fafc
libs/internals/settings/ipv4.h fee2987
libs/internals/settings/ipv4.cpp 6c6fd64
libs/internals/settings/ipv4persistence.cpp c30622d
libs/internals/settings/ipv6.h PRE-CREATION
libs/internals/settings/ipv6.cpp PRE-CREATION
libs/internals/settings/ipv6persistence.h PRE-CREATION
libs/internals/settings/ipv6persistence.cpp PRE-CREATION
libs/ui/CMakeLists.txt aea6563
libs/ui/gsmconnectioneditor.cpp 39e7d3b
libs/ui/ipv4.ui e107869
libs/ui/ipv4widget.cpp 732a94e
libs/ui/ipv6.ui PRE-CREATION
libs/ui/ipv6advanced.ui PRE-CREATION
libs/ui/ipv6advancedwidget.h PRE-CREATION
libs/ui/ipv6advancedwidget.cpp PRE-CREATION
libs/ui/ipv6widget.h PRE-CREATION
libs/ui/ipv6widget.cpp PRE-CREATION
libs/ui/pppoepreferences.cpp be503c0
libs/ui/simpleipv6addressvalidator.h PRE-CREATION
libs/ui/simpleipv6addressvalidator.cpp PRE-CREATION
libs/ui/vpnpreferences.cpp 1714a51
libs/ui/wiredpreferences.cpp 003e05d
libs/ui/wirelesspreferences.cpp 7033c40
solidcontrolfuture/CMakeLists.txt 4643e8d
solidcontrolfuture/networkipv6config.h PRE-CREATION
solidcontrolfuture/networkipv6config.cpp PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/101117/diff
Testing
-------
Only on my local system, compared qdbus output with nm-applet and knetworkmanager, as well as created ad-hoc wlan connections and checked with ifconfig. My university's network does currently not support IPv6, so a field test could not be done.
Screenshots
-----------
Basic settings
http://git.reviewboard.kde.org/r/101117/s/125/
advanced settings
http://git.reviewboard.kde.org/r/101117/s/126/
Thanks,
Ilia
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-networkmanager/attachments/20110416/ff5f25f4/attachment.html
Ilia Kats
2011-04-17 10:23:17 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101117/
-----------------------------------------------------------

(Updated April 17, 2011, 10:23 a.m.)


Review request for Network Management.


Changes
-------

Removed unnecessary ifs. However, as I basically just copied kde-base/kde-workspace/libs/solid/control/networkipv4config.cpp and changed it to handle IPv6 addresses, this should be optimized there as well, for consistency's sake.


Summary
-------

The last IPv4 blocks have been assigned, so IPv6-support in KDE network management is long overdue. Attached patch makes that possible.


This addresses bug 270827.
http://bugs.kde.org/show_bug.cgi?id=270827


Diffs (updated)
-----

backends/NetworkManager/CMakeLists.txt a093415
backends/NetworkManager/connectiondbus.cpp 9c3c908
backends/NetworkManager/settings/ipv4dbus.cpp 7d167e9
backends/NetworkManager/settings/ipv6dbus.h PRE-CREATION
backends/NetworkManager/settings/ipv6dbus.cpp PRE-CREATION
libs/internals/CMakeLists.txt d5a0dab
libs/internals/connection.cpp a5fe2d3
libs/internals/connectionpersistence.cpp cc84af3
libs/internals/schemas/ipv4.kcfg a069ef8
libs/internals/schemas/ipv6.kcfg PRE-CREATION
libs/internals/schemas/ipv6.kcfgc PRE-CREATION
libs/internals/setting.cpp 197fafc
libs/internals/settings/ipv4.h fee2987
libs/internals/settings/ipv4.cpp 6c6fd64
libs/internals/settings/ipv4persistence.cpp c30622d
libs/internals/settings/ipv6.h PRE-CREATION
libs/internals/settings/ipv6.cpp PRE-CREATION
libs/internals/settings/ipv6persistence.h PRE-CREATION
libs/internals/settings/ipv6persistence.cpp PRE-CREATION
libs/ui/CMakeLists.txt aea6563
libs/ui/gsmconnectioneditor.cpp 39e7d3b
libs/ui/ipv4.ui e107869
libs/ui/ipv4widget.cpp 732a94e
libs/ui/ipv6.ui PRE-CREATION
libs/ui/ipv6advanced.ui PRE-CREATION
libs/ui/ipv6advancedwidget.h PRE-CREATION
libs/ui/ipv6advancedwidget.cpp PRE-CREATION
libs/ui/ipv6widget.h PRE-CREATION
libs/ui/ipv6widget.cpp PRE-CREATION
libs/ui/pppoepreferences.cpp be503c0
libs/ui/simpleipv6addressvalidator.h PRE-CREATION
libs/ui/simpleipv6addressvalidator.cpp PRE-CREATION
libs/ui/vpnpreferences.cpp 1714a51
libs/ui/wiredpreferences.cpp 003e05d
libs/ui/wirelesspreferences.cpp 7033c40
solidcontrolfuture/CMakeLists.txt 4643e8d
solidcontrolfuture/networkipv6config.h PRE-CREATION
solidcontrolfuture/networkipv6config.cpp PRE-CREATION

Diff: http://git.reviewboard.kde.org/r/101117/diff


Testing
-------

Only on my local system, compared qdbus output with nm-applet and knetworkmanager, as well as created ad-hoc wlan connections and checked with ifconfig. My university's network does currently not support IPv6, so a field test could not be done.


Screenshots
-----------

Basic settings
http://git.reviewboard.kde.org/r/101117/s/125/
advanced settings
http://git.reviewboard.kde.org/r/101117/s/126/


Thanks,

Ilia

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-networkmanager/attachments/20110417/33ab96bf/attachment.htm
Ilia Kats
2011-04-20 18:22:13 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101117/
-----------------------------------------------------------

(Updated April 20, 2011, 6:22 p.m.)


Review request for Network Management.


Changes
-------

enable DNS and search domain setting if DHCP (IP only) is selected


Summary
-------

The last IPv4 blocks have been assigned, so IPv6-support in KDE network management is long overdue. Attached patch makes that possible.


This addresses bug 270827.
http://bugs.kde.org/show_bug.cgi?id=270827


Diffs (updated)
-----

backends/NetworkManager/CMakeLists.txt a093415
backends/NetworkManager/connectiondbus.cpp 9c3c908
backends/NetworkManager/settings/ipv4dbus.cpp 7d167e9
backends/NetworkManager/settings/ipv6dbus.h PRE-CREATION
backends/NetworkManager/settings/ipv6dbus.cpp PRE-CREATION
libs/internals/CMakeLists.txt d5a0dab
libs/internals/connection.cpp a5fe2d3
libs/internals/connectionpersistence.cpp cc84af3
libs/internals/schemas/ipv4.kcfg a069ef8
libs/internals/schemas/ipv6.kcfg PRE-CREATION
libs/internals/schemas/ipv6.kcfgc PRE-CREATION
libs/internals/setting.cpp 197fafc
libs/internals/settings/ipv4.h fee2987
libs/internals/settings/ipv4.cpp 6c6fd64
libs/internals/settings/ipv4persistence.cpp c30622d
libs/internals/settings/ipv6.h PRE-CREATION
libs/internals/settings/ipv6.cpp PRE-CREATION
libs/internals/settings/ipv6persistence.h PRE-CREATION
libs/internals/settings/ipv6persistence.cpp PRE-CREATION
libs/ui/CMakeLists.txt aea6563
libs/ui/connectionwidget.cpp 1968315
libs/ui/gsmconnectioneditor.cpp 39e7d3b
libs/ui/ipv4.ui e107869
libs/ui/ipv4widget.cpp 732a94e
libs/ui/ipv6.ui PRE-CREATION
libs/ui/ipv6advanced.ui PRE-CREATION
libs/ui/ipv6advancedwidget.h PRE-CREATION
libs/ui/ipv6advancedwidget.cpp PRE-CREATION
libs/ui/ipv6widget.h PRE-CREATION
libs/ui/ipv6widget.cpp PRE-CREATION
libs/ui/pppoepreferences.cpp be503c0
libs/ui/simpleipv6addressvalidator.h PRE-CREATION
libs/ui/simpleipv6addressvalidator.cpp PRE-CREATION
libs/ui/vpnpreferences.cpp 1714a51
libs/ui/wiredpreferences.cpp 003e05d
libs/ui/wirelesspreferences.cpp 7033c40
solidcontrolfuture/CMakeLists.txt 4643e8d
solidcontrolfuture/networkipv6config.h PRE-CREATION
solidcontrolfuture/networkipv6config.cpp PRE-CREATION

Diff: http://git.reviewboard.kde.org/r/101117/diff


Testing
-------

Only on my local system, compared qdbus output with nm-applet and knetworkmanager, as well as created ad-hoc wlan connections and checked with ifconfig. My university's network does currently not support IPv6, so a field test could not be done.


Screenshots
-----------

Basic settings
http://git.reviewboard.kde.org/r/101117/s/125/
advanced settings
http://git.reviewboard.kde.org/r/101117/s/126/


Thanks,

Ilia

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-networkmanager/attachments/20110420/1ec6e620/attachment.htm
Ilia Kats
2011-04-20 18:25:59 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101117/#review2769
-----------------------------------------------------------



libs/ui/connectionwidget.cpp
<http://git.reviewboard.kde.org/r/101117/#comment2424>

Please ignore that, kinda got mixed up with another local branch.


- Ilia
Post by Ilia Kats
-----------------------------------------------------------
http://git.reviewboard.kde.org/r/101117/
-----------------------------------------------------------
(Updated April 20, 2011, 6:22 p.m.)
Review request for Network Management.
Summary
-------
The last IPv4 blocks have been assigned, so IPv6-support in KDE network management is long overdue. Attached patch makes that possible.
This addresses bug 270827.
http://bugs.kde.org/show_bug.cgi?id=270827
Diffs
-----
backends/NetworkManager/CMakeLists.txt a093415
backends/NetworkManager/connectiondbus.cpp 9c3c908
backends/NetworkManager/settings/ipv4dbus.cpp 7d167e9
backends/NetworkManager/settings/ipv6dbus.h PRE-CREATION
backends/NetworkManager/settings/ipv6dbus.cpp PRE-CREATION
libs/internals/CMakeLists.txt d5a0dab
libs/internals/connection.cpp a5fe2d3
libs/internals/connectionpersistence.cpp cc84af3
libs/internals/schemas/ipv4.kcfg a069ef8
libs/internals/schemas/ipv6.kcfg PRE-CREATION
libs/internals/schemas/ipv6.kcfgc PRE-CREATION
libs/internals/setting.cpp 197fafc
libs/internals/settings/ipv4.h fee2987
libs/internals/settings/ipv4.cpp 6c6fd64
libs/internals/settings/ipv4persistence.cpp c30622d
libs/internals/settings/ipv6.h PRE-CREATION
libs/internals/settings/ipv6.cpp PRE-CREATION
libs/internals/settings/ipv6persistence.h PRE-CREATION
libs/internals/settings/ipv6persistence.cpp PRE-CREATION
libs/ui/CMakeLists.txt aea6563
libs/ui/connectionwidget.cpp 1968315
libs/ui/gsmconnectioneditor.cpp 39e7d3b
libs/ui/ipv4.ui e107869
libs/ui/ipv4widget.cpp 732a94e
libs/ui/ipv6.ui PRE-CREATION
libs/ui/ipv6advanced.ui PRE-CREATION
libs/ui/ipv6advancedwidget.h PRE-CREATION
libs/ui/ipv6advancedwidget.cpp PRE-CREATION
libs/ui/ipv6widget.h PRE-CREATION
libs/ui/ipv6widget.cpp PRE-CREATION
libs/ui/pppoepreferences.cpp be503c0
libs/ui/simpleipv6addressvalidator.h PRE-CREATION
libs/ui/simpleipv6addressvalidator.cpp PRE-CREATION
libs/ui/vpnpreferences.cpp 1714a51
libs/ui/wiredpreferences.cpp 003e05d
libs/ui/wirelesspreferences.cpp 7033c40
solidcontrolfuture/CMakeLists.txt 4643e8d
solidcontrolfuture/networkipv6config.h PRE-CREATION
solidcontrolfuture/networkipv6config.cpp PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/101117/diff
Testing
-------
Only on my local system, compared qdbus output with nm-applet and knetworkmanager, as well as created ad-hoc wlan connections and checked with ifconfig. My university's network does currently not support IPv6, so a field test could not be done.
Screenshots
-----------
Basic settings
http://git.reviewboard.kde.org/r/101117/s/125/
advanced settings
http://git.reviewboard.kde.org/r/101117/s/126/
Thanks,
Ilia
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-networkmanager/attachments/20110420/10f28bde/attachment-0001.htm
Ilia Kats
2011-04-21 00:08:52 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101117/
-----------------------------------------------------------

(Updated April 21, 2011, 12:08 a.m.)


Review request for Network Management.


Changes
-------

Keep up with the changes of IPv4-widget, mainly the handling of additional IP addresses and DHCP.


Summary
-------

The last IPv4 blocks have been assigned, so IPv6-support in KDE network management is long overdue. Attached patch makes that possible.


This addresses bug 270827.
http://bugs.kde.org/show_bug.cgi?id=270827


Diffs (updated)
-----

backends/NetworkManager/CMakeLists.txt a093415
backends/NetworkManager/connectiondbus.cpp 9c3c908
backends/NetworkManager/settings/ipv4dbus.cpp 7d167e9
backends/NetworkManager/settings/ipv6dbus.h PRE-CREATION
backends/NetworkManager/settings/ipv6dbus.cpp PRE-CREATION
libs/internals/CMakeLists.txt d5a0dab
libs/internals/connection.cpp a5fe2d3
libs/internals/connectionpersistence.cpp cc84af3
libs/internals/schemas/ipv4.kcfg a069ef8
libs/internals/schemas/ipv6.kcfg PRE-CREATION
libs/internals/schemas/ipv6.kcfgc PRE-CREATION
libs/internals/setting.cpp 197fafc
libs/internals/settings/ipv4.h fee2987
libs/internals/settings/ipv4.cpp 6c6fd64
libs/internals/settings/ipv4persistence.cpp c30622d
libs/internals/settings/ipv6.h PRE-CREATION
libs/internals/settings/ipv6.cpp PRE-CREATION
libs/internals/settings/ipv6persistence.h PRE-CREATION
libs/internals/settings/ipv6persistence.cpp PRE-CREATION
libs/ui/CMakeLists.txt aea6563
libs/ui/gsmconnectioneditor.cpp 39e7d3b
libs/ui/ipv4.ui e107869
libs/ui/ipv4widget.cpp 26e597c
libs/ui/ipv6.ui PRE-CREATION
libs/ui/ipv6advanced.ui PRE-CREATION
libs/ui/ipv6advancedwidget.h PRE-CREATION
libs/ui/ipv6advancedwidget.cpp PRE-CREATION
libs/ui/ipv6widget.h PRE-CREATION
libs/ui/ipv6widget.cpp PRE-CREATION
libs/ui/pppoepreferences.cpp be503c0
libs/ui/simpleipv6addressvalidator.h PRE-CREATION
libs/ui/simpleipv6addressvalidator.cpp PRE-CREATION
libs/ui/vpnpreferences.cpp 1714a51
libs/ui/wiredpreferences.cpp 003e05d
libs/ui/wirelesspreferences.cpp 7033c40
solidcontrolfuture/CMakeLists.txt 4643e8d
solidcontrolfuture/networkipv6config.h PRE-CREATION
solidcontrolfuture/networkipv6config.cpp PRE-CREATION

Diff: http://git.reviewboard.kde.org/r/101117/diff


Testing
-------

Only on my local system, compared qdbus output with nm-applet and knetworkmanager, as well as created ad-hoc wlan connections and checked with ifconfig. My university's network does currently not support IPv6, so a field test could not be done.


Screenshots
-----------

Basic settings
http://git.reviewboard.kde.org/r/101117/s/125/
advanced settings
http://git.reviewboard.kde.org/r/101117/s/126/


Thanks,

Ilia

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-networkmanager/attachments/20110421/b4c4614e/attachment.htm
Commit Hook
2011-05-02 15:31:42 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101117/#review3064
-----------------------------------------------------------


This review has been submitted with commit c7482485eea7e5cc379240139e8657f0fb82f6d3 by Ilia Kats.

- Commit
Post by Ilia Kats
-----------------------------------------------------------
http://git.reviewboard.kde.org/r/101117/
-----------------------------------------------------------
(Updated April 21, 2011, 12:08 a.m.)
Review request for Network Management.
Summary
-------
The last IPv4 blocks have been assigned, so IPv6-support in KDE network management is long overdue. Attached patch makes that possible.
This addresses bug 270827.
http://bugs.kde.org/show_bug.cgi?id=270827
Diffs
-----
backends/NetworkManager/CMakeLists.txt a093415
backends/NetworkManager/connectiondbus.cpp 9c3c908
backends/NetworkManager/settings/ipv4dbus.cpp 7d167e9
backends/NetworkManager/settings/ipv6dbus.h PRE-CREATION
backends/NetworkManager/settings/ipv6dbus.cpp PRE-CREATION
libs/internals/CMakeLists.txt d5a0dab
libs/internals/connection.cpp a5fe2d3
libs/internals/connectionpersistence.cpp cc84af3
libs/internals/schemas/ipv4.kcfg a069ef8
libs/internals/schemas/ipv6.kcfg PRE-CREATION
libs/internals/schemas/ipv6.kcfgc PRE-CREATION
libs/internals/setting.cpp 197fafc
libs/internals/settings/ipv4.h fee2987
libs/internals/settings/ipv4.cpp 6c6fd64
libs/internals/settings/ipv4persistence.cpp c30622d
libs/internals/settings/ipv6.h PRE-CREATION
libs/internals/settings/ipv6.cpp PRE-CREATION
libs/internals/settings/ipv6persistence.h PRE-CREATION
libs/internals/settings/ipv6persistence.cpp PRE-CREATION
libs/ui/CMakeLists.txt aea6563
libs/ui/gsmconnectioneditor.cpp 39e7d3b
libs/ui/ipv4.ui e107869
libs/ui/ipv4widget.cpp 26e597c
libs/ui/ipv6.ui PRE-CREATION
libs/ui/ipv6advanced.ui PRE-CREATION
libs/ui/ipv6advancedwidget.h PRE-CREATION
libs/ui/ipv6advancedwidget.cpp PRE-CREATION
libs/ui/ipv6widget.h PRE-CREATION
libs/ui/ipv6widget.cpp PRE-CREATION
libs/ui/pppoepreferences.cpp be503c0
libs/ui/simpleipv6addressvalidator.h PRE-CREATION
libs/ui/simpleipv6addressvalidator.cpp PRE-CREATION
libs/ui/vpnpreferences.cpp 1714a51
libs/ui/wiredpreferences.cpp 003e05d
libs/ui/wirelesspreferences.cpp 7033c40
solidcontrolfuture/CMakeLists.txt 4643e8d
solidcontrolfuture/networkipv6config.h PRE-CREATION
solidcontrolfuture/networkipv6config.cpp PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/101117/diff
Testing
-------
Only on my local system, compared qdbus output with nm-applet and knetworkmanager, as well as created ad-hoc wlan connections and checked with ifconfig. My university's network does currently not support IPv6, so a field test could not be done.
Screenshots
-----------
Basic settings
http://git.reviewboard.kde.org/r/101117/s/125/
advanced settings
http://git.reviewboard.kde.org/r/101117/s/126/
Thanks,
Ilia
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-networkmanager/attachments/20110502/b015ddf8/attachment-0001.htm
Commit Hook
2011-05-02 16:03:49 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101117/#review3067
-----------------------------------------------------------


This review has been submitted with commit 0e316f701c34dbfee7a1de29d483596b00ba4c96 by Ilia Kats.

- Commit
Post by Ilia Kats
-----------------------------------------------------------
http://git.reviewboard.kde.org/r/101117/
-----------------------------------------------------------
(Updated April 21, 2011, 12:08 a.m.)
Review request for Network Management.
Summary
-------
The last IPv4 blocks have been assigned, so IPv6-support in KDE network management is long overdue. Attached patch makes that possible.
This addresses bug 270827.
http://bugs.kde.org/show_bug.cgi?id=270827
Diffs
-----
backends/NetworkManager/CMakeLists.txt a093415
backends/NetworkManager/connectiondbus.cpp 9c3c908
backends/NetworkManager/settings/ipv4dbus.cpp 7d167e9
backends/NetworkManager/settings/ipv6dbus.h PRE-CREATION
backends/NetworkManager/settings/ipv6dbus.cpp PRE-CREATION
libs/internals/CMakeLists.txt d5a0dab
libs/internals/connection.cpp a5fe2d3
libs/internals/connectionpersistence.cpp cc84af3
libs/internals/schemas/ipv4.kcfg a069ef8
libs/internals/schemas/ipv6.kcfg PRE-CREATION
libs/internals/schemas/ipv6.kcfgc PRE-CREATION
libs/internals/setting.cpp 197fafc
libs/internals/settings/ipv4.h fee2987
libs/internals/settings/ipv4.cpp 6c6fd64
libs/internals/settings/ipv4persistence.cpp c30622d
libs/internals/settings/ipv6.h PRE-CREATION
libs/internals/settings/ipv6.cpp PRE-CREATION
libs/internals/settings/ipv6persistence.h PRE-CREATION
libs/internals/settings/ipv6persistence.cpp PRE-CREATION
libs/ui/CMakeLists.txt aea6563
libs/ui/gsmconnectioneditor.cpp 39e7d3b
libs/ui/ipv4.ui e107869
libs/ui/ipv4widget.cpp 26e597c
libs/ui/ipv6.ui PRE-CREATION
libs/ui/ipv6advanced.ui PRE-CREATION
libs/ui/ipv6advancedwidget.h PRE-CREATION
libs/ui/ipv6advancedwidget.cpp PRE-CREATION
libs/ui/ipv6widget.h PRE-CREATION
libs/ui/ipv6widget.cpp PRE-CREATION
libs/ui/pppoepreferences.cpp be503c0
libs/ui/simpleipv6addressvalidator.h PRE-CREATION
libs/ui/simpleipv6addressvalidator.cpp PRE-CREATION
libs/ui/vpnpreferences.cpp 1714a51
libs/ui/wiredpreferences.cpp 003e05d
libs/ui/wirelesspreferences.cpp 7033c40
solidcontrolfuture/CMakeLists.txt 4643e8d
solidcontrolfuture/networkipv6config.h PRE-CREATION
solidcontrolfuture/networkipv6config.cpp PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/101117/diff
Testing
-------
Only on my local system, compared qdbus output with nm-applet and knetworkmanager, as well as created ad-hoc wlan connections and checked with ifconfig. My university's network does currently not support IPv6, so a field test could not be done.
Screenshots
-----------
Basic settings
http://git.reviewboard.kde.org/r/101117/s/125/
advanced settings
http://git.reviewboard.kde.org/r/101117/s/126/
Thanks,
Ilia
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-networkmanager/attachments/20110502/80e18237/attachment.htm
Lamarque Vieira Souza
2011-04-14 13:04:07 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101117/#review2638
-----------------------------------------------------------



backends/NetworkManager/CMakeLists.txt
<http://git.reviewboard.kde.org/r/101117/#comment2301>

Plese remove this trailing space line. By the way add bug 270827 to this review request.

Patch looks good. Almost all my comments are about text formating. It would be good if someone could text it in a real case.



backends/NetworkManager/connectiondbus.cpp
<http://git.reviewboard.kde.org/r/101117/#comment2302>

Remove trailing space.



backends/NetworkManager/settings/ipv6dbus.h
<http://git.reviewboard.kde.org/r/101117/#comment2303>

Remove trailing space.



backends/NetworkManager/settings/ipv6dbus.cpp
<http://git.reviewboard.kde.org/r/101117/#comment2331>

Remove this line.



backends/NetworkManager/settings/ipv6dbus.cpp
<http://git.reviewboard.kde.org/r/101117/#comment2330>

const QString &key.



backends/NetworkManager/settings/ipv6dbus.cpp
<http://git.reviewboard.kde.org/r/101117/#comment2329>

Remove extra space.



backends/NetworkManager/settings/ipv6dbus.cpp
<http://git.reviewboard.kde.org/r/101117/#comment2307>

Remove extra space.



backends/NetworkManager/settings/ipv6dbus.cpp
<http://git.reviewboard.kde.org/r/101117/#comment2304>

Remove trailing space.



backends/NetworkManager/settings/ipv6dbus.cpp
<http://git.reviewboard.kde.org/r/101117/#comment2310>

Remove extra space.



backends/NetworkManager/settings/ipv6dbus.cpp
<http://git.reviewboard.kde.org/r/101117/#comment2311>

Remove extra space.



backends/NetworkManager/settings/ipv6dbus.cpp
<http://git.reviewboard.kde.org/r/101117/#comment2312>

Remove extra space.



backends/NetworkManager/settings/ipv6dbus.cpp
<http://git.reviewboard.kde.org/r/101117/#comment2313>

Remove extra space.



backends/NetworkManager/settings/ipv6dbus.cpp
<http://git.reviewboard.kde.org/r/101117/#comment2314>

Remove extra space.



backends/NetworkManager/settings/ipv6dbus.cpp
<http://git.reviewboard.kde.org/r/101117/#comment2332>

Remove this line since it is not necessary.



backends/NetworkManager/settings/ipv6dbus.cpp
<http://git.reviewboard.kde.org/r/101117/#comment2308>

Remove extra space.



libs/internals/CMakeLists.txt
<http://git.reviewboard.kde.org/r/101117/#comment2315>

Remove extra space.



libs/internals/settings/ipv4.h
<http://git.reviewboard.kde.org/r/101117/#comment2309>

Remove extra space.



libs/internals/settings/ipv6.h
<http://git.reviewboard.kde.org/r/101117/#comment2306>

Remove extra space.



libs/internals/settings/ipv6persistence.cpp
<http://git.reviewboard.kde.org/r/101117/#comment2333>

Remove this extra line.



libs/internals/settings/ipv6persistence.cpp
<http://git.reviewboard.kde.org/r/101117/#comment2334>

Q_UNUSED is used to prevent compiling warnings. Using it in this scope will not prevent any warning.



libs/ui/ipv4widget.cpp
<http://git.reviewboard.kde.org/r/101117/#comment2316>

Remove extra space.



libs/ui/ipv4widget.cpp
<http://git.reviewboard.kde.org/r/101117/#comment2317>

Remove extra space.



libs/ui/ipv6advancedwidget.cpp
<http://git.reviewboard.kde.org/r/101117/#comment2326>

Remove this line since the header is not used.



libs/ui/ipv6widget.h
<http://git.reviewboard.kde.org/r/101117/#comment2327>

Remove extra line.



libs/ui/ipv6widget.cpp
<http://git.reviewboard.kde.org/r/101117/#comment2325>

Remove extra space.



libs/ui/ipv6widget.cpp
<http://git.reviewboard.kde.org/r/101117/#comment2328>

Remove this line since it is not necessary.



libs/ui/ipv6widget.cpp
<http://git.reviewboard.kde.org/r/101117/#comment2318>

Remove extra space.



libs/ui/ipv6widget.cpp
<http://git.reviewboard.kde.org/r/101117/#comment2319>

Remove extra space.



libs/ui/ipv6widget.cpp
<http://git.reviewboard.kde.org/r/101117/#comment2320>

Remove extra space.



libs/ui/simpleipv6addressvalidator.cpp
<http://git.reviewboard.kde.org/r/101117/#comment2321>

Remove extra space.



libs/ui/simpleipv6addressvalidator.cpp
<http://git.reviewboard.kde.org/r/101117/#comment2322>

Remove extra space.



solidcontrolfuture/networkipv6config.h
<http://git.reviewboard.kde.org/r/101117/#comment2323>

Remove extra space.



solidcontrolfuture/networkipv6config.h
<http://git.reviewboard.kde.org/r/101117/#comment2324>

Remove extra space in this line and the next.


- Lamarque Vieira
Post by Ilia Kats
-----------------------------------------------------------
http://git.reviewboard.kde.org/r/101117/
-----------------------------------------------------------
(Updated April 13, 2011, 9:46 p.m.)
Review request for Network Management.
Summary
-------
The last IPv4 blocks have been assigned, so IPv6-support in KDE network management is long overdue. Attached patch makes that possible.
Diffs
-----
backends/NetworkManager/CMakeLists.txt f6ff372
backends/NetworkManager/connectiondbus.cpp 4a142e9
backends/NetworkManager/settings/ipv4dbus.cpp f77d421
backends/NetworkManager/settings/ipv6dbus.h PRE-CREATION
backends/NetworkManager/settings/ipv6dbus.cpp PRE-CREATION
libs/internals/CMakeLists.txt d5a0dab
libs/internals/connection.cpp 3cd7e78
libs/internals/connectionpersistence.cpp 8396464
libs/internals/schemas/ipv4.kcfg a069ef8
libs/internals/schemas/ipv6.kcfg PRE-CREATION
libs/internals/schemas/ipv6.kcfgc PRE-CREATION
libs/internals/setting.cpp 197fafc
libs/internals/settings/ipv4.h fee2987
libs/internals/settings/ipv4.cpp 6c6fd64
libs/internals/settings/ipv4persistence.cpp c30622d
libs/internals/settings/ipv6.h PRE-CREATION
libs/internals/settings/ipv6.cpp PRE-CREATION
libs/internals/settings/ipv6persistence.h PRE-CREATION
libs/internals/settings/ipv6persistence.cpp PRE-CREATION
libs/ui/CMakeLists.txt aea6563
libs/ui/gsmconnectioneditor.cpp 5a26c7c
libs/ui/ipv4.ui e107869
libs/ui/ipv4widget.cpp 732a94e
libs/ui/ipv6.ui PRE-CREATION
libs/ui/ipv6advanced.ui PRE-CREATION
libs/ui/ipv6advancedwidget.h PRE-CREATION
libs/ui/ipv6advancedwidget.cpp PRE-CREATION
libs/ui/ipv6widget.h PRE-CREATION
libs/ui/ipv6widget.cpp PRE-CREATION
libs/ui/pppoepreferences.cpp 0cabcd0
libs/ui/simpleipv6addressvalidator.h PRE-CREATION
libs/ui/simpleipv6addressvalidator.cpp PRE-CREATION
libs/ui/vpnpreferences.cpp 5274d14
libs/ui/wiredpreferences.cpp 60b7932
libs/ui/wirelesspreferences.cpp 7f901c2
solidcontrolfuture/CMakeLists.txt 4643e8d
solidcontrolfuture/networkipv6config.h PRE-CREATION
solidcontrolfuture/networkipv6config.cpp PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/101117/diff
Testing
-------
Only on my local system, compared qdbus output with nm-applet and knetworkmanager, as well as created ad-hoc wlan connections and checked with ifconfig. My university's network does currently not support IPv6, so a field test could not be done.
Screenshots
-----------
Basic settings
http://git.reviewboard.kde.org/r/101117/s/125/
advanced settings
http://git.reviewboard.kde.org/r/101117/s/126/
Thanks,
Ilia
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-networkmanager/attachments/20110414/5831eace/attachment-0001.htm
Lamarque Vieira Souza
2011-05-02 15:18:47 UTC
Permalink
Well, since nobody else has anything to say about this patch I say ship it. This way someone else out there could test the code and since I want IPv6 support to nm09 branch it is better add it now than let the patches accumulating here in reviewboard.


- Lamarque Vieira


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101117/#review2638
-----------------------------------------------------------
Post by Ilia Kats
-----------------------------------------------------------
http://git.reviewboard.kde.org/r/101117/
-----------------------------------------------------------
(Updated April 21, 2011, 12:08 a.m.)
Review request for Network Management.
Summary
-------
The last IPv4 blocks have been assigned, so IPv6-support in KDE network management is long overdue. Attached patch makes that possible.
This addresses bug 270827.
http://bugs.kde.org/show_bug.cgi?id=270827
Diffs
-----
backends/NetworkManager/CMakeLists.txt a093415
backends/NetworkManager/connectiondbus.cpp 9c3c908
backends/NetworkManager/settings/ipv4dbus.cpp 7d167e9
backends/NetworkManager/settings/ipv6dbus.h PRE-CREATION
backends/NetworkManager/settings/ipv6dbus.cpp PRE-CREATION
libs/internals/CMakeLists.txt d5a0dab
libs/internals/connection.cpp a5fe2d3
libs/internals/connectionpersistence.cpp cc84af3
libs/internals/schemas/ipv4.kcfg a069ef8
libs/internals/schemas/ipv6.kcfg PRE-CREATION
libs/internals/schemas/ipv6.kcfgc PRE-CREATION
libs/internals/setting.cpp 197fafc
libs/internals/settings/ipv4.h fee2987
libs/internals/settings/ipv4.cpp 6c6fd64
libs/internals/settings/ipv4persistence.cpp c30622d
libs/internals/settings/ipv6.h PRE-CREATION
libs/internals/settings/ipv6.cpp PRE-CREATION
libs/internals/settings/ipv6persistence.h PRE-CREATION
libs/internals/settings/ipv6persistence.cpp PRE-CREATION
libs/ui/CMakeLists.txt aea6563
libs/ui/gsmconnectioneditor.cpp 39e7d3b
libs/ui/ipv4.ui e107869
libs/ui/ipv4widget.cpp 26e597c
libs/ui/ipv6.ui PRE-CREATION
libs/ui/ipv6advanced.ui PRE-CREATION
libs/ui/ipv6advancedwidget.h PRE-CREATION
libs/ui/ipv6advancedwidget.cpp PRE-CREATION
libs/ui/ipv6widget.h PRE-CREATION
libs/ui/ipv6widget.cpp PRE-CREATION
libs/ui/pppoepreferences.cpp be503c0
libs/ui/simpleipv6addressvalidator.h PRE-CREATION
libs/ui/simpleipv6addressvalidator.cpp PRE-CREATION
libs/ui/vpnpreferences.cpp 1714a51
libs/ui/wiredpreferences.cpp 003e05d
libs/ui/wirelesspreferences.cpp 7033c40
solidcontrolfuture/CMakeLists.txt 4643e8d
solidcontrolfuture/networkipv6config.h PRE-CREATION
solidcontrolfuture/networkipv6config.cpp PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/101117/diff
Testing
-------
Only on my local system, compared qdbus output with nm-applet and knetworkmanager, as well as created ad-hoc wlan connections and checked with ifconfig. My university's network does currently not support IPv6, so a field test could not be done.
Screenshots
-----------
Basic settings
http://git.reviewboard.kde.org/r/101117/s/125/
advanced settings
http://git.reviewboard.kde.org/r/101117/s/126/
Thanks,
Ilia
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-networkmanager/attachments/20110502/0e7efb9b/attachment.htm
Loading...