Review Request: NetworkManager 0.9 modified the system-wide connection modification name on polkit

[Rafael Fernández López]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101274/
-----------------------------------------------------------

Review request for Network Management.


Summary
-------

I am unable to create/modify/delete any kind of connection using the network manager applet on nm09 branch. I am using Arch Linux, and network manager version 0.8.998 (0.9).

I don't know if this is a distribution issue, or just some kind of difference between small networkmanager versions. However, it seems like 'org.freedesktop.NetworkManager.settings.modify.system' is the correct policy to ask for when creating/modifying or deleting system wide connections, instead of 'org.freedesktop.network-manager-settings.system.modify'.

With this patch, polkit-kde shows up requesting my password without any problems. With the unpatched version I get (depending on the action), but something like: "Adding connection failed. Error code is 0/2 ().".

It seems that Networkmanager developers updated this permission name [1], so I really think this should go in branch nm09 in order to work fine with nm09.


[1] http://projects.gnome.org/NetworkManager/developers/migrating-to-09/ref-migrating.html


Diffs
-----

backends/NetworkManager/nmdbussettingsconnectionprovider.cpp cfb241d

Diff: http://git.reviewboard.kde.org/r/101274/diff


Testing
-------

I am able to create/modify/delete wireless connections.


Thanks,

Rafael Fern?ndez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-networkmanager/attachments/20110502/a1800eb9/attachment.htm

[Rafael Fernández López]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101274/
-----------------------------------------------------------

(Updated May 2, 2011, 3:01 p.m.)


Review request for Network Management.


Changes
-------

This is actually on branch nm09


Summary
-------

I am unable to create/modify/delete any kind of connection using the network manager applet on nm09 branch. I am using Arch Linux, and network manager version 0.8.998 (0.9).

I don't know if this is a distribution issue, or just some kind of difference between small networkmanager versions. However, it seems like 'org.freedesktop.NetworkManager.settings.modify.system' is the correct policy to ask for when creating/modifying or deleting system wide connections, instead of 'org.freedesktop.network-manager-settings.system.modify'.

With this patch, polkit-kde shows up requesting my password without any problems. With the unpatched version I get (depending on the action), but something like: "Adding connection failed. Error code is 0/2 ().".

It seems that Networkmanager developers updated this permission name [1], so I really think this should go in branch nm09 in order to work fine with nm09.


[1] http://projects.gnome.org/NetworkManager/developers/migrating-to-09/ref-migrating.html


Diffs
-----

backends/NetworkManager/nmdbussettingsconnectionprovider.cpp cfb241d

Diff: http://git.reviewboard.kde.org/r/101274/diff


Testing
-------

I am able to create/modify/delete wireless connections.


Thanks,

Rafael Fern?ndez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-networkmanager/attachments/20110502/a9cfaf63/attachment-0001.htm

[Lamarque Vieira Souza]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101274/#review3096
-----------------------------------------------------------



backends/NetworkManager/nmdbussettingsconnectionprovider.cpp
<http://git.reviewboard.kde.org/r/101274/#comment2629>

Ship it in nm09 branch. Thanks for fixing this.


- Lamarque Vieira

Post by Rafael Fernández López
-----------------------------------------------------------
http://git.reviewboard.kde.org/r/101274/
-----------------------------------------------------------
(Updated May 2, 2011, 3:01 p.m.)
Review request for Network Management.
Summary
-------
I am unable to create/modify/delete any kind of connection using the network manager applet on nm09 branch. I am using Arch Linux, and network manager version 0.8.998 (0.9).
I don't know if this is a distribution issue, or just some kind of difference between small networkmanager versions. However, it seems like 'org.freedesktop.NetworkManager.settings.modify.system' is the correct policy to ask for when creating/modifying or deleting system wide connections, instead of 'org.freedesktop.network-manager-settings.system.modify'.
With this patch, polkit-kde shows up requesting my password without any problems. With the unpatched version I get (depending on the action), but something like: "Adding connection failed. Error code is 0/2 ().".
It seems that Networkmanager developers updated this permission name [1], so I really think this should go in branch nm09 in order to work fine with nm09.
[1] http://projects.gnome.org/NetworkManager/developers/migrating-to-09/ref-migrating.html
Diffs
-----
backends/NetworkManager/nmdbussettingsconnectionprovider.cpp cfb241d
Diff: http://git.reviewboard.kde.org/r/101274/diff
Testing
-------
I am able to create/modify/delete wireless connections.
Thanks,
Rafael Fern?ndez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-networkmanager/attachments/20110504/3de527af/attachment.htm

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101274/#review3109
-----------------------------------------------------------


This review has been submitted with commit 96060f9ac3e73b4a32a48e69138bdfcb14d7b910 by Rafael Fern?ndez L?pez.

- Commit

Post by Rafael Fernández López
-----------------------------------------------------------
http://git.reviewboard.kde.org/r/101274/
-----------------------------------------------------------
(Updated May 2, 2011, 3:01 p.m.)
Review request for Network Management.
Summary
-------
I am unable to create/modify/delete any kind of connection using the network manager applet on nm09 branch. I am using Arch Linux, and network manager version 0.8.998 (0.9).
I don't know if this is a distribution issue, or just some kind of difference between small networkmanager versions. However, it seems like 'org.freedesktop.NetworkManager.settings.modify.system' is the correct policy to ask for when creating/modifying or deleting system wide connections, instead of 'org.freedesktop.network-manager-settings.system.modify'.
With this patch, polkit-kde shows up requesting my password without any problems. With the unpatched version I get (depending on the action), but something like: "Adding connection failed. Error code is 0/2 ().".
It seems that Networkmanager developers updated this permission name [1], so I really think this should go in branch nm09 in order to work fine with nm09.
[1] http://projects.gnome.org/NetworkManager/developers/migrating-to-09/ref-migrating.html
Diffs
-----
backends/NetworkManager/nmdbussettingsconnectionprovider.cpp cfb241d
Diff: http://git.reviewboard.kde.org/r/101274/diff
Testing
-------
I am able to create/modify/delete wireless connections.
Thanks,
Rafael Fern?ndez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-networkmanager/attachments/20110504/9d3aaffd/attachment.htm