Review Request: Renaming var name in settings/config/mobileproviders.cpp

Discussion:

Swami Dhyan Nataraj [Nikolay Shaplov]

2012-02-11 07:00:48 UTC

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103921/
-----------------------------------------------------------

Review request for Network Management and Lamarque Vieira Souza.

Description
-------

In this part of code we do localize plan names, not providers. This patch changes name of the list. It also would be good to rename getProviderNameByLocale function, because it is used both for plans and providers, but I am not quite familiar with naming tradition to choose the name properly.

Diffs
-----

settings/config/mobileproviders.cpp 0bee2b3eb75766d01f7235ccf0971d150a09bcff

Diff: http://git.reviewboard.kde.org/r/103921/diff/diff

Testing
-------

Thanks,

Swami Dhyan Nataraj [Nikolay Shaplov]

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20120211/0a2099b8/attachment.html>

Swami Dhyan Nataraj [Nikolay Shaplov]

2012-02-11 07:02:07 UTC

Permalink

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103921/
-----------------------------------------------------------

(Updated Feb. 11, 2012, 7:02 a.m.)

Review request for Network Management and Lamarque Vieira Souza.

Description
-------

In this part of code we do localize plan names, not providers. This patch changes name of the list. It also would be good to rename getProviderNameByLocale function, because it is used both for plans and providers, but I am not quite familiar with naming tradition to choose the name properly.

Diffs
-----

settings/config/mobileproviders.cpp 0bee2b3eb75766d01f7235ccf0971d150a09bcff

Diff: http://git.reviewboard.kde.org/r/103921/diff/diff

Testing
-------

Thanks,

Swami Dhyan Nataraj [Nikolay Shaplov]

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20120211/9810b14f/attachment.html>

Commit Hook

2012-02-11 14:41:28 UTC

Permalink

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103921/#review10502
-----------------------------------------------------------

This review has been submitted with commit 6f449662d7c5c0622df59434a51c74ef2ce19c77 by Lamarque V. Souza to branch master.

- Commit Hook

Post by Swami Dhyan Nataraj [Nikolay Shaplov]
-----------------------------------------------------------
http://git.reviewboard.kde.org/r/103921/
-----------------------------------------------------------
(Updated Feb. 11, 2012, 7:02 a.m.)
Review request for Network Management and Lamarque Vieira Souza.
Description
-------
In this part of code we do localize plan names, not providers. This patch changes name of the list. It also would be good to rename getProviderNameByLocale function, because it is used both for plans and providers, but I am not quite familiar with naming tradition to choose the name properly.
Diffs
-----
settings/config/mobileproviders.cpp 0bee2b3eb75766d01f7235ccf0971d150a09bcff
Diff: http://git.reviewboard.kde.org/r/103921/diff/diff
Testing
-------
Thanks,
Swami Dhyan Nataraj [Nikolay Shaplov]

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20120211/34708c61/attachment.html>

Commit Hook

2012-02-11 14:41:34 UTC

Permalink

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103921/#review10503
-----------------------------------------------------------

This review has been submitted with commit 79bd5d65b76a82583e75407db99499ef273f5224 by Lamarque V. Souza to branch nm09.

- Commit Hook

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20120211/c84024c0/attachment.html>