Discussion:
Review Request 123657: Drop support for WiMAX for NM 1.2.0+
Jan Grulich
2015-05-06 08:14:48 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123657/
-----------------------------------------------------------

Review request for Network Management, Lukáš Tinkl and Lamarque Souza.


Repository: plasma-nm


Description
-------

This patch drops support for WiMAX when using NM 1.2.0+. WiMAX support has been already dropped in NetworkManager and networkmanager-qt. Compiling against nm-qt using NM 1.2.0+ will fail if we do not drop this support in plasma-nm.


Diffs
-----

libs/declarative/availabledevices.h cd2b447
libs/declarative/availabledevices.cpp cf9c316
libs/declarative/enabledconnections.h 088f37a
libs/declarative/enabledconnections.cpp cb5f1db
libs/editor/widgets/hwaddrcombobox.cpp d644409
libs/handler.h f792a93
libs/handler.cpp 32a1fe4
libs/models/networkmodel.h d506960
libs/models/networkmodel.cpp ee95aaa
libs/models/networkmodelitem.cpp b8cd03d
libs/uiutils.h 6ed411d
libs/uiutils.cpp c624b30

Diff: https://git.reviewboard.kde.org/r/123657/diff/


Testing
-------


Thanks,

Jan Grulich
Lamarque Souza
2015-05-06 11:06:21 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123657/#review79961
-----------------------------------------------------------

Ship it!


Ship It!

- Lamarque Souza
Post by Jan Grulich
-----------------------------------------------------------
https://git.reviewboard.kde.org/r/123657/
-----------------------------------------------------------
(Updated May 6, 2015, 8:14 a.m.)
Review request for Network Management, Lukáš Tinkl and Lamarque Souza.
Repository: plasma-nm
Description
-------
This patch drops support for WiMAX when using NM 1.2.0+. WiMAX support has been already dropped in NetworkManager and networkmanager-qt. Compiling against nm-qt using NM 1.2.0+ will fail if we do not drop this support in plasma-nm.
Diffs
-----
libs/declarative/availabledevices.h cd2b447
libs/declarative/availabledevices.cpp cf9c316
libs/declarative/enabledconnections.h 088f37a
libs/declarative/enabledconnections.cpp cb5f1db
libs/editor/widgets/hwaddrcombobox.cpp d644409
libs/handler.h f792a93
libs/handler.cpp 32a1fe4
libs/models/networkmodel.h d506960
libs/models/networkmodel.cpp ee95aaa
libs/models/networkmodelitem.cpp b8cd03d
libs/uiutils.h 6ed411d
libs/uiutils.cpp c624b30
Diff: https://git.reviewboard.kde.org/r/123657/diff/
Testing
-------
Thanks,
Jan Grulich
Jan Grulich
2015-05-06 11:28:44 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123657/
-----------------------------------------------------------

(Updated May 6, 2015, 11:28 a.m.)


Status
------

This change has been marked as submitted.


Review request for Network Management, Lukáš Tinkl and Lamarque Souza.


Changes
-------

Submitted with commit c3004a42dea04efed319e18da6e89711afae86ba by Jan Grulich to branch master.


Repository: plasma-nm


Description
-------

This patch drops support for WiMAX when using NM 1.2.0+. WiMAX support has been already dropped in NetworkManager and networkmanager-qt. Compiling against nm-qt using NM 1.2.0+ will fail if we do not drop this support in plasma-nm.


Diffs
-----

libs/declarative/availabledevices.h cd2b447
libs/declarative/availabledevices.cpp cf9c316
libs/declarative/enabledconnections.h 088f37a
libs/declarative/enabledconnections.cpp cb5f1db
libs/editor/widgets/hwaddrcombobox.cpp d644409
libs/handler.h f792a93
libs/handler.cpp 32a1fe4
libs/models/networkmodel.h d506960
libs/models/networkmodel.cpp ee95aaa
libs/models/networkmodelitem.cpp b8cd03d
libs/uiutils.h 6ed411d
libs/uiutils.cpp c624b30

Diff: https://git.reviewboard.kde.org/r/123657/diff/


Testing
-------


Thanks,

Jan Grulich

Loading...