Discussion:
Review Request 120082: delay the notifications and secret agent initializations until needed
Lukáš Tinkl
2014-09-06 15:58:24 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120082/
-----------------------------------------------------------

Review request for Network Management.


Bugs: 338513
http://bugs.kde.org/show_bug.cgi?id=338513


Repository: plasma-nm


Description
-------

Move the initializations until it's really needed, into handler. That way both the applet and editor get the passwords and at the same time don't block the Plasma Shell startup. More info in the bugreport below


BUG: 338513


Diffs
-----

libs/handler.cpp 07737276f698d2ba26bb3c3250d60524a40bc3fd
kded/service.h 01b13606eb3662b83dd5f39e3ffcbc0e9aeaf64f
kded/service.cpp 5dfbc03d2ccb570eac397976f553acebe6d0a357
libs/handler.h 5436281603666977b007b7d553b22d9dcbe6a043

Diff: https://git.reviewboard.kde.org/r/120082/diff/


Testing
-------

Tested with both plasmashell and standalone plasma-nm-connection editor, even without kded5 running


Thanks,

Luk?? Tinkl

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20140906/ba2b804c/attachment.html>
Lamarque Souza
2014-09-06 22:25:11 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120082/#review65939
-----------------------------------------------------------



kded/service.cpp
<https://git.reviewboard.kde.org/r/120082/#comment46059>

Why create two separated methods? We can create just one finishInitialization() method like I did in the networkmanagement with the contents of both initializeSecreAgent() and initializeNotification(). Moreover, we can move the allocation of ModemMonitor and BluetoothMonitor to finishInitialization() too.


- Lamarque Souza
Post by Lukáš Tinkl
-----------------------------------------------------------
https://git.reviewboard.kde.org/r/120082/
-----------------------------------------------------------
(Updated Sept. 6, 2014, 3:58 p.m.)
Review request for Network Management.
Bugs: 338513
http://bugs.kde.org/show_bug.cgi?id=338513
Repository: plasma-nm
Description
-------
Move the initializations until it's really needed, into handler. That way both the applet and editor get the passwords and at the same time don't block the Plasma Shell startup. More info in the bugreport below
BUG: 338513
Diffs
-----
libs/handler.cpp 07737276f698d2ba26bb3c3250d60524a40bc3fd
kded/service.h 01b13606eb3662b83dd5f39e3ffcbc0e9aeaf64f
kded/service.cpp 5dfbc03d2ccb570eac397976f553acebe6d0a357
libs/handler.h 5436281603666977b007b7d553b22d9dcbe6a043
Diff: https://git.reviewboard.kde.org/r/120082/diff/
Testing
-------
Tested with both plasmashell and standalone plasma-nm-connection editor, even without kded5 running
Thanks,
Luk?? Tinkl
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20140906/9e6516d1/attachment.html>
Lukáš Tinkl
2014-09-07 08:37:19 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120082/
-----------------------------------------------------------

(Updated Z??. 7, 2014, 10:37 dop.)


Review request for Network Management.


Changes
-------

move all the initialization in init() method


Bugs: 338513
http://bugs.kde.org/show_bug.cgi?id=338513


Repository: plasma-nm


Description
-------

Move the initializations until it's really needed, into handler. That way both the applet and editor get the passwords and at the same time don't block the Plasma Shell startup. More info in the bugreport below


BUG: 338513


Diffs (updated)
-----

kded/service.h 01b13606eb3662b83dd5f39e3ffcbc0e9aeaf64f
kded/service.cpp 5dfbc03d2ccb570eac397976f553acebe6d0a357
libs/handler.h 5436281603666977b007b7d553b22d9dcbe6a043
libs/handler.cpp 07737276f698d2ba26bb3c3250d60524a40bc3fd

Diff: https://git.reviewboard.kde.org/r/120082/diff/


Testing
-------

Tested with both plasmashell and standalone plasma-nm-connection editor, even without kded5 running


Thanks,

Luk?? Tinkl

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20140907/09108118/attachment.html>
Lamarque Souza
2014-09-07 08:42:45 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120082/#review65949
-----------------------------------------------------------

Ship it!


Ship It!

- Lamarque Souza
Post by Lukáš Tinkl
-----------------------------------------------------------
https://git.reviewboard.kde.org/r/120082/
-----------------------------------------------------------
(Updated Set. 7, 2014, 8:37 a.m.)
Review request for Network Management.
Bugs: 338513
http://bugs.kde.org/show_bug.cgi?id=338513
Repository: plasma-nm
Description
-------
Move the initializations until it's really needed, into handler. That way both the applet and editor get the passwords and at the same time don't block the Plasma Shell startup. More info in the bugreport below
BUG: 338513
Diffs
-----
kded/service.h 01b13606eb3662b83dd5f39e3ffcbc0e9aeaf64f
kded/service.cpp 5dfbc03d2ccb570eac397976f553acebe6d0a357
libs/handler.h 5436281603666977b007b7d553b22d9dcbe6a043
libs/handler.cpp 07737276f698d2ba26bb3c3250d60524a40bc3fd
Diff: https://git.reviewboard.kde.org/r/120082/diff/
Testing
-------
Tested with both plasmashell and standalone plasma-nm-connection editor, even without kded5 running
Thanks,
Luk?? Tinkl
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20140907/cd990b08/attachment-0001.html>
Lukáš Tinkl
2014-09-07 09:21:54 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120082/
-----------------------------------------------------------

(Updated Sept. 7, 2014, 9:21 a.m.)


Status
------

This change has been marked as submitted.


Review request for Network Management.


Bugs: 338513
http://bugs.kde.org/show_bug.cgi?id=338513


Repository: plasma-nm


Description
-------

Move the initializations until it's really needed, into handler. That way both the applet and editor get the passwords and at the same time don't block the Plasma Shell startup. More info in the bugreport below


BUG: 338513


Diffs
-----

kded/service.h 01b13606eb3662b83dd5f39e3ffcbc0e9aeaf64f
kded/service.cpp 5dfbc03d2ccb570eac397976f553acebe6d0a357
libs/handler.h 5436281603666977b007b7d553b22d9dcbe6a043
libs/handler.cpp 07737276f698d2ba26bb3c3250d60524a40bc3fd

Diff: https://git.reviewboard.kde.org/r/120082/diff/


Testing
-------

Tested with both plasmashell and standalone plasma-nm-connection editor, even without kded5 running


Thanks,

Luk?? Tinkl

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20140907/03b76da9/attachment.html>
Loading...