Review Request 108941: Missing password field in password dialog when using wpa2 connections

Discussion:

Lamarque Vieira Souza

2013-02-13 13:38:52 UTC

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108941/#review27363
-----------------------------------------------------------

libs/ui/security/security8021xauth.cpp
<http://git.reviewboard.kde.org/r/108941/#comment20582>

I am wondering why needSecrets() returns empty. Long ago I added a hack to make sure it returns a non-empty QStringList, it seems something else is missing. Can you try the patch in http://paste.kde.org/670268/ without this patch applied and check if it also solves the problem?

- Lamarque Vieira Souza

-----------------------------------------------------------
http://git.reviewboard.kde.org/r/108941/
-----------------------------------------------------------
(Updated Feb. 13, 2013, 11:02 a.m.)
Review request for Network Management and Lamarque Vieira Souza.
Description
-------
The dialog was created by the needed secrets. When the user entered the wrong password then secrets were empty so we have to use another way to find out what password we need. Tested on eduroam and it seems that it works without a problem.
This addresses bug 299868.
http://bugs.kde.org/show_bug.cgi?id=299868
Diffs
-----
libs/ui/security/security8021xauth.cpp 5c67355
Diff: http://git.reviewboard.kde.org/r/108941/diff/
Testing
-------
Thanks,
Jan Grulich

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20130213/b588e719/attachment.html>

Lamarque Vieira Souza

2013-02-13 16:55:53 UTC

Permalink

libs/ui/security/security8021xauth.cpp, line 58
<http://git.reviewboard.kde.org/r/108941/diff/1/?file=113890#file113890line58>
I am wondering why needSecrets() returns empty. Long ago I added a hack to make sure it returns a non-empty QStringList, it seems something else is missing. Can you try the patch in http://paste.kde.org/670268/ without this patch applied and check if it also solves the problem?

It returns an empty list, because in needSecrets() method is a condition where we test if required password is empty, but it is not because it is entered incorrectly.

Well, so this problem affects all connection types. needSecrets() should list all possible secrets when NetworkManager passes the RequestNew flag. We can add a bool parameter to needSecrets() indicating if it should list all possible secrets and them call needSecrets(pair.second & RequestNew) in SecretStorage::walletOpenedForRead(). That should fix the problem for all connection types.

- Lamarque Vieira

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108941/#review27363
-----------------------------------------------------------

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20130213/e621325a/attachment.html>

Jan Grulich

2013-02-13 11:02:00 UTC

Permalink

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108941/
-----------------------------------------------------------

Review request for Network Management and Lamarque Vieira Souza.

Description
-------

The dialog was created by the needed secrets. When the user entered the wrong password then secrets were empty so we have to use another way to find out what password we need. Tested on eduroam and it seems that it works without a problem.

This addresses bug 299868.
http://bugs.kde.org/show_bug.cgi?id=299868

Diffs
-----

libs/ui/security/security8021xauth.cpp 5c67355

Diff: http://git.reviewboard.kde.org/r/108941/diff/

Testing
-------

Thanks,

Jan Grulich

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20130213/c63b92ee/attachment-0001.html>

Jan Grulich

2013-02-13 16:30:26 UTC

Permalink

I think your solution and the previous patch is useless, because it has no effect. It will always return an empty list. It works only when the password is missing, then needSecrets() method will return a non-empty list with secrets.

Post by Lamarque Vieira Souza

It returns an empty list, because in needSecrets() method is a condition where we test if required password is empty, but it is not because it is entered incorrectly.

- Jan

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108941/#review27363
-----------------------------------------------------------

Post by Lamarque Vieira Souza
-----------------------------------------------------------
http://git.reviewboard.kde.org/r/108941/
-----------------------------------------------------------
(Updated Feb. 13, 2013, 11:02 a.m.)
Review request for Network Management and Lamarque Vieira Souza.
Description
-------
The dialog was created by the needed secrets. When the user entered the wrong password then secrets were empty so we have to use another way to find out what password we need. Tested on eduroam and it seems that it works without a problem.
This addresses bug 299868.
http://bugs.kde.org/show_bug.cgi?id=299868
Diffs
-----
libs/ui/security/security8021xauth.cpp 5c67355
Diff: http://git.reviewboard.kde.org/r/108941/diff/
Testing
-------
Thanks,
Jan Grulich

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20130213/afce6d21/attachment-0001.html>