Review Request 109769: Use UTF8 encoding for SSIDs

Discussion:

Lamarque Vieira Souza

2013-03-27 19:20:29 UTC

-----------------------------------------------------------
http://git.reviewboard.kde.org/r/109769/
-----------------------------------------------------------
(Updated March 27, 2013, 7:02 p.m.)
Review request for Network Management and Lamarque Vieira Souza.
Description
-------
This patch changes the encoding used for SSIDs to UTF8. IMHO that's the only internationally sensible choice. For example, the hotspot of a friend's iPad used UTF8. The Gnome NM frontend displayed that SSID correctly.
I also have the same patch available for libnm-qt (in file accesspoint.cpp), so I could push that as well.
Diffs
-----
solidcontrolfuture/solid/networkmanager-0.9/accesspoint.cpp bb3c9e1
Diff: http://git.reviewboard.kde.org/r/109769/diff/
Testing
-------
Verified that the mentioned iPhone hotspot is now displayed correctly.
Thanks,
Ralf Jung

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20130327/b1f1f87b/attachment.html>

Lukáš Tinkl

2013-03-27 19:23:19 UTC

Permalink

Post by Lamarque Vieira Souza

Post by Lamarque Vieira Souza
Ship It!

We just fixed it today in libnm-qt/settings branch btw

- Luk??

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109769/#review29964
-----------------------------------------------------------

Post by Lamarque Vieira Souza
-----------------------------------------------------------
http://git.reviewboard.kde.org/r/109769/
-----------------------------------------------------------
(Updated March 27, 2013, 8:02 p.m.)
Review request for Network Management and Lamarque Vieira Souza.
Description
-------
This patch changes the encoding used for SSIDs to UTF8. IMHO that's the only internationally sensible choice. For example, the hotspot of a friend's iPad used UTF8. The Gnome NM frontend displayed that SSID correctly.
I also have the same patch available for libnm-qt (in file accesspoint.cpp), so I could push that as well.
Diffs
-----
solidcontrolfuture/solid/networkmanager-0.9/accesspoint.cpp bb3c9e1
Diff: http://git.reviewboard.kde.org/r/109769/diff/
Testing
-------
Verified that the mentioned iPhone hotspot is now displayed correctly.
Thanks,
Ralf Jung

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20130327/1bece602/attachment.html>

Commit Hook

2013-03-27 19:30:10 UTC

Permalink

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109769/#review29966
-----------------------------------------------------------

This review has been submitted with commit 3550d13481b06a61a1e3ce80e4f168a58dc63877 by Ralf Jung to branch master.

- Commit Hook

Post by Lamarque Vieira Souza
-----------------------------------------------------------
http://git.reviewboard.kde.org/r/109769/
-----------------------------------------------------------
(Updated March 27, 2013, 7:02 p.m.)
Review request for Network Management and Lamarque Vieira Souza.
Description
-------
This patch changes the encoding used for SSIDs to UTF8. IMHO that's the only internationally sensible choice. For example, the hotspot of a friend's iPad used UTF8. The Gnome NM frontend displayed that SSID correctly.
I also have the same patch available for libnm-qt (in file accesspoint.cpp), so I could push that as well.
Diffs
-----
solidcontrolfuture/solid/networkmanager-0.9/accesspoint.cpp bb3c9e1
Diff: http://git.reviewboard.kde.org/r/109769/diff/
Testing
-------
Verified that the mentioned iPhone hotspot is now displayed correctly.
Thanks,
Ralf Jung

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20130327/40f96b46/attachment.html>

Commit Hook

2013-03-27 19:30:13 UTC

Permalink

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109769/
-----------------------------------------------------------

(Updated March 27, 2013, 7:30 p.m.)

Status
------

This change has been marked as submitted.

Review request for Network Management and Lamarque Vieira Souza.

Description
-------

This patch changes the encoding used for SSIDs to UTF8. IMHO that's the only internationally sensible choice. For example, the hotspot of a friend's iPad used UTF8. The Gnome NM frontend displayed that SSID correctly.

I also have the same patch available for libnm-qt (in file accesspoint.cpp), so I could push that as well.

Diffs
-----

solidcontrolfuture/solid/networkmanager-0.9/accesspoint.cpp bb3c9e1

Diff: http://git.reviewboard.kde.org/r/109769/diff/

Testing
-------

Verified that the mentioned iPhone hotspot is now displayed correctly.

Thanks,

Ralf Jung

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20130327/58ce8e55/attachment.html>

Ralf Jung

2013-03-27 19:02:32 UTC

Permalink

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109769/
-----------------------------------------------------------

Review request for Network Management and Lamarque Vieira Souza.

Description
-------

This patch changes the encoding used for SSIDs to UTF8. IMHO that's the only internationally sensible choice. For example, the hotspot of a friend's iPad used UTF8. The Gnome NM frontend displayed that SSID correctly.

I also have the same patch available for libnm-qt (in file accesspoint.cpp), so I could push that as well.

Diffs
-----

solidcontrolfuture/solid/networkmanager-0.9/accesspoint.cpp bb3c9e1

Diff: http://git.reviewboard.kde.org/r/109769/diff/

Testing
-------

Verified that the mentioned iPhone hotspot is now displayed correctly.

Thanks,

Ralf Jung

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20130327/26e54d5c/attachment.html>

Ralf Jung

2013-03-27 20:16:27 UTC

Permalink

Post by LukÃ¡Å¡ Tinkl

Post by Lamarque Vieira Souza
Ship It!

We just fixed it today in libnm-qt/settings branch btw

I pushed stuff to libnm-qt/master and networkmanagement/nm09 - however these branches relate to the settings one... ;-)

- Ralf

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109769/#review29964
-----------------------------------------------------------

Post by LukÃ¡Å¡ Tinkl
-----------------------------------------------------------
http://git.reviewboard.kde.org/r/109769/
-----------------------------------------------------------
(Updated March 27, 2013, 8:30 p.m.)
Review request for Network Management and Lamarque Vieira Souza.
Description
-------
This patch changes the encoding used for SSIDs to UTF8. IMHO that's the only internationally sensible choice. For example, the hotspot of a friend's iPad used UTF8. The Gnome NM frontend displayed that SSID correctly.
I also have the same patch available for libnm-qt (in file accesspoint.cpp), so I could push that as well.
Diffs
-----
solidcontrolfuture/solid/networkmanager-0.9/accesspoint.cpp bb3c9e1
Diff: http://git.reviewboard.kde.org/r/109769/diff/
Testing
-------
Verified that the mentioned iPhone hotspot is now displayed correctly.
Thanks,
Ralf Jung

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20130327/88afb858/attachment.html>