Review Request 114020: Set 'Delete Key' as default shortcut for Delete action

Discussion:

Andrea Scarpino

2013-11-27 18:01:02 UTC

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114020/
-----------------------------------------------------------

(Updated Nov. 27, 2013, 7:01 p.m.)

Review request for Network Management, Jan Grulich and Luk?? Tinkl.

Repository: plasma-nm

Description
-------

as subject, this add the default shortcut 'Delete' for the Delete action.

Diffs
-----

editor/connectioneditor.cpp 644b8f6e1b8e4372359fff7f6aa59bddbedb5a03

Diff: http://git.reviewboard.kde.org/r/114020/diff/

Testing
-------

Thanks,

Andrea Scarpino

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20131127/0f70ed8f/attachment.html>

Lukáš Tinkl

2013-11-27 18:03:31 UTC

Permalink

Post by Andrea Scarpino
-----------------------------------------------------------
http://git.reviewboard.kde.org/r/114020/
-----------------------------------------------------------
(Updated Nov. 27, 2013, 7:01 p.m.)
Review request for Network Management, Jan Grulich and Luk?? Tinkl.
Repository: plasma-nm
Description
-------
as subject, this add the default shortcut 'Delete' for the Delete action.
Diffs
-----
editor/connectioneditor.cpp 644b8f6e1b8e4372359fff7f6aa59bddbedb5a03
Diff: http://git.reviewboard.kde.org/r/114020/diff/
Testing
-------
Thanks,
Andrea Scarpino

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20131127/90fd571e/attachment.html>

Commit Hook

2013-11-27 20:42:02 UTC

Permalink

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114020/#review44620
-----------------------------------------------------------

This review has been submitted with commit 16eb662d0f2c4538a87604b44f01cf245c123c16 by Andrea Scarpino to branch master.

- Commit Hook

Post by Andrea Scarpino
-----------------------------------------------------------
http://git.reviewboard.kde.org/r/114020/
-----------------------------------------------------------
(Updated Nov. 27, 2013, 6:01 p.m.)
Review request for Network Management, Jan Grulich and Luk?? Tinkl.
Repository: plasma-nm
Description
-------
as subject, this add the default shortcut 'Delete' for the Delete action.
Diffs
-----
editor/connectioneditor.cpp 644b8f6e1b8e4372359fff7f6aa59bddbedb5a03
Diff: http://git.reviewboard.kde.org/r/114020/diff/
Testing
-------
Thanks,
Andrea Scarpino

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20131127/182558fd/attachment.html>

Andrea Scarpino

2013-11-27 20:42:05 UTC

Permalink

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114020/
-----------------------------------------------------------

(Updated Nov. 27, 2013, 8:42 p.m.)

Status
------

This change has been marked as submitted.

Review request for Network Management, Jan Grulich and Luk?? Tinkl.

Repository: plasma-nm

Description
-------

as subject, this add the default shortcut 'Delete' for the Delete action.

Diffs
-----

editor/connectioneditor.cpp 644b8f6e1b8e4372359fff7f6aa59bddbedb5a03

Diff: http://git.reviewboard.kde.org/r/114020/diff/

Testing
-------

Thanks,

Andrea Scarpino

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20131127/10bb0f81/attachment.html>