Review Request: Fix build error due to missing include QDbusPendingReply

Discussion:

Rajeesh K Nambiar

2011-07-10 19:08:23 UTC

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101910/
-----------------------------------------------------------

Review request for Network Management and Lamarque Vieira Souza.

Summary
-------

Add missing include for QDBusPendingReply in commit 28bc1f52c to fix build failure.

This addresses bug 251214.
http://bugs.kde.org/show_bug.cgi?id=251214

Diffs
-----

libs/service/networkinterfacemonitor.h 00dfff6

Diff: http://git.reviewboard.kde.org/r/101910/diff

Testing
-------

Built RPM.

Thanks,

Rajeesh

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-networkmanager/attachments/20110710/6f1ce358/attachment.htm

Lamarque Vieira Souza

2011-07-10 19:23:04 UTC

Permalink

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101910/#review4578
-----------------------------------------------------------

libs/service/networkinterfacemonitor.h
<http://git.reviewboard.kde.org/r/101910/#comment3987>

What is the error message? I do not see any compilation error here.

- Lamarque Vieira

Post by Rajeesh K Nambiar
-----------------------------------------------------------
http://git.reviewboard.kde.org/r/101910/
-----------------------------------------------------------
(Updated July 10, 2011, 7:08 p.m.)
Review request for Network Management and Lamarque Vieira Souza.
Summary
-------
Add missing include for QDBusPendingReply in commit 28bc1f52c to fix build failure.
This addresses bug 251214.
http://bugs.kde.org/show_bug.cgi?id=251214
Diffs
-----
libs/service/networkinterfacemonitor.h 00dfff6
Diff: http://git.reviewboard.kde.org/r/101910/diff
Testing
-------
Built RPM.
Thanks,
Rajeesh

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-networkmanager/attachments/20110710/cd019cd7/attachment.htm

Ilia Kats

2011-07-10 19:45:31 UTC

Permalink

Post by Rajeesh K Nambiar

libs/service/networkinterfacemonitor.h, line 26
<http://git.reviewboard.kde.org/r/101910/diff/1/?file=26656#file26656line26>
What is the error message? I do not see any compilation error here.

I can confirm the error, message is:
/home/ilia/networkmanagement/libs/service/networkinterfacemonitor.cpp: In member function ?void NetworkInterfaceMonitor::onSendPinArrived(QDBusPendingCallWatcher*)?:
/home/ilia/networkmanagement/libs/service/networkinterfacemonitor.cpp:202:4: error: ?QDBusPendingReply? was not declared in this scope
/home/ilia/networkmanagement/libs/service/networkinterfacemonitor.cpp:202:22: error: expected primary-expression before ?>? token
/home/ilia/networkmanagement/libs/service/networkinterfacemonitor.cpp:202:24: error: ?reply? was not declared in this scope

- Ilia

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101910/#review4578
-----------------------------------------------------------

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-networkmanager/attachments/20110710/97639e61/attachment.htm

Commit Hook

2011-07-10 19:56:46 UTC

Permalink

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101910/#review4580
-----------------------------------------------------------

This review has been submitted with commit e952cbc9db86ef81f785e1483d86a765d0f95ab7 by Lamarque V. Souza to branch nm09.

- Commit

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-networkmanager/attachments/20110710/5261dccc/attachment.htm