Discussion:
Review Request 120530: Ask user whether he wants to copy certificates under KDE configuration when importing OpenVPN configuration
Jan Grulich
2014-10-08 13:41:07 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120530/
-----------------------------------------------------------

Review request for Network Management, Luk?? Tinkl and Lamarque Souza.


Bugs: 329837 and 339654
http://bugs.kde.org/show_bug.cgi?id=329837
http://bugs.kde.org/show_bug.cgi?id=339654


Repository: plasma-nm


Description
-------

This patch adds a simple dialog which asks a user whether he wants to copy his certificates under .kde/share/apps/networkmanagement or if he wants to keep locations from the configuration file. It also adds suffixes to copied certificates, because in some cases when user has more certificates under the same name except the suffix, then only the first one is copied to our location.


Diffs
-----

vpn/openvpn/openvpn.cpp e83d148

Diff: https://git.reviewboard.kde.org/r/120530/diff/


Testing
-------


Thanks,

Jan Grulich

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20141008/e85138fc/attachment.html>
Lamarque Souza
2014-10-08 13:55:59 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120530/#review68080
-----------------------------------------------------------

Ship it!


Ship It!

- Lamarque Souza
Post by Jan Grulich
-----------------------------------------------------------
https://git.reviewboard.kde.org/r/120530/
-----------------------------------------------------------
(Updated Oct. 8, 2014, 1:41 p.m.)
Review request for Network Management, Luk?? Tinkl and Lamarque Souza.
Bugs: 329837 and 339654
http://bugs.kde.org/show_bug.cgi?id=329837
http://bugs.kde.org/show_bug.cgi?id=339654
Repository: plasma-nm
Description
-------
This patch adds a simple dialog which asks a user whether he wants to copy his certificates under .kde/share/apps/networkmanagement or if he wants to keep locations from the configuration file. It also adds suffixes to copied certificates, because in some cases when user has more certificates under the same name except the suffix, then only the first one is copied to our location.
Diffs
-----
vpn/openvpn/openvpn.cpp e83d148
Diff: https://git.reviewboard.kde.org/r/120530/diff/
Testing
-------
Thanks,
Jan Grulich
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20141008/00bc03bb/attachment.html>
Jan Grulich
2014-10-08 14:00:34 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120530/
-----------------------------------------------------------

(Updated Oct. 8, 2014, 2 p.m.)


Status
------

This change has been marked as submitted.


Review request for Network Management, Luk?? Tinkl and Lamarque Souza.


Bugs: 329837 and 339654
http://bugs.kde.org/show_bug.cgi?id=329837
http://bugs.kde.org/show_bug.cgi?id=339654


Repository: plasma-nm


Description
-------

This patch adds a simple dialog which asks a user whether he wants to copy his certificates under .kde/share/apps/networkmanagement or if he wants to keep locations from the configuration file. It also adds suffixes to copied certificates, because in some cases when user has more certificates under the same name except the suffix, then only the first one is copied to our location.


Diffs
-----

vpn/openvpn/openvpn.cpp e83d148

Diff: https://git.reviewboard.kde.org/r/120530/diff/


Testing
-------


Thanks,

Jan Grulich

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20141008/9a34cd6b/attachment.html>
Loading...