Review Request 122826: Bug 339392 - krdc main window columns are not resizable

[Luca Sartorelli]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122826/
-----------------------------------------------------------

Review request for KDE Base Apps, KDE Utils and Network Management.


Bugs: 339392
http://bugs.kde.org/show_bug.cgi?id=339392


Repository: krdc


Description
-------

Bug 339392 - krdc main window columns are not resizable


Diffs
-----

mainwindow.cpp acc89ae

Diff: https://git.reviewboard.kde.org/r/122826/diff/


Testing
-------

The columns of the main grid in the main windows are resizable, and when the application starts, are sized nicely as without the patch.
On a new connect window, the column are not resize (same as before), but this time is possible to resize them, by the mouse


Thanks,

Luca Sartorelli

[Urs Wolfer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122826/#review77122
-----------------------------------------------------------


Will you commit this change into master?


mainwindow.cpp
<https://git.reviewboard.kde.org/r/122826/#comment52994>

Are you sure this line isn't needed anymore?


- Urs Wolfer

Post by Luca Sartorelli
-----------------------------------------------------------
https://git.reviewboard.kde.org/r/122826/
-----------------------------------------------------------
(Updated March 5, 2015, 4:57 p.m.)
Review request for KDE Base Apps, KDE Utils, Network Management, and Urs Wolfer.
Bugs: 339392
http://bugs.kde.org/show_bug.cgi?id=339392
Repository: krdc
Description
-------
Bug 339392 - krdc main window columns are not resizable
Diffs
-----
mainwindow.cpp acc89ae
Diff: https://git.reviewboard.kde.org/r/122826/diff/
Testing
-------
The columns of the main grid in the main windows are resizable, and when the application starts, are sized nicely as without the patch.
On a new connect window, the column are not resize (same as before), but this time is possible to resize them, by the mouse
Thanks,
Luca Sartorelli

[Luca]

Hi Urs

That line is the problem. Reading at the doc about
QHeaderView::ResizeToContents
...
The size cannot be changed by the user or programmatically.

is enought resize the column manually after the model is populated and the
sort indicator is setted up.

Ps. I canno't commit into master

bye

Post by Luca Sartorelli
https://git.reviewboard.kde.org/r/122826/
Will you commit this change into master?
mainwindow.cpp
<https://git.reviewboard.kde.org/r/122826/diff/1/?file=353016#file353016line1129> (Diff
revision 1)
QWidget* MainWindow::newConnectionWidget()
1129
m_newConnectionTableView->horizontalHeader()->setResizeMode(QHeaderView::ResizeToContents);
Are you sure this line isn't needed anymore?
- Urs Wolfer
Review request for KDE Base Apps, KDE Utils, Network Management, and Urs Wolfer.
By Luca Sartorelli.
*Updated March 5, 2015, 4:57 p.m.*
*Bugs: * 339392 <http://bugs.kde.org/show_bug.cgi?id=339392>
*Repository: * krdc
Description
Bug 339392 - krdc main window columns are not resizable
Testing
The columns of the main grid in the main windows are resizable, and when the application starts, are sized nicely as without the patch.
On a new connect window, the column are not resize (same as before), but this time is possible to resize them, by the mouse
Diffs
- mainwindow.cpp (acc89ae)
View Diff <https://git.reviewboard.kde.org/r/122826/diff/>

[Luca Sartorelli]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122826/
-----------------------------------------------------------

(Updated March 14, 2015, 11:28 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Base Apps, KDE Utils, Network Management, and Urs Wolfer.


Changes
-------

Submitted with commit 350c266e7c5b8ab3d0788aafae8e45983876e56b by Urs Wolfer to branch master.


Bugs: 339392
http://bugs.kde.org/show_bug.cgi?id=339392


Repository: krdc


Description
-------

Bug 339392 - krdc main window columns are not resizable


Diffs
-----

mainwindow.cpp acc89ae

Diff: https://git.reviewboard.kde.org/r/122826/diff/


Testing
-------

The columns of the main grid in the main windows are resizable, and when the application starts, are sized nicely as without the patch.
On a new connect window, the column are not resize (same as before), but this time is possible to resize them, by the mouse


Thanks,

Luca Sartorelli