Discussion:
Review Request 121167: Use Interactive resize mode instead of ResizeToContents
Andrey Bondrov
2014-11-18 05:28:26 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121167/
-----------------------------------------------------------

Review request for Network Management.


Repository: plasma-nm


Description
-------

We should use Interactive resize mode instead of ResizeToContents because otherwise edit fields are too small (with the size of column headers) and not possible to resize. It's not possible to see full IP address etc without this patch.


Diffs
-----

libs/editor/settings/ipv4widget.cpp 6ccd3b1
libs/editor/settings/ipv6widget.cpp 2207dd1
libs/editor/widgets/ipv4routeswidget.cpp 16a38f7
libs/editor/widgets/ipv6routeswidget.cpp 28f84e2

Diff: https://git.reviewboard.kde.org/r/121167/diff/


Testing
-------

This patch is used in ROSA for two monthes.


Thanks,

Andrey Bondrov
Jan Grulich
2014-11-18 08:55:40 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121167/#review70572
-----------------------------------------------------------

Ship it!


Ship It!

- Jan Grulich
Post by Andrey Bondrov
-----------------------------------------------------------
https://git.reviewboard.kde.org/r/121167/
-----------------------------------------------------------
(Updated Lis. 18, 2014, 5:28 dop.)
Review request for Network Management.
Repository: plasma-nm
Description
-------
We should use Interactive resize mode instead of ResizeToContents because otherwise edit fields are too small (with the size of column headers) and not possible to resize. It's not possible to see full IP address etc without this patch.
Diffs
-----
libs/editor/settings/ipv4widget.cpp 6ccd3b1
libs/editor/settings/ipv6widget.cpp 2207dd1
libs/editor/widgets/ipv4routeswidget.cpp 16a38f7
libs/editor/widgets/ipv6routeswidget.cpp 28f84e2
Diff: https://git.reviewboard.kde.org/r/121167/diff/
Testing
-------
This patch is used in ROSA for two monthes.
Thanks,
Andrey Bondrov
Andrey Bondrov
2014-11-18 11:48:43 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121167/
-----------------------------------------------------------

(Updated НПя. 18, 2014, 11:48 Ў.п.)


Status
------

This change has been marked as submitted.


Review request for Network Management.


Repository: plasma-nm


Description
-------

We should use Interactive resize mode instead of ResizeToContents because otherwise edit fields are too small (with the size of column headers) and not possible to resize. It's not possible to see full IP address etc without this patch.


Diffs
-----

libs/editor/settings/ipv4widget.cpp 6ccd3b1
libs/editor/settings/ipv6widget.cpp 2207dd1
libs/editor/widgets/ipv4routeswidget.cpp 16a38f7
libs/editor/widgets/ipv6routeswidget.cpp 28f84e2

Diff: https://git.reviewboard.kde.org/r/121167/diff/


Testing
-------

This patch is used in ROSA for two monthes.


Thanks,

Andrey Bondrov

Loading...