Review Request 130111: Fix crash when retrieving active connection list

[Lamarque Souza]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130111/
-----------------------------------------------------------

Review request for Network Management and Jan Grulich.


Bugs: 373393
http://bugs.kde.org/show_bug.cgi?id=373393


Repository: networkmanager-qt


Description
-------

We use const_interator in this code but findRegisteredActiveConnection() changes the list while we iterate over it.


Diffs
-----

src/manager.cpp 050a2dc

Diff: https://git.reviewboard.kde.org/r/130111/diff/


Testing
-------

Plasma NM still works and no crashes so far. I cannot reproduce the crash because it is intermitent.


Thanks,

Lamarque Souza

[Jan Grulich]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130111/#review103174
-----------------------------------------------------------


Ship it!




Ship It!

- Jan Grulich

Post by Lamarque Souza
-----------------------------------------------------------
https://git.reviewboard.kde.org/r/130111/
-----------------------------------------------------------
(Updated Dub. 29, 2017, 3:51 odp.)
Review request for Network Management and Jan Grulich.
Bugs: 373393
http://bugs.kde.org/show_bug.cgi?id=373393
Repository: networkmanager-qt
Description
-------
We use const_interator in this code but findRegisteredActiveConnection() changes the list while we iterate over it.
Diffs
-----
src/manager.cpp 050a2dc
Diff: https://git.reviewboard.kde.org/r/130111/diff/
Testing
-------
Plasma NM still works and no crashes so far. I cannot reproduce the crash because it is intermitent.
Thanks,
Lamarque Souza

[Lamarque Souza]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130111/
-----------------------------------------------------------

(Updated May 2, 2017, 1:01 p.m.)


Status
------

This change has been marked as submitted.


Review request for Network Management and Jan Grulich.


Changes
-------

Submitted with commit 0d5a02e562749af42265c00fc3423817476d5534 by Lamarque V. Souza to branch master.


Bugs: 373393
http://bugs.kde.org/show_bug.cgi?id=373393


Repository: networkmanager-qt


Description
-------

We use const_interator in this code but findRegisteredActiveConnection() changes the list while we iterate over it.


Diffs
-----

src/manager.cpp 050a2dc

Diff: https://git.reviewboard.kde.org/r/130111/diff/


Testing
-------

Plasma NM still works and no crashes so far. I cannot reproduce the crash because it is intermitent.


Thanks,

Lamarque Souza