Review Request 123642: Drop WiMAX support for NM 1.2.0+

[Jan Grulich]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123642/
-----------------------------------------------------------

Review request for Network Management, Lukáš Tinkl and Lamarque Souza.


Repository: networkmanager-qt


Description
-------

NM developers decided to drop WiMAX support in the upcoming NM version and we should update nm-qt accordingly. Only WimaxDevice, WimaxNsp and WimaxFoo properties should be dropped, WimaxSetting should be still available, because it will be still possible to create/edit Wimax connections, but no Wimax devices will created.

See http://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=721e917cb6c3f6bea7e856aaed0cd49626887db1


Diffs
-----

src/manager_p.h b98352f
src/manager.h b59649d
src/manager.cpp fdc8a91
src/fakenetwork/fakenetwork.cpp c7a29fd
src/fakenetwork/fakenetwork.h 64077a9
autotests/managertest.cpp 6cc2429
src/CMakeLists.txt e2be7d8

Diff: https://git.reviewboard.kde.org/r/123642/diff/


Testing
-------


Thanks,

Jan Grulich

[Lamarque Souza]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123642/#review79926
-----------------------------------------------------------

Ship it!


Ship It!

- Lamarque Souza

Post by Jan Grulich
-----------------------------------------------------------
https://git.reviewboard.kde.org/r/123642/
-----------------------------------------------------------
(Updated May 5, 2015, 1:58 p.m.)
Review request for Network Management, Lukáš Tinkl and Lamarque Souza.
Repository: networkmanager-qt
Description
-------
NM developers decided to drop WiMAX support in the upcoming NM version and we should update nm-qt accordingly. Only WimaxDevice, WimaxNsp and WimaxFoo properties should be dropped, WimaxSetting should be still available, because it will be still possible to create/edit Wimax connections, but no Wimax devices will created.
See http://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=721e917cb6c3f6bea7e856aaed0cd49626887db1
Diffs
-----
src/manager_p.h b98352f
src/manager.h b59649d
src/manager.cpp fdc8a91
src/fakenetwork/fakenetwork.cpp c7a29fd
src/fakenetwork/fakenetwork.h 64077a9
autotests/managertest.cpp 6cc2429
src/CMakeLists.txt e2be7d8
Diff: https://git.reviewboard.kde.org/r/123642/diff/
Testing
-------
Thanks,
Jan Grulich

[Jan Grulich]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123642/
-----------------------------------------------------------

(Updated May 6, 2015, 7:14 a.m.)


Status
------

This change has been marked as submitted.


Review request for Network Management, Lukáš Tinkl and Lamarque Souza.


Changes
-------

Submitted with commit 1611028164fed9f2ec5915e042b0b6e18a8a0892 by Jan Grulich to branch master.


Repository: networkmanager-qt


Description
-------

NM developers decided to drop WiMAX support in the upcoming NM version and we should update nm-qt accordingly. Only WimaxDevice, WimaxNsp and WimaxFoo properties should be dropped, WimaxSetting should be still available, because it will be still possible to create/edit Wimax connections, but no Wimax devices will created.

See http://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=721e917cb6c3f6bea7e856aaed0cd49626887db1


Diffs
-----

src/manager_p.h b98352f
src/manager.h b59649d
src/manager.cpp fdc8a91
src/fakenetwork/fakenetwork.cpp c7a29fd
src/fakenetwork/fakenetwork.h 64077a9
autotests/managertest.cpp 6cc2429
src/CMakeLists.txt e2be7d8

Diff: https://git.reviewboard.kde.org/r/123642/diff/


Testing
-------


Thanks,

Jan Grulich