Discussion:
Review Request 129630: Don't force logging with setFilterRules
David Rosca
2016-12-09 15:11:04 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129630/
-----------------------------------------------------------

Review request for Network Management and Jan Grulich.


Repository: networkmanager-qt


Description
-------

Don't set the logging rules from inside the library, so the user configuration (qtlogging.ini) is respected.


Diffs
-----

src/manager.cpp 6565299

Diff: https://git.reviewboard.kde.org/r/129630/diff/


Testing
-------


Thanks,

David Rosca
Jan Grulich
2016-12-12 06:03:18 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129630/#review101372
-----------------------------------------------------------


Ship it!




Ship It!

- Jan Grulich
Post by David Rosca
-----------------------------------------------------------
https://git.reviewboard.kde.org/r/129630/
-----------------------------------------------------------
(Updated Pro. 9, 2016, 3:11 odp.)
Review request for Network Management and Jan Grulich.
Repository: networkmanager-qt
Description
-------
Don't set the logging rules from inside the library, so the user configuration (qtlogging.ini) is respected.
Diffs
-----
src/manager.cpp 6565299
Diff: https://git.reviewboard.kde.org/r/129630/diff/
Testing
-------
Thanks,
David Rosca
David Rosca
2016-12-12 09:17:16 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129630/
-----------------------------------------------------------

(Updated Dec. 12, 2016, 9:17 a.m.)


Status
------

This change has been marked as submitted.


Review request for Network Management and Jan Grulich.


Changes
-------

Submitted with commit 87273f5296bd52e85f78fc7273932460b222e7be by David Rosca to branch master.


Repository: networkmanager-qt


Description
-------

Don't set the logging rules from inside the library, so the user configuration (qtlogging.ini) is respected.


Diffs
-----

src/manager.cpp 6565299

Diff: https://git.reviewboard.kde.org/r/129630/diff/


Testing
-------


Thanks,

David Rosca

Loading...