Discussion:
Review Request 129105: Add support for Juniper Openconnect VPN
Jan Grulich
2016-10-05 10:39:20 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129105/
-----------------------------------------------------------

Review request for Network Management, David Woodhouse and Lamarque Souza.


Bugs: 363917
http://bugs.kde.org/show_bug.cgi?id=363917


Repository: plasma-nm


Description
-------

This patch adds support for Juniper. It's added as a separate item in the menu by just adding one more desktop file for openconnect, while specifying subtype (anyconnect or juniper). Based on the subtype I set "protocol" property when creating a new openconnect connection.


Diffs
-----

editor/connectioneditor.cpp 6e07971
vpn/openconnect/CMakeLists.txt cb3fb18
vpn/openconnect/nm-openconnect-service.h 4b45f20
vpn/openconnect/openconnectwidget.cpp d94a9c7
vpn/openconnect/plasmanetworkmanagement_openconnect_juniperui.desktop PRE-CREATION
vpn/openconnect/plasmanetworkmanagement_openconnectui.desktop 6327344

Diff: https://git.reviewboard.kde.org/r/129105/diff/


Testing
-------


Thanks,

Jan Grulich
Lamarque Souza
2016-10-05 12:54:44 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129105/#review99795
-----------------------------------------------------------




vpn/openconnect/openconnectwidget.cpp (line 112)
<https://git.reviewboard.kde.org/r/129105/#comment67075>

Remove leading space.


- Lamarque Souza
Post by Jan Grulich
-----------------------------------------------------------
https://git.reviewboard.kde.org/r/129105/
-----------------------------------------------------------
(Updated Oct. 5, 2016, 10:39 a.m.)
Review request for Network Management, David Woodhouse and Lamarque Souza.
Bugs: 363917
http://bugs.kde.org/show_bug.cgi?id=363917
Repository: plasma-nm
Description
-------
This patch adds support for Juniper. It's added as a separate item in the menu by just adding one more desktop file for openconnect, while specifying subtype (anyconnect or juniper). Based on the subtype I set "protocol" property when creating a new openconnect connection.
Diffs
-----
editor/connectioneditor.cpp 6e07971
vpn/openconnect/CMakeLists.txt cb3fb18
vpn/openconnect/nm-openconnect-service.h 4b45f20
vpn/openconnect/openconnectwidget.cpp d94a9c7
vpn/openconnect/plasmanetworkmanagement_openconnect_juniperui.desktop PRE-CREATION
vpn/openconnect/plasmanetworkmanagement_openconnectui.desktop 6327344
Diff: https://git.reviewboard.kde.org/r/129105/diff/
Testing
-------
Thanks,
Jan Grulich
Lamarque Souza
2016-10-05 12:54:49 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129105/#review99796
-----------------------------------------------------------


Ship it!




Ship It!

- Lamarque Souza
Post by Jan Grulich
-----------------------------------------------------------
https://git.reviewboard.kde.org/r/129105/
-----------------------------------------------------------
(Updated Oct. 5, 2016, 10:39 a.m.)
Review request for Network Management, David Woodhouse and Lamarque Souza.
Bugs: 363917
http://bugs.kde.org/show_bug.cgi?id=363917
Repository: plasma-nm
Description
-------
This patch adds support for Juniper. It's added as a separate item in the menu by just adding one more desktop file for openconnect, while specifying subtype (anyconnect or juniper). Based on the subtype I set "protocol" property when creating a new openconnect connection.
Diffs
-----
editor/connectioneditor.cpp 6e07971
vpn/openconnect/CMakeLists.txt cb3fb18
vpn/openconnect/nm-openconnect-service.h 4b45f20
vpn/openconnect/openconnectwidget.cpp d94a9c7
vpn/openconnect/plasmanetworkmanagement_openconnect_juniperui.desktop PRE-CREATION
vpn/openconnect/plasmanetworkmanagement_openconnectui.desktop 6327344
Diff: https://git.reviewboard.kde.org/r/129105/diff/
Testing
-------
Thanks,
Jan Grulich
Jan Grulich
2016-10-05 19:14:59 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129105/
-----------------------------------------------------------

(Updated Oct. 5, 2016, 7:14 p.m.)


Status
------

This change has been marked as submitted.


Review request for Network Management, David Woodhouse and Lamarque Souza.


Changes
-------

Submitted with commit 05a80ff9311c0880bb08fe7a00dcda3d1f34e864 by Jan Grulich to branch master.


Bugs: 363917
http://bugs.kde.org/show_bug.cgi?id=363917


Repository: plasma-nm


Description
-------

This patch adds support for Juniper. It's added as a separate item in the menu by just adding one more desktop file for openconnect, while specifying subtype (anyconnect or juniper). Based on the subtype I set "protocol" property when creating a new openconnect connection.


Diffs
-----

editor/connectioneditor.cpp 6e07971
vpn/openconnect/CMakeLists.txt cb3fb18
vpn/openconnect/nm-openconnect-service.h 4b45f20
vpn/openconnect/openconnectwidget.cpp d94a9c7
vpn/openconnect/plasmanetworkmanagement_openconnect_juniperui.desktop PRE-CREATION
vpn/openconnect/plasmanetworkmanagement_openconnectui.desktop 6327344

Diff: https://git.reviewboard.kde.org/r/129105/diff/


Testing
-------


Thanks,

Jan Grulich

Loading...