Jan Grulich
2016-10-05 10:39:20 UTC
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129105/
-----------------------------------------------------------
Review request for Network Management, David Woodhouse and Lamarque Souza.
Bugs: 363917
http://bugs.kde.org/show_bug.cgi?id=363917
Repository: plasma-nm
Description
-------
This patch adds support for Juniper. It's added as a separate item in the menu by just adding one more desktop file for openconnect, while specifying subtype (anyconnect or juniper). Based on the subtype I set "protocol" property when creating a new openconnect connection.
Diffs
-----
editor/connectioneditor.cpp 6e07971
vpn/openconnect/CMakeLists.txt cb3fb18
vpn/openconnect/nm-openconnect-service.h 4b45f20
vpn/openconnect/openconnectwidget.cpp d94a9c7
vpn/openconnect/plasmanetworkmanagement_openconnect_juniperui.desktop PRE-CREATION
vpn/openconnect/plasmanetworkmanagement_openconnectui.desktop 6327344
Diff: https://git.reviewboard.kde.org/r/129105/diff/
Testing
-------
Thanks,
Jan Grulich
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129105/
-----------------------------------------------------------
Review request for Network Management, David Woodhouse and Lamarque Souza.
Bugs: 363917
http://bugs.kde.org/show_bug.cgi?id=363917
Repository: plasma-nm
Description
-------
This patch adds support for Juniper. It's added as a separate item in the menu by just adding one more desktop file for openconnect, while specifying subtype (anyconnect or juniper). Based on the subtype I set "protocol" property when creating a new openconnect connection.
Diffs
-----
editor/connectioneditor.cpp 6e07971
vpn/openconnect/CMakeLists.txt cb3fb18
vpn/openconnect/nm-openconnect-service.h 4b45f20
vpn/openconnect/openconnectwidget.cpp d94a9c7
vpn/openconnect/plasmanetworkmanagement_openconnect_juniperui.desktop PRE-CREATION
vpn/openconnect/plasmanetworkmanagement_openconnectui.desktop 6327344
Diff: https://git.reviewboard.kde.org/r/129105/diff/
Testing
-------
Thanks,
Jan Grulich