Discussion:
Review Request 128331: [Plasma-nm] Provide better notification icons
Kai Uwe Broulik
2016-06-30 20:17:51 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128331/
-----------------------------------------------------------

Review request for Network Management, Plasma and KDE Usability.


Repository: plasma-nm


Description
-------

This improves the most common case by showing dedicated icons for when connecting/disconnecting wireless and wired connections instead of showing the generic warning/information icon.

Also change from notification pixmap to iconName.


Diffs
-----

kded/notification.cpp e3d19ad

Diff: https://git.reviewboard.kde.org/r/128331/diff/


Testing
-------

Connected and disconnected my wifi


File Attachments
----------------

Connected
Loading Image...
Disconnected
Loading Image...


Thanks,

Kai Uwe Broulik
Jan Grulich
2016-07-01 06:32:50 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128331/#review96982
-----------------------------------------------------------


Ship it!




Looks good. Thanks

- Jan Grulich
Post by Kai Uwe Broulik
-----------------------------------------------------------
https://git.reviewboard.kde.org/r/128331/
-----------------------------------------------------------
(Updated Čer. 30, 2016, 8:17 odp.)
Review request for Network Management, Plasma and KDE Usability.
Repository: plasma-nm
Description
-------
This improves the most common case by showing dedicated icons for when connecting/disconnecting wireless and wired connections instead of showing the generic warning/information icon.
Also change from notification pixmap to iconName.
Diffs
-----
kded/notification.cpp e3d19ad
Diff: https://git.reviewboard.kde.org/r/128331/diff/
Testing
-------
Connected and disconnected my wifi
File Attachments
----------------
Connected
https://git.reviewboard.kde.org/media/uploaded/files/2016/06/30/b800147b-0e0e-4cad-87c2-6045fbe6ab65__Screenshot_20160630_221435.png
Disconnected
https://git.reviewboard.kde.org/media/uploaded/files/2016/06/30/0cb34ebd-9d92-45d0-9c15-e439b1270287__Screenshot_20160630_221424.png
Thanks,
Kai Uwe Broulik
Kai Uwe Broulik
2016-08-01 15:47:30 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128331/
-----------------------------------------------------------

(Updated Aug. 1, 2016, 5:47 p.m.)


Status
------

This change has been marked as submitted.


Review request for Network Management, Plasma and KDE Usability.


Changes
-------

Submitted with commit 478b4b646ab5806f550e3973193fb94d19d25616 by Kai Uwe Broulik to branch master.


Repository: plasma-nm


Description
-------

This improves the most common case by showing dedicated icons for when connecting/disconnecting wireless and wired connections instead of showing the generic warning/information icon.

Also change from notification pixmap to iconName.


Diffs
-----

kded/notification.cpp e3d19ad

Diff: https://git.reviewboard.kde.org/r/128331/diff/


Testing
-------

Connected and disconnected my wifi


File Attachments
----------------

Connected
https://git.reviewboard.kde.org/media/uploaded/files/2016/06/30/b800147b-0e0e-4cad-87c2-6045fbe6ab65__Screenshot_20160630_221435.png
Disconnected
https://git.reviewboard.kde.org/media/uploaded/files/2016/06/30/0cb34ebd-9d92-45d0-9c15-e439b1270287__Screenshot_20160630_221424.png


Thanks,

Kai Uwe Broulik

Loading...