Review Request 125540: Use more descriptive names and comments for VPN plugins

[Jan Grulich]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125540/
-----------------------------------------------------------

Review request for Network Management and Lamarque Souza.


Repository: plasma-nm


Description
-------

Currently we have for each VPN plugin just its simple name and as a comment we have just "xxxx plugin" which is kinda useless so I took more descriptive names and comments from NetworkManager. Better comments can be used in future also for tooltips, but so far from what I tried it doesn't seem to work for QActions.


Diffs
-----

vpn/l2tp/plasmanetworkmanagement_l2tpui.desktop fd5ee6f
vpn/openconnect/plasmanetworkmanagement_openconnectui.desktop e5440df
vpn/openswan/plasmanetworkmanagement_openswanui.desktop 64e73cc
vpn/openvpn/plasmanetworkmanagement_openvpnui.desktop 36a3ef9
vpn/pptp/plasmanetworkmanagement_pptpui.desktop e02d46c
vpn/ssh/plasmanetworkmanagement_sshui.desktop f775a46
vpn/sstp/plasmanetworkmanagement_sstpui.desktop 267d166
vpn/strongswan/plasmanetworkmanagement_strongswanui.desktop a327c23
vpn/vpnc/plasmanetworkmanagement_vpncui.desktop 41f4e77

Diff: https://git.reviewboard.kde.org/r/125540/diff/


Testing
-------


Thanks,

Jan Grulich

[Lamarque Souza]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125540/#review86418
-----------------------------------------------------------


I am ok with this change. I think someone from the translation team should take a look at this review too.

- Lamarque Souza

Post by Jan Grulich
-----------------------------------------------------------
https://git.reviewboard.kde.org/r/125540/
-----------------------------------------------------------
(Updated Oct. 6, 2015, 7:33 a.m.)
Review request for Network Management and Lamarque Souza.
Repository: plasma-nm
Description
-------
Currently we have for each VPN plugin just its simple name and as a comment we have just "xxxx plugin" which is kinda useless so I took more descriptive names and comments from NetworkManager. Better comments can be used in future also for tooltips, but so far from what I tried it doesn't seem to work for QActions.
Diffs
-----
vpn/l2tp/plasmanetworkmanagement_l2tpui.desktop fd5ee6f
vpn/openconnect/plasmanetworkmanagement_openconnectui.desktop e5440df
vpn/openswan/plasmanetworkmanagement_openswanui.desktop 64e73cc
vpn/openvpn/plasmanetworkmanagement_openvpnui.desktop 36a3ef9
vpn/pptp/plasmanetworkmanagement_pptpui.desktop e02d46c
vpn/ssh/plasmanetworkmanagement_sshui.desktop f775a46
vpn/sstp/plasmanetworkmanagement_sstpui.desktop 267d166
vpn/strongswan/plasmanetworkmanagement_strongswanui.desktop a327c23
vpn/vpnc/plasmanetworkmanagement_vpncui.desktop 41f4e77
Diff: https://git.reviewboard.kde.org/r/125540/diff/
Testing
-------
Thanks,
Jan Grulich

[Luigi Toscano]

Post by Jan Grulich

Post by Lamarque Souza
I am ok with this change. I think someone from the translation team should take a look at this review too.

Generic hint: please add the l10n group for such cases :)
What do you think could be problematic in this review? From the procedural point of view, master is open, so string can be changed.
From the i18n point of view, the only question is whether the longer strings can impact the UI, but according Jan it's not the case.


- Luigi


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125540/#review86418
-----------------------------------------------------------

Post by Jan Grulich
-----------------------------------------------------------
https://git.reviewboard.kde.org/r/125540/
-----------------------------------------------------------
(Updated Oct. 6, 2015, 2:38 p.m.)
Review request for Localization and Translation (l10n), Network Management and Lamarque Souza.
Repository: plasma-nm
Description
-------
Currently we have for each VPN plugin just its simple name and as a comment we have just "xxxx plugin" which is kinda useless so I took more descriptive names and comments from NetworkManager. Better comments can be used in future also for tooltips, but so far from what I tried it doesn't seem to work for QActions.
Diffs
-----
vpn/l2tp/plasmanetworkmanagement_l2tpui.desktop fd5ee6f
vpn/openconnect/plasmanetworkmanagement_openconnectui.desktop e5440df
vpn/openswan/plasmanetworkmanagement_openswanui.desktop 64e73cc
vpn/openvpn/plasmanetworkmanagement_openvpnui.desktop 36a3ef9
vpn/pptp/plasmanetworkmanagement_pptpui.desktop e02d46c
vpn/ssh/plasmanetworkmanagement_sshui.desktop f775a46
vpn/sstp/plasmanetworkmanagement_sstpui.desktop 267d166
vpn/strongswan/plasmanetworkmanagement_strongswanui.desktop a327c23
vpn/vpnc/plasmanetworkmanagement_vpncui.desktop 41f4e77
Diff: https://git.reviewboard.kde.org/r/125540/diff/
Testing
-------
Thanks,
Jan Grulich

[Lamarque Souza]

Post by Luigi Toscano

Post by Lamarque Souza
I am ok with this change. I think someone from the translation team should take a look at this review too.

Generic hint: please add the l10n group for such cases :)
What do you think could be problematic in this review? From the procedural point of view, master is open, so string can be changed.
From the i18n point of view, the only question is whether the longer strings can impact the UI, but according Jan it's not the case.

Good. I did not see any problem in the review. Just wanted to make sure it is ok from the translation point of view.


- Lamarque


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125540/#review86418
-----------------------------------------------------------

Post by Luigi Toscano
-----------------------------------------------------------
https://git.reviewboard.kde.org/r/125540/
-----------------------------------------------------------
(Updated Oct. 6, 2015, 12:38 p.m.)
Review request for Localization and Translation (l10n), Network Management and Lamarque Souza.
Repository: plasma-nm
Description
-------
Currently we have for each VPN plugin just its simple name and as a comment we have just "xxxx plugin" which is kinda useless so I took more descriptive names and comments from NetworkManager. Better comments can be used in future also for tooltips, but so far from what I tried it doesn't seem to work for QActions.
Diffs
-----
vpn/l2tp/plasmanetworkmanagement_l2tpui.desktop fd5ee6f
vpn/openconnect/plasmanetworkmanagement_openconnectui.desktop e5440df
vpn/openswan/plasmanetworkmanagement_openswanui.desktop 64e73cc
vpn/openvpn/plasmanetworkmanagement_openvpnui.desktop 36a3ef9
vpn/pptp/plasmanetworkmanagement_pptpui.desktop e02d46c
vpn/ssh/plasmanetworkmanagement_sshui.desktop f775a46
vpn/sstp/plasmanetworkmanagement_sstpui.desktop 267d166
vpn/strongswan/plasmanetworkmanagement_strongswanui.desktop a327c23
vpn/vpnc/plasmanetworkmanagement_vpncui.desktop 41f4e77
Diff: https://git.reviewboard.kde.org/r/125540/diff/
Testing
-------
Thanks,
Jan Grulich

[Lamarque Souza]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125540/#review86434
-----------------------------------------------------------

Ship it!


Ship It!

- Lamarque Souza

Post by Jan Grulich
-----------------------------------------------------------
https://git.reviewboard.kde.org/r/125540/
-----------------------------------------------------------
(Updated Oct. 6, 2015, 12:38 p.m.)
Review request for Localization and Translation (l10n), Network Management and Lamarque Souza.
Repository: plasma-nm
Description
-------
Currently we have for each VPN plugin just its simple name and as a comment we have just "xxxx plugin" which is kinda useless so I took more descriptive names and comments from NetworkManager. Better comments can be used in future also for tooltips, but so far from what I tried it doesn't seem to work for QActions.
Diffs
-----
vpn/l2tp/plasmanetworkmanagement_l2tpui.desktop fd5ee6f
vpn/openconnect/plasmanetworkmanagement_openconnectui.desktop e5440df
vpn/openswan/plasmanetworkmanagement_openswanui.desktop 64e73cc
vpn/openvpn/plasmanetworkmanagement_openvpnui.desktop 36a3ef9
vpn/pptp/plasmanetworkmanagement_pptpui.desktop e02d46c
vpn/ssh/plasmanetworkmanagement_sshui.desktop f775a46
vpn/sstp/plasmanetworkmanagement_sstpui.desktop 267d166
vpn/strongswan/plasmanetworkmanagement_strongswanui.desktop a327c23
vpn/vpnc/plasmanetworkmanagement_vpncui.desktop 41f4e77
Diff: https://git.reviewboard.kde.org/r/125540/diff/
Testing
-------
Thanks,
Jan Grulich

[Jan Grulich]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125540/
-----------------------------------------------------------

(Updated Oct. 6, 2015, 4:08 p.m.)


Status
------

This change has been marked as submitted.


Review request for Localization and Translation (l10n), Network Management and Lamarque Souza.


Changes
-------

Submitted with commit 41a1e711d0299f261b9c770e6788d76a4aaeba28 by Jan Grulich to branch master.


Repository: plasma-nm


Description
-------

Currently we have for each VPN plugin just its simple name and as a comment we have just "xxxx plugin" which is kinda useless so I took more descriptive names and comments from NetworkManager. Better comments can be used in future also for tooltips, but so far from what I tried it doesn't seem to work for QActions.


Diffs
-----

vpn/l2tp/plasmanetworkmanagement_l2tpui.desktop fd5ee6f
vpn/openconnect/plasmanetworkmanagement_openconnectui.desktop e5440df
vpn/openswan/plasmanetworkmanagement_openswanui.desktop 64e73cc
vpn/openvpn/plasmanetworkmanagement_openvpnui.desktop 36a3ef9
vpn/pptp/plasmanetworkmanagement_pptpui.desktop e02d46c
vpn/ssh/plasmanetworkmanagement_sshui.desktop f775a46
vpn/sstp/plasmanetworkmanagement_sstpui.desktop 267d166
vpn/strongswan/plasmanetworkmanagement_strongswanui.desktop a327c23
vpn/vpnc/plasmanetworkmanagement_vpncui.desktop 41f4e77

Diff: https://git.reviewboard.kde.org/r/125540/diff/


Testing
-------


Thanks,

Jan Grulich