Review Request 124314: Workaround for notifications stealing focus of the connect/disconnect button

[Jan Grulich]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124314/
-----------------------------------------------------------

(Updated Čec. 14, 2015, 7:43 dop.)


Review request for Network Management and Plasma.


Changes
-------

Added networkmanagement group to get more attention.


Bugs: 348905
http://bugs.kde.org/show_bug.cgi?id=348905


Repository: plasma-nm


Description
-------

Previously the button was shown when item contained mouse cursor, but when a notification appeared and you clicked on the button the "containsMouse" property was changed to false and click on the button didn't have any effect. Now I store which item has the connect/disconnect button visible and this is not changed until you move mouse cursor to another item, thus when a notification appears and you click on the button it works and the button remains visible.


Diffs
-----

applet/contents/ui/ConnectionItem.qml 3fa93b5
applet/contents/ui/PopupDialog.qml 2a0d352

Diff: https://git.reviewboard.kde.org/r/124314/diff/


Testing
-------


Thanks,

Jan Grulich

[Kai Uwe Broulik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124314/#review82483
-----------------------------------------------------------


+1


applet/contents/ui/ConnectionItem.qml (line 423)
<https://git.reviewboard.kde.org/r/124314/#comment56885>

} else {
connectionView.currentIndexVisibleButton = -1
}

Maybe? So the button doesn't stay there indefinitely


- Kai Uwe Broulik

Post by Jan Grulich
-----------------------------------------------------------
https://git.reviewboard.kde.org/r/124314/
-----------------------------------------------------------
(Updated Juli 14, 2015, 7:43 vorm.)
Review request for Network Management and Plasma.
Bugs: 348905
http://bugs.kde.org/show_bug.cgi?id=348905
Repository: plasma-nm
Description
-------
Previously the button was shown when item contained mouse cursor, but when a notification appeared and you clicked on the button the "containsMouse" property was changed to false and click on the button didn't have any effect. Now I store which item has the connect/disconnect button visible and this is not changed until you move mouse cursor to another item, thus when a notification appears and you click on the button it works and the button remains visible.
Diffs
-----
applet/contents/ui/ConnectionItem.qml 3fa93b5
applet/contents/ui/PopupDialog.qml 2a0d352
Diff: https://git.reviewboard.kde.org/r/124314/diff/
Testing
-------
Thanks,
Jan Grulich

[Lamarque Souza]

Post by Jan Grulich

applet/contents/ui/ConnectionItem.qml, line 423
<https://git.reviewboard.kde.org/r/124314/diff/1/?file=383992#file383992line423>
} else {
connectionView.currentIndexVisibleButton = -1
}
Maybe? So the button doesn't stay there indefinitely

+1 from me for this change


- Lamarque


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124314/#review82483
-----------------------------------------------------------

Post by Jan Grulich
-----------------------------------------------------------
https://git.reviewboard.kde.org/r/124314/
-----------------------------------------------------------
(Updated July 14, 2015, 7:43 a.m.)
Review request for Network Management and Plasma.
Bugs: 348905
http://bugs.kde.org/show_bug.cgi?id=348905
Repository: plasma-nm
Description
-------
Previously the button was shown when item contained mouse cursor, but when a notification appeared and you clicked on the button the "containsMouse" property was changed to false and click on the button didn't have any effect. Now I store which item has the connect/disconnect button visible and this is not changed until you move mouse cursor to another item, thus when a notification appears and you click on the button it works and the button remains visible.
Diffs
-----
applet/contents/ui/ConnectionItem.qml 3fa93b5
applet/contents/ui/PopupDialog.qml 2a0d352
Diff: https://git.reviewboard.kde.org/r/124314/diff/
Testing
-------
Thanks,
Jan Grulich

[Kai Uwe Broulik]

Post by Lamarque Souza

applet/contents/ui/ConnectionItem.qml, line 423
<https://git.reviewboard.kde.org/r/124314/diff/1/?file=383992#file383992line423>
} else {
connectionView.currentIndexVisibleButton = -1
}
Maybe? So the button doesn't stay there indefinitely

+1 from me for this change

Thinking about it, that probably exposes the same problem, because otherwise we could just use containsMouse.


- Kai Uwe


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124314/#review82483
-----------------------------------------------------------

Post by Lamarque Souza
-----------------------------------------------------------
https://git.reviewboard.kde.org/r/124314/
-----------------------------------------------------------
(Updated Juli 14, 2015, 7:43 vorm.)
Review request for Network Management and Plasma.
Bugs: 348905
http://bugs.kde.org/show_bug.cgi?id=348905
Repository: plasma-nm
Description
-------
Previously the button was shown when item contained mouse cursor, but when a notification appeared and you clicked on the button the "containsMouse" property was changed to false and click on the button didn't have any effect. Now I store which item has the connect/disconnect button visible and this is not changed until you move mouse cursor to another item, thus when a notification appears and you click on the button it works and the button remains visible.
Diffs
-----
applet/contents/ui/ConnectionItem.qml 3fa93b5
applet/contents/ui/PopupDialog.qml 2a0d352
Diff: https://git.reviewboard.kde.org/r/124314/diff/
Testing
-------
Thanks,
Jan Grulich

[Jan Grulich]

Post by Lamarque Souza

applet/contents/ui/ConnectionItem.qml, line 423
<https://git.reviewboard.kde.org/r/124314/diff/1/?file=383992#file383992line423>
} else {
connectionView.currentIndexVisibleButton = -1
}
Maybe? So the button doesn't stay there indefinitely

+1 from me for this change
Thinking about it, that probably exposes the same problem, because otherwise we could just use containsMouse.

Yep, that would behave same as I would use just containsMouse.


- Jan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124314/#review82483
-----------------------------------------------------------

Post by Lamarque Souza
-----------------------------------------------------------
https://git.reviewboard.kde.org/r/124314/
-----------------------------------------------------------
(Updated Čec. 14, 2015, 7:43 dop.)
Review request for Network Management and Plasma.
Bugs: 348905
http://bugs.kde.org/show_bug.cgi?id=348905
Repository: plasma-nm
Description
-------
Previously the button was shown when item contained mouse cursor, but when a notification appeared and you clicked on the button the "containsMouse" property was changed to false and click on the button didn't have any effect. Now I store which item has the connect/disconnect button visible and this is not changed until you move mouse cursor to another item, thus when a notification appears and you click on the button it works and the button remains visible.
Diffs
-----
applet/contents/ui/ConnectionItem.qml 3fa93b5
applet/contents/ui/PopupDialog.qml 2a0d352
Diff: https://git.reviewboard.kde.org/r/124314/diff/
Testing
-------
Thanks,
Jan Grulich

[Lamarque Souza]

Post by Lamarque Souza

applet/contents/ui/ConnectionItem.qml, line 423
<https://git.reviewboard.kde.org/r/124314/diff/1/?file=383992#file383992line423>
} else {
connectionView.currentIndexVisibleButton = -1
}
Maybe? So the button doesn't stay there indefinitely

+1 from me for this change
Thinking about it, that probably exposes the same problem, because otherwise we could just use containsMouse.
Yep, that would behave same as I would use just containsMouse.

Yeah, I thought of that after I public the review. But then how can we hide the button? Maybe when the plasmoid's popup closes?


- Lamarque


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124314/#review82483
-----------------------------------------------------------

Post by Lamarque Souza
-----------------------------------------------------------
https://git.reviewboard.kde.org/r/124314/
-----------------------------------------------------------
(Updated July 14, 2015, 7:43 a.m.)
Review request for Network Management and Plasma.
Bugs: 348905
http://bugs.kde.org/show_bug.cgi?id=348905
Repository: plasma-nm
Description
-------
Previously the button was shown when item contained mouse cursor, but when a notification appeared and you clicked on the button the "containsMouse" property was changed to false and click on the button didn't have any effect. Now I store which item has the connect/disconnect button visible and this is not changed until you move mouse cursor to another item, thus when a notification appears and you click on the button it works and the button remains visible.
Diffs
-----
applet/contents/ui/ConnectionItem.qml 3fa93b5
applet/contents/ui/PopupDialog.qml 2a0d352
Diff: https://git.reviewboard.kde.org/r/124314/diff/
Testing
-------
Thanks,
Jan Grulich

[Lamarque Souza]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124314/#review82494
-----------------------------------------------------------



applet/contents/ui/PopupDialog.qml (line 68)
<https://git.reviewboard.kde.org/r/124314/#comment56900>

The correct English for this is currentVisibleButtonIndex.


- Lamarque Souza

Post by Jan Grulich
-----------------------------------------------------------
https://git.reviewboard.kde.org/r/124314/
-----------------------------------------------------------
(Updated July 14, 2015, 7:43 a.m.)
Review request for Network Management and Plasma.
Bugs: 348905
http://bugs.kde.org/show_bug.cgi?id=348905
Repository: plasma-nm
Description
-------
Previously the button was shown when item contained mouse cursor, but when a notification appeared and you clicked on the button the "containsMouse" property was changed to false and click on the button didn't have any effect. Now I store which item has the connect/disconnect button visible and this is not changed until you move mouse cursor to another item, thus when a notification appears and you click on the button it works and the button remains visible.
Diffs
-----
applet/contents/ui/ConnectionItem.qml 3fa93b5
applet/contents/ui/PopupDialog.qml 2a0d352
Diff: https://git.reviewboard.kde.org/r/124314/diff/
Testing
-------
Thanks,
Jan Grulich

[Jan Grulich]

Post by Jan Grulich

applet/contents/ui/PopupDialog.qml, line 68
<https://git.reviewboard.kde.org/r/124314/diff/1/?file=383993#file383993line68>
The correct English for this is currentVisibleButtonIndex.

The meaning of this is "current index of visible button".


- Jan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124314/#review82494
-----------------------------------------------------------

Post by Jan Grulich
-----------------------------------------------------------
https://git.reviewboard.kde.org/r/124314/
-----------------------------------------------------------
(Updated Čec. 14, 2015, 7:43 dop.)
Review request for Network Management and Plasma.
Bugs: 348905
http://bugs.kde.org/show_bug.cgi?id=348905
Repository: plasma-nm
Description
-------
Previously the button was shown when item contained mouse cursor, but when a notification appeared and you clicked on the button the "containsMouse" property was changed to false and click on the button didn't have any effect. Now I store which item has the connect/disconnect button visible and this is not changed until you move mouse cursor to another item, thus when a notification appears and you click on the button it works and the button remains visible.
Diffs
-----
applet/contents/ui/ConnectionItem.qml 3fa93b5
applet/contents/ui/PopupDialog.qml 2a0d352
Diff: https://git.reviewboard.kde.org/r/124314/diff/
Testing
-------
Thanks,
Jan Grulich

[Lamarque Souza]

Post by Jan Grulich

applet/contents/ui/PopupDialog.qml, line 68
<https://git.reviewboard.kde.org/r/124314/diff/1/?file=383993#file383993line68>
The correct English for this is currentVisibleButtonIndex.

The meaning of this is "current index of visible button".

I thought "current" related to "visible button", like in "current visible button's index" (therefore currentVisibleButtonIndex). That is the same as "index of current visible button". "Current index of visible button" sounds like the visible button can stay the same but its index can change, which is not what happens (there are several buttons, but just one "currently" visible).


- Lamarque


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124314/#review82494
-----------------------------------------------------------

Post by Jan Grulich
-----------------------------------------------------------
https://git.reviewboard.kde.org/r/124314/
-----------------------------------------------------------
(Updated July 14, 2015, 7:43 a.m.)
Review request for Network Management and Plasma.
Bugs: 348905
http://bugs.kde.org/show_bug.cgi?id=348905
Repository: plasma-nm
Description
-------
Previously the button was shown when item contained mouse cursor, but when a notification appeared and you clicked on the button the "containsMouse" property was changed to false and click on the button didn't have any effect. Now I store which item has the connect/disconnect button visible and this is not changed until you move mouse cursor to another item, thus when a notification appears and you click on the button it works and the button remains visible.
Diffs
-----
applet/contents/ui/ConnectionItem.qml 3fa93b5
applet/contents/ui/PopupDialog.qml 2a0d352
Diff: https://git.reviewboard.kde.org/r/124314/diff/
Testing
-------
Thanks,
Jan Grulich

[Jan Grulich]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124314/
-----------------------------------------------------------

(Updated Čec. 23, 2015, 3:12 odp.)


Review request for Network Management and Plasma.


Changes
-------

Property was renamed as Lamarque suggested and the button dissappears after the applet is closed.


Bugs: 348905
http://bugs.kde.org/show_bug.cgi?id=348905


Repository: plasma-nm


Description
-------

Previously the button was shown when item contained mouse cursor, but when a notification appeared and you clicked on the button the "containsMouse" property was changed to false and click on the button didn't have any effect. Now I store which item has the connect/disconnect button visible and this is not changed until you move mouse cursor to another item, thus when a notification appears and you click on the button it works and the button remains visible.


Diffs (updated)
-----

applet/contents/ui/ConnectionItem.qml 3fa93b5
applet/contents/ui/PopupDialog.qml 2a0d352

Diff: https://git.reviewboard.kde.org/r/124314/diff/


Testing
-------


Thanks,

Jan Grulich

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124314/#review82851
-----------------------------------------------------------


+1

- David Edmundson

Post by Jan Grulich
-----------------------------------------------------------
https://git.reviewboard.kde.org/r/124314/
-----------------------------------------------------------
(Updated July 23, 2015, 3:12 p.m.)
Review request for Network Management and Plasma.
Bugs: 348905
http://bugs.kde.org/show_bug.cgi?id=348905
Repository: plasma-nm
Description
-------
Previously the button was shown when item contained mouse cursor, but when a notification appeared and you clicked on the button the "containsMouse" property was changed to false and click on the button didn't have any effect. Now I store which item has the connect/disconnect button visible and this is not changed until you move mouse cursor to another item, thus when a notification appears and you click on the button it works and the button remains visible.
Diffs
-----
applet/contents/ui/ConnectionItem.qml 3fa93b5
applet/contents/ui/PopupDialog.qml 2a0d352
Diff: https://git.reviewboard.kde.org/r/124314/diff/
Testing
-------
Thanks,
Jan Grulich

[Lamarque Souza]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124314/#review82922
-----------------------------------------------------------

Ship it!


Ship It!

- Lamarque Souza

Post by Jan Grulich
-----------------------------------------------------------
https://git.reviewboard.kde.org/r/124314/
-----------------------------------------------------------
(Updated July 23, 2015, 3:12 p.m.)
Review request for Network Management and Plasma.
Bugs: 348905
http://bugs.kde.org/show_bug.cgi?id=348905
Repository: plasma-nm
Description
-------
Previously the button was shown when item contained mouse cursor, but when a notification appeared and you clicked on the button the "containsMouse" property was changed to false and click on the button didn't have any effect. Now I store which item has the connect/disconnect button visible and this is not changed until you move mouse cursor to another item, thus when a notification appears and you click on the button it works and the button remains visible.
Diffs
-----
applet/contents/ui/ConnectionItem.qml 3fa93b5
applet/contents/ui/PopupDialog.qml 2a0d352
Diff: https://git.reviewboard.kde.org/r/124314/diff/
Testing
-------
Thanks,
Jan Grulich

[Jan Grulich]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124314/
-----------------------------------------------------------

(Updated July 25, 2015, 11:33 a.m.)


Status
------

This change has been marked as submitted.


Review request for Network Management and Plasma.


Changes
-------

Submitted with commit f1ae6f60769876e5f7ddc0c710f5dec9f862a6e6 by Jan Grulich to branch master.


Bugs: 348905
http://bugs.kde.org/show_bug.cgi?id=348905


Repository: plasma-nm


Description
-------

Previously the button was shown when item contained mouse cursor, but when a notification appeared and you clicked on the button the "containsMouse" property was changed to false and click on the button didn't have any effect. Now I store which item has the connect/disconnect button visible and this is not changed until you move mouse cursor to another item, thus when a notification appears and you click on the button it works and the button remains visible.


Diffs
-----

applet/contents/ui/ConnectionItem.qml 3fa93b5
applet/contents/ui/PopupDialog.qml 2a0d352

Diff: https://git.reviewboard.kde.org/r/124314/diff/


Testing
-------


Thanks,

Jan Grulich