Review Request 126714: Make sure we show correct icon when a VPN connection with type of generic gets default route

[Jan Grulich]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126714/
-----------------------------------------------------------

Review request for Network Management and Lamarque Souza.


Bugs: 357816
http://bugs.kde.org/show_bug.cgi?id=357816


Repository: plasma-nm


Description
-------

Reproducible with l2tp connections (you can use http://freel2tpvpn.com/). In case you activate it, NM creates automaticaly ppp0 connection which gets the default route, but this connection is type of generic, thus getting device for it in setIcons() leads to setDisconnectedIcon() because we care only about certain devices. What we actually have to do is to go through all active connections and find the one with hightest probability of being the main one (e.g. a wired connection is probably used as the main one than some wireless connection), also if there is an active VPN connection then it's probably the one for which NM created a ppp0 connection and it's the one we are interested about.


Diffs
-----

libs/declarative/connectionicon.cpp c000a8f

Diff: https://git.reviewboard.kde.org/r/126714/diff/


Testing
-------

Tested with L2TP.


Thanks,

Jan Grulich

[Lamarque Souza]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126714/#review90881
-----------------------------------------------------------

Ship it!


Ship It!

- Lamarque Souza

Post by Jan Grulich
-----------------------------------------------------------
https://git.reviewboard.kde.org/r/126714/
-----------------------------------------------------------
(Updated Jan. 11, 2016, 9:32 a.m.)
Review request for Network Management and Lamarque Souza.
Bugs: 357816
http://bugs.kde.org/show_bug.cgi?id=357816
Repository: plasma-nm
Description
-------
Reproducible with l2tp connections (you can use http://freel2tpvpn.com/). In case you activate it, NM creates automaticaly ppp0 connection which gets the default route, but this connection is type of generic, thus getting device for it in setIcons() leads to setDisconnectedIcon() because we care only about certain devices. What we actually have to do is to go through all active connections and find the one with hightest probability of being the main one (e.g. a wired connection is probably used as the main one than some wireless connection), also if there is an active VPN connection then it's probably the one for which NM created a ppp0 connection and it's the one we are interested about.
Diffs
-----
libs/declarative/connectionicon.cpp c000a8f
Diff: https://git.reviewboard.kde.org/r/126714/diff/
Testing
-------
Tested with L2TP.
Thanks,
Jan Grulich

[Jan Grulich]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126714/
-----------------------------------------------------------

(Updated Jan. 11, 2016, 12:19 p.m.)


Status
------

This change has been marked as submitted.


Review request for Network Management and Lamarque Souza.


Changes
-------

Submitted with commit 190e27a1acaa4469aaeca0653fd0a4368f730ecc by Jan Grulich to branch master.


Bugs: 357816
http://bugs.kde.org/show_bug.cgi?id=357816


Repository: plasma-nm


Description
-------

Reproducible with l2tp connections (you can use http://freel2tpvpn.com/). In case you activate it, NM creates automaticaly ppp0 connection which gets the default route, but this connection is type of generic, thus getting device for it in setIcons() leads to setDisconnectedIcon() because we care only about certain devices. What we actually have to do is to go through all active connections and find the one with hightest probability of being the main one (e.g. a wired connection is probably used as the main one than some wireless connection), also if there is an active VPN connection then it's probably the one for which NM created a ppp0 connection and it's the one we are interested about.


Diffs
-----

libs/declarative/connectionicon.cpp c000a8f

Diff: https://git.reviewboard.kde.org/r/126714/diff/


Testing
-------

Tested with L2TP.


Thanks,

Jan Grulich