Review Request 128832: Take upload speed into account for maximum plotter value

[Jan Grulich]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128832/
-----------------------------------------------------------

Review request for Network Management and Plasma.


Bugs: 368247
http://bugs.kde.org/show_bug.cgi?id=368247


Repository: plasma-nm


Description
-------

When the upload speed is higher then the download we should set maximum plotter value based on that.


Diffs
-----

applet/contents/ui/ConnectionItem.qml 3440e39

Diff: https://git.reviewboard.kde.org/r/128832/diff/


Testing
-------


Thanks,

Jan Grulich

[Kai Uwe Broulik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128832/#review98891
-----------------------------------------------------------




applet/contents/ui/ConnectionItem.qml (line 351)
<https://git.reviewboard.kde.org/r/128832/#comment66583>

All of this could be simplified to:
onValuesChanged: maxValue = Math.max.apply(null, downloadPlotData.values.concat(uploadPlotData.values))

(if values behaves like a JS Array)

Also, perhaps you can even bind that, ie.
maxValue: Math.max(...)


- Kai Uwe Broulik

Post by Jan Grulich
-----------------------------------------------------------
https://git.reviewboard.kde.org/r/128832/
-----------------------------------------------------------
(Updated Sept. 5, 2016, 9:09 vorm.)
Review request for Network Management and Plasma.
Bugs: 368247
http://bugs.kde.org/show_bug.cgi?id=368247
Repository: plasma-nm
Description
-------
When the upload speed is higher then the download we should set maximum plotter value based on that.
Diffs
-----
applet/contents/ui/ConnectionItem.qml 3440e39
Diff: https://git.reviewboard.kde.org/r/128832/diff/
Testing
-------
Thanks,
Jan Grulich

[Jan Grulich]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128832/
-----------------------------------------------------------

(Updated Zář. 5, 2016, 10:43 dop.)


Review request for Network Management and Plasma.


Changes
-------

Simplify the code. Joining both arrays doesn't work for some reason so this is the only way I could make it work.


Bugs: 368247
http://bugs.kde.org/show_bug.cgi?id=368247


Repository: plasma-nm


Description
-------

When the upload speed is higher then the download we should set maximum plotter value based on that.


Diffs (updated)
-----

applet/contents/ui/ConnectionItem.qml 3440e39

Diff: https://git.reviewboard.kde.org/r/128832/diff/


Testing
-------


Thanks,

Jan Grulich

[Jan Grulich]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128832/
-----------------------------------------------------------

(Updated Zář. 5, 2016, 10:58 dop.)


Review request for Network Management and Plasma.


Changes
-------

Make it more simplier.


Bugs: 368247
http://bugs.kde.org/show_bug.cgi?id=368247


Repository: plasma-nm


Description
-------

When the upload speed is higher then the download we should set maximum plotter value based on that.


Diffs (updated)
-----

applet/contents/ui/ConnectionItem.qml 3440e39

Diff: https://git.reviewboard.kde.org/r/128832/diff/


Testing
-------


Thanks,

Jan Grulich

[Kai Uwe Broulik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128832/#review98898
-----------------------------------------------------------


Fix it, then Ship it!





applet/contents/ui/ConnectionItem.qml (line 310)
<https://git.reviewboard.kde.org/r/128832/#comment66584>

Make property readonly and add an empty line afterwards

Also perhaps add a comment on how Math.max in conjunction with concatenated QList<qreal> doesn't work


- Kai Uwe Broulik

Post by Jan Grulich
-----------------------------------------------------------
https://git.reviewboard.kde.org/r/128832/
-----------------------------------------------------------
(Updated Sept. 5, 2016, 10:58 vorm.)
Review request for Network Management and Plasma.
Bugs: 368247
http://bugs.kde.org/show_bug.cgi?id=368247
Repository: plasma-nm
Description
-------
When the upload speed is higher then the download we should set maximum plotter value based on that.
Diffs
-----
applet/contents/ui/ConnectionItem.qml 3440e39
Diff: https://git.reviewboard.kde.org/r/128832/diff/
Testing
-------
Thanks,
Jan Grulich

[Jan Grulich]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128832/
-----------------------------------------------------------

(Updated Sept. 5, 2016, 2:59 p.m.)


Status
------

This change has been marked as submitted.


Review request for Network Management and Plasma.


Changes
-------

Submitted with commit fc1b78afd310bdf7703982c973b957a222208d64 by Jan Grulich to branch master.


Bugs: 368247
http://bugs.kde.org/show_bug.cgi?id=368247


Repository: plasma-nm


Description
-------

When the upload speed is higher then the download we should set maximum plotter value based on that.


Diffs
-----

applet/contents/ui/ConnectionItem.qml 3440e39

Diff: https://git.reviewboard.kde.org/r/128832/diff/


Testing
-------


Thanks,

Jan Grulich