Discussion:
Review Request 126715: Re-check connection state and other properties to be sure they are actual (version 2)
Jan Grulich
2016-01-11 09:58:46 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126715/
-----------------------------------------------------------

Review request for Network Management and Lamarque Souza.


Bugs: 352326
http://bugs.kde.org/show_bug.cgi?id=352326


Repository: networkmanager-qt


Description
-------

Previous review request: 126029

My previous solution doesn't seem to work, probably because I was sending signals from constructor. I changed this to asynchronous calls so signals should be now emitted when ActiveConnection is properly constructed.


Diffs
-----

src/activeconnection.cpp f29ca67

Diff: https://git.reviewboard.kde.org/r/126715/diff/


Testing
-------


Thanks,

Jan Grulich
Lamarque Souza
2016-01-11 10:42:46 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126715/#review90875
-----------------------------------------------------------



src/activeconnection.cpp (line 150)
<https://git.reviewboard.kde.org/r/126715/#comment62086>

You missed deleteLater() here.



src/activeconnection.cpp (line 184)
<https://git.reviewboard.kde.org/r/126715/#comment62085>

You could create a common method called from both constructors instead of duplicating this code in them.


- Lamarque Souza
Post by Jan Grulich
-----------------------------------------------------------
https://git.reviewboard.kde.org/r/126715/
-----------------------------------------------------------
(Updated Jan. 11, 2016, 9:58 a.m.)
Review request for Network Management and Lamarque Souza.
Bugs: 352326
http://bugs.kde.org/show_bug.cgi?id=352326
Repository: networkmanager-qt
Description
-------
Previous review request: 126029
My previous solution doesn't seem to work, probably because I was sending signals from constructor. I changed this to asynchronous calls so signals should be now emitted when ActiveConnection is properly constructed.
Diffs
-----
src/activeconnection.cpp f29ca67
Diff: https://git.reviewboard.kde.org/r/126715/diff/
Testing
-------
Thanks,
Jan Grulich
Jan Grulich
2016-01-11 11:16:08 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126715/
-----------------------------------------------------------

(Updated Led. 11, 2016, 11:16 dop.)


Review request for Network Management and Lamarque Souza.


Changes
-------

Updated patch fixing mentioned issues.


Bugs: 352326
http://bugs.kde.org/show_bug.cgi?id=352326


Repository: networkmanager-qt


Description
-------

Previous review request: 126029

My previous solution doesn't seem to work, probably because I was sending signals from constructor. I changed this to asynchronous calls so signals should be now emitted when ActiveConnection is properly constructed.


Diffs (updated)
-----

src/activeconnection.cpp f29ca67
src/activeconnection_p.h 75a7c4e

Diff: https://git.reviewboard.kde.org/r/126715/diff/


Testing
-------


Thanks,

Jan Grulich
Lamarque Souza
2016-01-11 11:18:05 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126715/#review90877
-----------------------------------------------------------

Ship it!


Ship It!

- Lamarque Souza
Post by Jan Grulich
-----------------------------------------------------------
https://git.reviewboard.kde.org/r/126715/
-----------------------------------------------------------
(Updated Jan. 11, 2016, 11:16 a.m.)
Review request for Network Management and Lamarque Souza.
Bugs: 352326
http://bugs.kde.org/show_bug.cgi?id=352326
Repository: networkmanager-qt
Description
-------
Previous review request: 126029
My previous solution doesn't seem to work, probably because I was sending signals from constructor. I changed this to asynchronous calls so signals should be now emitted when ActiveConnection is properly constructed.
Diffs
-----
src/activeconnection.cpp f29ca67
src/activeconnection_p.h 75a7c4e
Diff: https://git.reviewboard.kde.org/r/126715/diff/
Testing
-------
Thanks,
Jan Grulich
Jan Grulich
2016-01-11 11:21:48 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126715/
-----------------------------------------------------------

(Updated Jan. 11, 2016, 11:21 a.m.)


Status
------

This change has been marked as submitted.


Review request for Network Management and Lamarque Souza.


Changes
-------

Submitted with commit 402c1f27fc37ba93069b8c2fa6b0ee6f3c9d198f by Jan Grulich to branch master.


Bugs: 352326
http://bugs.kde.org/show_bug.cgi?id=352326


Repository: networkmanager-qt


Description
-------

Previous review request: 126029

My previous solution doesn't seem to work, probably because I was sending signals from constructor. I changed this to asynchronous calls so signals should be now emitted when ActiveConnection is properly constructed.


Diffs
-----

src/activeconnection.cpp f29ca67
src/activeconnection_p.h 75a7c4e

Diff: https://git.reviewboard.kde.org/r/126715/diff/


Testing
-------


Thanks,

Jan Grulich

Loading...