Jan Grulich
2016-01-11 09:58:46 UTC
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126715/
-----------------------------------------------------------
Review request for Network Management and Lamarque Souza.
Bugs: 352326
http://bugs.kde.org/show_bug.cgi?id=352326
Repository: networkmanager-qt
Description
-------
Previous review request: 126029
My previous solution doesn't seem to work, probably because I was sending signals from constructor. I changed this to asynchronous calls so signals should be now emitted when ActiveConnection is properly constructed.
Diffs
-----
src/activeconnection.cpp f29ca67
Diff: https://git.reviewboard.kde.org/r/126715/diff/
Testing
-------
Thanks,
Jan Grulich
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126715/
-----------------------------------------------------------
Review request for Network Management and Lamarque Souza.
Bugs: 352326
http://bugs.kde.org/show_bug.cgi?id=352326
Repository: networkmanager-qt
Description
-------
Previous review request: 126029
My previous solution doesn't seem to work, probably because I was sending signals from constructor. I changed this to asynchronous calls so signals should be now emitted when ActiveConnection is properly constructed.
Diffs
-----
src/activeconnection.cpp f29ca67
Diff: https://git.reviewboard.kde.org/r/126715/diff/
Testing
-------
Thanks,
Jan Grulich