Review Request 126118: Do not consider virtual devices for systray icon

[Jan Grulich]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126118/
-----------------------------------------------------------

Review request for Network Management and Lamarque Souza.


Repository: plasma-nm


Description
-------

Discussed this with NM devs, nm-applet and gnome-shell also don't consider bridge/bond/team/etc devices when figuring out which icon to display in system tray, because these devices are mostly meaningless and used by many things (like virt) so you actually have no idea whether you are connected through a regular connection or not, which is what everyone wants to actually know.


Diffs
-----

libs/declarative/connectionicon.cpp 62fd7a9

Diff: https://git.reviewboard.kde.org/r/126118/diff/


Testing
-------


Thanks,

Jan Grulich

[Lamarque Souza]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126118/#review88608
-----------------------------------------------------------

Ship it!


Ship It!

- Lamarque Souza

Post by Jan Grulich
-----------------------------------------------------------
https://git.reviewboard.kde.org/r/126118/
-----------------------------------------------------------
(Updated Nov. 19, 2015, 2:08 p.m.)
Review request for Network Management and Lamarque Souza.
Repository: plasma-nm
Description
-------
Discussed this with NM devs, nm-applet and gnome-shell also don't consider bridge/bond/team/etc devices when figuring out which icon to display in system tray, because these devices are mostly meaningless and used by many things (like virt) so you actually have no idea whether you are connected through a regular connection or not, which is what everyone wants to actually know.
Diffs
-----
libs/declarative/connectionicon.cpp 62fd7a9
Diff: https://git.reviewboard.kde.org/r/126118/diff/
Testing
-------
Thanks,
Jan Grulich

[Jan Grulich]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126118/
-----------------------------------------------------------

(Updated Nov. 20, 2015, 7:48 a.m.)


Status
------

This change has been marked as submitted.


Review request for Network Management and Lamarque Souza.


Changes
-------

Submitted with commit 1e840b9877286592a20cfba1f91b676d178e5ae8 by Jan Grulich to branch master.


Repository: plasma-nm


Description
-------

Discussed this with NM devs, nm-applet and gnome-shell also don't consider bridge/bond/team/etc devices when figuring out which icon to display in system tray, because these devices are mostly meaningless and used by many things (like virt) so you actually have no idea whether you are connected through a regular connection or not, which is what everyone wants to actually know.


Diffs
-----

libs/declarative/connectionicon.cpp 62fd7a9

Diff: https://git.reviewboard.kde.org/r/126118/diff/


Testing
-------


Thanks,

Jan Grulich