Discussion:
Review Request 128487: Default to WPA2-PSK and WPA2-EAP when getting security type from connection settings
Jan Grulich
2016-07-19 13:07:29 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128487/
-----------------------------------------------------------

Review request for Network Management and Lamarque Souza.


Bugs: 365704
http://bugs.kde.org/show_bug.cgi?id=365704


Repository: networkmanager-qt


Description
-------

I think that wpa2 should be preferred over wpa (as more widely used and more secured), althought it's just a label and the result doesn't matter that much.


Diffs
-----

src/utils.cpp f639e30

Diff: https://git.reviewboard.kde.org/r/128487/diff/


Testing
-------


Thanks,

Jan Grulich
Lamarque Souza
2016-07-19 14:06:10 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128487/#review97612
-----------------------------------------------------------




src/utils.cpp (line 439)
<https://git.reviewboard.kde.org/r/128487/#comment65799>

You could have simplified this code by just removing the code between this if-clause until the else-clause.



src/utils.cpp (line 446)
<https://git.reviewboard.kde.org/r/128487/#comment65800>

Same here.


- Lamarque Souza
Post by Jan Grulich
-----------------------------------------------------------
https://git.reviewboard.kde.org/r/128487/
-----------------------------------------------------------
(Updated July 19, 2016, 1:07 p.m.)
Review request for Network Management and Lamarque Souza.
Bugs: 365704
http://bugs.kde.org/show_bug.cgi?id=365704
Repository: networkmanager-qt
Description
-------
I think that wpa2 should be preferred over wpa (as more widely used and more secured), althought it's just a label and the result doesn't matter that much.
Diffs
-----
src/utils.cpp f639e30
Diff: https://git.reviewboard.kde.org/r/128487/diff/
Testing
-------
Thanks,
Jan Grulich
Jan Grulich
2016-07-19 14:10:18 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128487/
-----------------------------------------------------------

(Updated Čec. 19, 2016, 2:10 odp.)


Review request for Network Management and Lamarque Souza.


Changes
-------

Simplify the code.


Bugs: 365704
http://bugs.kde.org/show_bug.cgi?id=365704


Repository: networkmanager-qt


Description
-------

I think that wpa2 should be preferred over wpa (as more widely used and more secured), althought it's just a label and the result doesn't matter that much.


Diffs (updated)
-----

src/utils.cpp f639e30

Diff: https://git.reviewboard.kde.org/r/128487/diff/


Testing
-------


Thanks,

Jan Grulich
Lamarque Souza
2016-07-19 14:38:51 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128487/#review97616
-----------------------------------------------------------


Ship it!




Ship It!

- Lamarque Souza
Post by Jan Grulich
-----------------------------------------------------------
https://git.reviewboard.kde.org/r/128487/
-----------------------------------------------------------
(Updated July 19, 2016, 2:10 p.m.)
Review request for Network Management and Lamarque Souza.
Bugs: 365704
http://bugs.kde.org/show_bug.cgi?id=365704
Repository: networkmanager-qt
Description
-------
I think that wpa2 should be preferred over wpa (as more widely used and more secured), althought it's just a label and the result doesn't matter that much.
Diffs
-----
src/utils.cpp f639e30
Diff: https://git.reviewboard.kde.org/r/128487/diff/
Testing
-------
Thanks,
Jan Grulich
Jan Grulich
2016-07-19 14:53:17 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128487/
-----------------------------------------------------------

(Updated July 19, 2016, 2:53 p.m.)


Status
------

This change has been marked as submitted.


Review request for Network Management and Lamarque Souza.


Changes
-------

Submitted with commit 2fd710f78a1931c014fdaa4f84f9bc3895d9f2d5 by Jan Grulich to branch master.


Bugs: 365704
http://bugs.kde.org/show_bug.cgi?id=365704


Repository: networkmanager-qt


Description
-------

I think that wpa2 should be preferred over wpa (as more widely used and more secured), althought it's just a label and the result doesn't matter that much.


Diffs
-----

src/utils.cpp f639e30

Diff: https://git.reviewboard.kde.org/r/128487/diff/


Testing
-------


Thanks,

Jan Grulich

Loading...