Discussion:
Review Request 128332: [Plasma-nm] Indicate flight mode in system tray icon
Kai Uwe Broulik
2016-06-30 20:21:20 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128332/
-----------------------------------------------------------

Review request for Network Management, Plasma and KDE Usability.


Repository: plasma-nm


Description
-------

This changes the tray icon to the airplane icon when in flight mode.

Also changes the SwitchButton to use a PlasmaCore.IconItem instead of a PlasmaCore.Svg to be consisteht with the tray icon.

BUG: 364626


Diffs
-----

applet/contents/ui/SwitchButton.qml 3ea3079
applet/contents/ui/Toolbar.qml 64b6e0a
libs/declarative/connectionicon.h 499b4f6
libs/declarative/connectionicon.cpp 90060a3

Diff: https://git.reviewboard.kde.org/r/128332/diff/


Testing
-------

Enabled flightmode, got airplane icon
Disabled flightmode, briefly got "no network" icon until my wifi was connected again.

The flight mode is only shown when flight mode is enabled and there really isn't any connection.

NOTE VDG: The icon flightmode-on and flightmode-off need to be renamed to network-flightmode-on and network-flightmode-off (keeping the old ones in there for compatibility!) so Plasma IconItem finds it.


File Attachments
----------------

Flightmode icon
Loading Image...


Thanks,

Kai Uwe Broulik
Jan Grulich
2016-07-01 07:23:20 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128332/#review96984
-----------------------------------------------------------



Looks good for me, let's wait for the VDG approval.

- Jan Grulich
Post by Kai Uwe Broulik
-----------------------------------------------------------
https://git.reviewboard.kde.org/r/128332/
-----------------------------------------------------------
(Updated Čer. 30, 2016, 8:21 odp.)
Review request for Network Management, Plasma and KDE Usability.
Repository: plasma-nm
Description
-------
This changes the tray icon to the airplane icon when in flight mode.
Also changes the SwitchButton to use a PlasmaCore.IconItem instead of a PlasmaCore.Svg to be consisteht with the tray icon.
BUG: 364626
Diffs
-----
applet/contents/ui/SwitchButton.qml 3ea3079
applet/contents/ui/Toolbar.qml 64b6e0a
libs/declarative/connectionicon.h 499b4f6
libs/declarative/connectionicon.cpp 90060a3
Diff: https://git.reviewboard.kde.org/r/128332/diff/
Testing
-------
Enabled flightmode, got airplane icon
Disabled flightmode, briefly got "no network" icon until my wifi was connected again.
The flight mode is only shown when flight mode is enabled and there really isn't any connection.
NOTE VDG: The icon flightmode-on and flightmode-off need to be renamed to network-flightmode-on and network-flightmode-off (keeping the old ones in there for compatibility!) so Plasma IconItem finds it.
File Attachments
----------------
Flightmode icon
https://git.reviewboard.kde.org/media/uploaded/files/2016/06/30/df8a84c2-5a91-42d1-be43-70685061c8e4__Screenshot_20160630_221424.png
Thanks,
Kai Uwe Broulik
Jens Reuterberg
2016-07-02 09:03:43 UTC
Permalink
Post by Kai Uwe Broulik
Post by Jan Grulich
Looks good for me, let's wait for the VDG approval.
[adds the seal of "Approved by Designers" to the code]


- Jens


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128332/#review96984
-----------------------------------------------------------
Post by Kai Uwe Broulik
-----------------------------------------------------------
https://git.reviewboard.kde.org/r/128332/
-----------------------------------------------------------
(Updated June 30, 2016, 8:21 p.m.)
Review request for Network Management, Plasma and KDE Usability.
Repository: plasma-nm
Description
-------
This changes the tray icon to the airplane icon when in flight mode.
Also changes the SwitchButton to use a PlasmaCore.IconItem instead of a PlasmaCore.Svg to be consisteht with the tray icon.
BUG: 364626
Diffs
-----
applet/contents/ui/SwitchButton.qml 3ea3079
applet/contents/ui/Toolbar.qml 64b6e0a
libs/declarative/connectionicon.h 499b4f6
libs/declarative/connectionicon.cpp 90060a3
Diff: https://git.reviewboard.kde.org/r/128332/diff/
Testing
-------
Enabled flightmode, got airplane icon
Disabled flightmode, briefly got "no network" icon until my wifi was connected again.
The flight mode is only shown when flight mode is enabled and there really isn't any connection.
NOTE VDG: The icon flightmode-on and flightmode-off need to be renamed to network-flightmode-on and network-flightmode-off (keeping the old ones in there for compatibility!) so Plasma IconItem finds it.
File Attachments
----------------
Flightmode icon
https://git.reviewboard.kde.org/media/uploaded/files/2016/06/30/df8a84c2-5a91-42d1-be43-70685061c8e4__Screenshot_20160630_221424.png
Thanks,
Kai Uwe Broulik
Jens Reuterberg
2016-07-02 09:03:10 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128332/#review97012
-----------------------------------------------------------



Looks good, as long as it doesn't add an extra icon visible at all times but replace the network icon we are all for.

- Jens Reuterberg
Post by Kai Uwe Broulik
-----------------------------------------------------------
https://git.reviewboard.kde.org/r/128332/
-----------------------------------------------------------
(Updated June 30, 2016, 8:21 p.m.)
Review request for Network Management, Plasma and KDE Usability.
Repository: plasma-nm
Description
-------
This changes the tray icon to the airplane icon when in flight mode.
Also changes the SwitchButton to use a PlasmaCore.IconItem instead of a PlasmaCore.Svg to be consisteht with the tray icon.
BUG: 364626
Diffs
-----
applet/contents/ui/SwitchButton.qml 3ea3079
applet/contents/ui/Toolbar.qml 64b6e0a
libs/declarative/connectionicon.h 499b4f6
libs/declarative/connectionicon.cpp 90060a3
Diff: https://git.reviewboard.kde.org/r/128332/diff/
Testing
-------
Enabled flightmode, got airplane icon
Disabled flightmode, briefly got "no network" icon until my wifi was connected again.
The flight mode is only shown when flight mode is enabled and there really isn't any connection.
NOTE VDG: The icon flightmode-on and flightmode-off need to be renamed to network-flightmode-on and network-flightmode-off (keeping the old ones in there for compatibility!) so Plasma IconItem finds it.
File Attachments
----------------
Flightmode icon
https://git.reviewboard.kde.org/media/uploaded/files/2016/06/30/df8a84c2-5a91-42d1-be43-70685061c8e4__Screenshot_20160630_221424.png
Thanks,
Kai Uwe Broulik
Jan Grulich
2016-07-04 07:18:16 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128332/#review97075
-----------------------------------------------------------


Ship it!




Ship It!

- Jan Grulich
Post by Kai Uwe Broulik
-----------------------------------------------------------
https://git.reviewboard.kde.org/r/128332/
-----------------------------------------------------------
(Updated Čer. 30, 2016, 8:21 odp.)
Review request for Network Management, Plasma and KDE Usability.
Repository: plasma-nm
Description
-------
This changes the tray icon to the airplane icon when in flight mode.
Also changes the SwitchButton to use a PlasmaCore.IconItem instead of a PlasmaCore.Svg to be consisteht with the tray icon.
BUG: 364626
Diffs
-----
applet/contents/ui/SwitchButton.qml 3ea3079
applet/contents/ui/Toolbar.qml 64b6e0a
libs/declarative/connectionicon.h 499b4f6
libs/declarative/connectionicon.cpp 90060a3
Diff: https://git.reviewboard.kde.org/r/128332/diff/
Testing
-------
Enabled flightmode, got airplane icon
Disabled flightmode, briefly got "no network" icon until my wifi was connected again.
The flight mode is only shown when flight mode is enabled and there really isn't any connection.
NOTE VDG: The icon flightmode-on and flightmode-off need to be renamed to network-flightmode-on and network-flightmode-off (keeping the old ones in there for compatibility!) so Plasma IconItem finds it.
File Attachments
----------------
Flightmode icon
https://git.reviewboard.kde.org/media/uploaded/files/2016/06/30/df8a84c2-5a91-42d1-be43-70685061c8e4__Screenshot_20160630_221424.png
Thanks,
Kai Uwe Broulik
Kai Uwe Broulik
2016-07-15 09:43:12 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128332/#review97433
-----------------------------------------------------------



Has the icon been added already?

- Kai Uwe Broulik
Post by Kai Uwe Broulik
-----------------------------------------------------------
https://git.reviewboard.kde.org/r/128332/
-----------------------------------------------------------
(Updated Juni 30, 2016, 8:21 nachm.)
Review request for Network Management, Plasma and KDE Usability.
Repository: plasma-nm
Description
-------
This changes the tray icon to the airplane icon when in flight mode.
Also changes the SwitchButton to use a PlasmaCore.IconItem instead of a PlasmaCore.Svg to be consisteht with the tray icon.
BUG: 364626
Diffs
-----
applet/contents/ui/SwitchButton.qml 3ea3079
applet/contents/ui/Toolbar.qml 64b6e0a
libs/declarative/connectionicon.h 499b4f6
libs/declarative/connectionicon.cpp 90060a3
Diff: https://git.reviewboard.kde.org/r/128332/diff/
Testing
-------
Enabled flightmode, got airplane icon
Disabled flightmode, briefly got "no network" icon until my wifi was connected again.
The flight mode is only shown when flight mode is enabled and there really isn't any connection.
NOTE VDG: The icon flightmode-on and flightmode-off need to be renamed to network-flightmode-on and network-flightmode-off (keeping the old ones in there for compatibility!) so Plasma IconItem finds it.
File Attachments
----------------
Flightmode icon
https://git.reviewboard.kde.org/media/uploaded/files/2016/06/30/df8a84c2-5a91-42d1-be43-70685061c8e4__Screenshot_20160630_221424.png
Thanks,
Kai Uwe Broulik
Kai Uwe Broulik
2016-08-01 15:47:31 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128332/
-----------------------------------------------------------

(Updated Aug. 1, 2016, 3:47 p.m.)


Status
------

This change has been marked as submitted.


Review request for Network Management, Plasma and KDE Usability.


Changes
-------

Submitted with commit 2d0150fc72981b27712ee80590d4b2741626e317 by Kai Uwe Broulik to branch master.


Repository: plasma-nm


Description
-------

This changes the tray icon to the airplane icon when in flight mode.

Also changes the SwitchButton to use a PlasmaCore.IconItem instead of a PlasmaCore.Svg to be consisteht with the tray icon.

BUG: 364626


Diffs
-----

applet/contents/ui/SwitchButton.qml 3ea3079
applet/contents/ui/Toolbar.qml 64b6e0a
libs/declarative/connectionicon.h 499b4f6
libs/declarative/connectionicon.cpp 90060a3

Diff: https://git.reviewboard.kde.org/r/128332/diff/


Testing
-------

Enabled flightmode, got airplane icon
Disabled flightmode, briefly got "no network" icon until my wifi was connected again.

The flight mode is only shown when flight mode is enabled and there really isn't any connection.

NOTE VDG: The icon flightmode-on and flightmode-off need to be renamed to network-flightmode-on and network-flightmode-off (keeping the old ones in there for compatibility!) so Plasma IconItem finds it.


File Attachments
----------------

Flightmode icon
https://git.reviewboard.kde.org/media/uploaded/files/2016/06/30/df8a84c2-5a91-42d1-be43-70685061c8e4__Screenshot_20160630_221424.png


Thanks,

Kai Uwe Broulik

Loading...