Discussion:
Review Request 123465: Add support for SSH VPN plugin
Jan Grulich
2015-04-22 12:37:34 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123465/
-----------------------------------------------------------

Review request for Network Management, Lukáš Tinkl and Lamarque Souza.


Bugs: 341070
http://bugs.kde.org/show_bug.cgi?id=341070


Repository: plasma-nm


Description
-------

This patch adds support for SSH VPN plugin (according to nm-connection-editor).


Diffs
-----

vpn/ssh/CMakeLists.txt PRE-CREATION
vpn/ssh/Messages.sh PRE-CREATION
vpn/ssh/nm-ssh-service.h PRE-CREATION
vpn/ssh/plasmanetworkmanagement_sshui.desktop PRE-CREATION
vpn/ssh/ssh.h PRE-CREATION
vpn/ssh/ssh.cpp PRE-CREATION
vpn/ssh/sshadvanced.ui PRE-CREATION
vpn/ssh/sshauth.h PRE-CREATION
vpn/ssh/sshauth.cpp PRE-CREATION
vpn/ssh/sshauth.ui PRE-CREATION
vpn/ssh/sshwidget.h PRE-CREATION
vpn/ssh/sshwidget.cpp PRE-CREATION
vpn/ssh/sshwidget.ui PRE-CREATION

Diff: https://git.reviewboard.kde.org/r/123465/diff/


Testing
-------

I tried to create a new SSH VPN connection in both (kde5-)nm-connection-editor and re-open it in another editor to check whether all values were stored/loaded properly.


Thanks,

Jan Grulich
Jan Grulich
2015-04-22 13:06:01 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123465/
-----------------------------------------------------------

(Updated Dub. 22, 2015, 1:06 odp.)


Review request for Network Management, Lukáš Tinkl and Lamarque Souza.


Changes
-------

Uploaded complete patch.


Bugs: 341070
http://bugs.kde.org/show_bug.cgi?id=341070


Repository: plasma-nm


Description
-------

This patch adds support for SSH VPN plugin (according to nm-connection-editor).


Diffs (updated)
-----

vpn/ssh/sshwidget.ui PRE-CREATION
vpn/ssh/sshwidget.h PRE-CREATION
vpn/ssh/sshwidget.cpp PRE-CREATION
vpn/ssh/sshauth.ui PRE-CREATION
vpn/ssh/sshauth.cpp PRE-CREATION
vpn/ssh/sshadvanced.ui PRE-CREATION
vpn/ssh/sshauth.h PRE-CREATION
vpn/ssh/ssh.cpp PRE-CREATION
vpn/ssh/ssh.h PRE-CREATION
vpn/ssh/nm-ssh-service.h PRE-CREATION
vpn/ssh/plasmanetworkmanagement_sshui.desktop PRE-CREATION
vpn/ssh/Messages.sh PRE-CREATION
vpn/ssh/CMakeLists.txt PRE-CREATION
vpn/CMakeLists.txt 714fff0
libs/editor/simpleipv4addressvalidator.h 9a4e270
libs/editor/simpleipv6addressvalidator.h 934dc99

Diff: https://git.reviewboard.kde.org/r/123465/diff/


Testing
-------

I tried to create a new SSH VPN connection in both (kde5-)nm-connection-editor and re-open it in another editor to check whether all values were stored/loaded properly.


Thanks,

Jan Grulich
Lamarque Souza
2015-04-22 14:09:17 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123465/#review79341
-----------------------------------------------------------



vpn/ssh/sshadvanced.ui (line 32)
<https://git.reviewboard.kde.org/r/123465/#comment54184>

Max port value is 65535



vpn/ssh/sshauth.h (line 38)
<https://git.reviewboard.kde.org/r/123465/#comment54179>

This commented code block can be removed.



vpn/ssh/sshauth.h (line 42)
<https://git.reviewboard.kde.org/r/123465/#comment54180>

Same here.



vpn/ssh/sshauth.cpp (line 35)
<https://git.reviewboard.kde.org/r/123465/#comment54181>

Code style, it should be one variable per line:

: SettingWidget(setting, parent)
, d_ptr(new ...)



vpn/ssh/sshwidget.cpp (line 161)
<https://git.reviewboard.kde.org/r/123465/#comment54182>

This can be simplified to:

if (type & NetworkManager::Setting::AgentOwned || type == NetworkManager::Setting::None)

NetworkManager::Setting::None == 0, so "type & NetworkManager::Setting::None" is always false and using "type == NetworkManager::Setting::None" is more explicit then "!type" in my oppinion.



vpn/ssh/sshwidget.cpp (line 256)
<https://git.reviewboard.kde.org/r/123465/#comment54183>

Code style: I prefer to use switch() in situations like this one.



vpn/ssh/sshwidget.cpp (line 349)
<https://git.reviewboard.kde.org/r/123465/#comment54185>

You should use SettingWidget::EnumPasswordStorageType::{Store,AlwaysAsk,NotRequired} as index for all secret flags comboboxes throughout Plasma NM. Here you sorted them as AgentOwned, NotRequired, AlwaysAsk, but in other comboboxes in Plasma NM the order is AgentOwned, AlwaysAsk, NotRequired. If you use SettingWidget::EnumPasswordStorageType::{Store,AlwaysAsk,NotRequired} the order will be same for all comboboxes and there are a lot of them in Plasma NM.


- Lamarque Souza
Post by Jan Grulich
-----------------------------------------------------------
https://git.reviewboard.kde.org/r/123465/
-----------------------------------------------------------
(Updated April 22, 2015, 1:06 p.m.)
Review request for Network Management, Lukáš Tinkl and Lamarque Souza.
Bugs: 341070
http://bugs.kde.org/show_bug.cgi?id=341070
Repository: plasma-nm
Description
-------
This patch adds support for SSH VPN plugin (according to nm-connection-editor).
Diffs
-----
vpn/ssh/sshwidget.ui PRE-CREATION
vpn/ssh/sshwidget.h PRE-CREATION
vpn/ssh/sshwidget.cpp PRE-CREATION
vpn/ssh/sshauth.ui PRE-CREATION
vpn/ssh/sshauth.cpp PRE-CREATION
vpn/ssh/sshadvanced.ui PRE-CREATION
vpn/ssh/sshauth.h PRE-CREATION
vpn/ssh/ssh.cpp PRE-CREATION
vpn/ssh/ssh.h PRE-CREATION
vpn/ssh/nm-ssh-service.h PRE-CREATION
vpn/ssh/plasmanetworkmanagement_sshui.desktop PRE-CREATION
vpn/ssh/Messages.sh PRE-CREATION
vpn/ssh/CMakeLists.txt PRE-CREATION
vpn/CMakeLists.txt 714fff0
libs/editor/simpleipv4addressvalidator.h 9a4e270
libs/editor/simpleipv6addressvalidator.h 934dc99
Diff: https://git.reviewboard.kde.org/r/123465/diff/
Testing
-------
I tried to create a new SSH VPN connection in both (kde5-)nm-connection-editor and re-open it in another editor to check whether all values were stored/loaded properly.
Thanks,
Jan Grulich
Jan Grulich
2015-04-22 14:41:17 UTC
Permalink
Post by Jan Grulich
vpn/ssh/sshwidget.cpp, line 349
<https://git.reviewboard.kde.org/r/123465/diff/1/?file=362373#file362373line349>
You should use SettingWidget::EnumPasswordStorageType::{Store,AlwaysAsk,NotRequired} as index for all secret flags comboboxes throughout Plasma NM. Here you sorted them as AgentOwned, NotRequired, AlwaysAsk, but in other comboboxes in Plasma NM the order is AgentOwned, AlwaysAsk, NotRequired. If you use SettingWidget::EnumPasswordStorageType::{Store,AlwaysAsk,NotRequired} the order will be same for all comboboxes and there are a lot of them in Plasma NM.
My order is correct, all VPN plugins use AgentOwned (stored), AlwaysAsk, NotRequired, but you are right I should have used SettingWidget::EnumPasswordStorageType enum. It's a code copied from another VPN plugin and it sets correct values, but in a wrong order. I'll fix this also in the second VPN plugin I used as inspiration.


- Jan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123465/#review79341
-----------------------------------------------------------
Post by Jan Grulich
-----------------------------------------------------------
https://git.reviewboard.kde.org/r/123465/
-----------------------------------------------------------
(Updated Dub. 22, 2015, 2:41 odp.)
Review request for Network Management, Lukáš Tinkl and Lamarque Souza.
Bugs: 341070
http://bugs.kde.org/show_bug.cgi?id=341070
Repository: plasma-nm
Description
-------
This patch adds support for SSH VPN plugin (according to nm-connection-editor).
Diffs
-----
libs/editor/simpleipv4addressvalidator.h 9a4e270
libs/editor/simpleipv6addressvalidator.h 934dc99
vpn/CMakeLists.txt 714fff0
vpn/ssh/CMakeLists.txt PRE-CREATION
vpn/ssh/Messages.sh PRE-CREATION
vpn/ssh/nm-ssh-service.h PRE-CREATION
vpn/ssh/plasmanetworkmanagement_sshui.desktop PRE-CREATION
vpn/ssh/ssh.h PRE-CREATION
vpn/ssh/ssh.cpp PRE-CREATION
vpn/ssh/sshadvanced.ui PRE-CREATION
vpn/ssh/sshauth.h PRE-CREATION
vpn/ssh/sshauth.cpp PRE-CREATION
vpn/ssh/sshauth.ui PRE-CREATION
vpn/ssh/sshwidget.h PRE-CREATION
vpn/ssh/sshwidget.cpp PRE-CREATION
vpn/ssh/sshwidget.ui PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/123465/diff/
Testing
-------
I tried to create a new SSH VPN connection in both (kde5-)nm-connection-editor and re-open it in another editor to check whether all values were stored/loaded properly.
Thanks,
Jan Grulich
Jan Grulich
2015-04-22 14:41:05 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123465/
-----------------------------------------------------------

(Updated Dub. 22, 2015, 2:41 odp.)


Review request for Network Management, Lukáš Tinkl and Lamarque Souza.


Changes
-------

Updated patch.


Bugs: 341070
http://bugs.kde.org/show_bug.cgi?id=341070


Repository: plasma-nm


Description
-------

This patch adds support for SSH VPN plugin (according to nm-connection-editor).


Diffs (updated)
-----

libs/editor/simpleipv4addressvalidator.h 9a4e270
libs/editor/simpleipv6addressvalidator.h 934dc99
vpn/CMakeLists.txt 714fff0
vpn/ssh/CMakeLists.txt PRE-CREATION
vpn/ssh/Messages.sh PRE-CREATION
vpn/ssh/nm-ssh-service.h PRE-CREATION
vpn/ssh/plasmanetworkmanagement_sshui.desktop PRE-CREATION
vpn/ssh/ssh.h PRE-CREATION
vpn/ssh/ssh.cpp PRE-CREATION
vpn/ssh/sshadvanced.ui PRE-CREATION
vpn/ssh/sshauth.h PRE-CREATION
vpn/ssh/sshauth.cpp PRE-CREATION
vpn/ssh/sshauth.ui PRE-CREATION
vpn/ssh/sshwidget.h PRE-CREATION
vpn/ssh/sshwidget.cpp PRE-CREATION
vpn/ssh/sshwidget.ui PRE-CREATION

Diff: https://git.reviewboard.kde.org/r/123465/diff/


Testing
-------

I tried to create a new SSH VPN connection in both (kde5-)nm-connection-editor and re-open it in another editor to check whether all values were stored/loaded properly.


Thanks,

Jan Grulich
Lamarque Souza
2015-04-24 12:46:45 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123465/#review79433
-----------------------------------------------------------



vpn/ssh/sshauth.cpp (line 40)
<https://git.reviewboard.kde.org/r/123465/#comment54269>

Yesterday you pushed a huge patch to use Qt5's connect syntax. To make things consistent you should the same for this patch.



vpn/ssh/sshwidget.cpp (line 47)
<https://git.reviewboard.kde.org/r/123465/#comment54274>

Extra space in indentation.



vpn/ssh/sshwidget.cpp (line 65)
<https://git.reviewboard.kde.org/r/123465/#comment54275>

Nitpick: which code style for * and & in pointers and references do you use? Most of the time you use <space>*<space> and <space>&<nospace>. If I am not mistaken the code style used in KDE is always <space>*<nospace> and <space>&<nospace>.



vpn/ssh/sshwidget.cpp (line 162)
<https://git.reviewboard.kde.org/r/123465/#comment54270>

"type & NetworkManager::Setting::None" is always false. You should use "type == NetworkManager::Setting::None"



vpn/ssh/sshwidget.cpp (line 329)
<https://git.reviewboard.kde.org/r/123465/#comment54273>

This line can be moved to SshSettingWidget's constructor.



vpn/ssh/sshwidget.cpp (line 353)
<https://git.reviewboard.kde.org/r/123465/#comment54271>

The "always aks" and "not required" comments are redundant now.



vpn/ssh/sshwidget.cpp (line 364)
<https://git.reviewboard.kde.org/r/123465/#comment54272>

You can use SettingWidget::EnumPasswordStorageType::* here too.


- Lamarque Souza
Post by Jan Grulich
-----------------------------------------------------------
https://git.reviewboard.kde.org/r/123465/
-----------------------------------------------------------
(Updated April 22, 2015, 2:41 p.m.)
Review request for Network Management, Lukáš Tinkl and Lamarque Souza.
Bugs: 341070
http://bugs.kde.org/show_bug.cgi?id=341070
Repository: plasma-nm
Description
-------
This patch adds support for SSH VPN plugin (according to nm-connection-editor).
Diffs
-----
libs/editor/simpleipv4addressvalidator.h 9a4e270
libs/editor/simpleipv6addressvalidator.h 934dc99
vpn/CMakeLists.txt 714fff0
vpn/ssh/CMakeLists.txt PRE-CREATION
vpn/ssh/Messages.sh PRE-CREATION
vpn/ssh/nm-ssh-service.h PRE-CREATION
vpn/ssh/plasmanetworkmanagement_sshui.desktop PRE-CREATION
vpn/ssh/ssh.h PRE-CREATION
vpn/ssh/ssh.cpp PRE-CREATION
vpn/ssh/sshadvanced.ui PRE-CREATION
vpn/ssh/sshauth.h PRE-CREATION
vpn/ssh/sshauth.cpp PRE-CREATION
vpn/ssh/sshauth.ui PRE-CREATION
vpn/ssh/sshwidget.h PRE-CREATION
vpn/ssh/sshwidget.cpp PRE-CREATION
vpn/ssh/sshwidget.ui PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/123465/diff/
Testing
-------
I tried to create a new SSH VPN connection in both (kde5-)nm-connection-editor and re-open it in another editor to check whether all values were stored/loaded properly.
Thanks,
Jan Grulich
Jan Grulich
2015-04-24 13:23:07 UTC
Permalink
Post by Jan Grulich
vpn/ssh/sshwidget.cpp, line 65
<https://git.reviewboard.kde.org/r/123465/diff/3/?file=362480#file362480line65>
Nitpick: which code style for * and & in pointers and references do you use? Most of the time you use <space>*<space> and <space>&<nospace>. If I am not mistaken the code style used in KDE is always <space>*<nospace> and <space>&<nospace>.
I know it's not an excuse, but those parts are actually copied from other VPN plugins and either me or someone else who wrote them made this mistake before, but yeah, I should properly check it and follow the coding style. I also found out that KDevelop does wrong auto-completion for functions when using KDELibs coding style, switching to Qt fixes this issue.


- Jan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123465/#review79433
-----------------------------------------------------------
Post by Jan Grulich
-----------------------------------------------------------
https://git.reviewboard.kde.org/r/123465/
-----------------------------------------------------------
(Updated Dub. 24, 2015, 1:14 odp.)
Review request for Network Management, Lukáš Tinkl and Lamarque Souza.
Bugs: 341070
http://bugs.kde.org/show_bug.cgi?id=341070
Repository: plasma-nm
Description
-------
This patch adds support for SSH VPN plugin (according to nm-connection-editor).
Diffs
-----
vpn/ssh/sshwidget.ui PRE-CREATION
vpn/ssh/sshwidget.cpp PRE-CREATION
vpn/ssh/sshwidget.h PRE-CREATION
vpn/ssh/sshauth.ui PRE-CREATION
vpn/ssh/sshauth.cpp PRE-CREATION
vpn/ssh/sshauth.h PRE-CREATION
vpn/ssh/sshadvanced.ui PRE-CREATION
vpn/ssh/ssh.cpp PRE-CREATION
vpn/ssh/ssh.h PRE-CREATION
vpn/ssh/plasmanetworkmanagement_sshui.desktop PRE-CREATION
vpn/ssh/nm-ssh-service.h PRE-CREATION
vpn/ssh/Messages.sh PRE-CREATION
vpn/ssh/CMakeLists.txt PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/123465/diff/
Testing
-------
I tried to create a new SSH VPN connection in both (kde5-)nm-connection-editor and re-open it in another editor to check whether all values were stored/loaded properly.
Thanks,
Jan Grulich
Jan Grulich
2015-04-24 13:14:25 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123465/
-----------------------------------------------------------

(Updated Dub. 24, 2015, 1:14 odp.)


Review request for Network Management, Lukáš Tinkl and Lamarque Souza.


Changes
-------

Updated patch.


Bugs: 341070
http://bugs.kde.org/show_bug.cgi?id=341070


Repository: plasma-nm


Description
-------

This patch adds support for SSH VPN plugin (according to nm-connection-editor).


Diffs (updated)
-----

vpn/ssh/sshwidget.ui PRE-CREATION
vpn/ssh/sshwidget.cpp PRE-CREATION
vpn/ssh/sshwidget.h PRE-CREATION
vpn/ssh/sshauth.ui PRE-CREATION
vpn/ssh/sshauth.cpp PRE-CREATION
vpn/ssh/sshauth.h PRE-CREATION
vpn/ssh/sshadvanced.ui PRE-CREATION
vpn/ssh/ssh.cpp PRE-CREATION
vpn/ssh/ssh.h PRE-CREATION
vpn/ssh/plasmanetworkmanagement_sshui.desktop PRE-CREATION
vpn/ssh/nm-ssh-service.h PRE-CREATION
vpn/ssh/Messages.sh PRE-CREATION
vpn/ssh/CMakeLists.txt PRE-CREATION

Diff: https://git.reviewboard.kde.org/r/123465/diff/


Testing
-------

I tried to create a new SSH VPN connection in both (kde5-)nm-connection-editor and re-open it in another editor to check whether all values were stored/loaded properly.


Thanks,

Jan Grulich
Lamarque Souza
2015-04-29 13:29:36 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123465/#review79677
-----------------------------------------------------------



vpn/ssh/sshwidget.cpp (line 351)
<https://git.reviewboard.kde.org/r/123465/#comment54508>

type == NetworkManager::Setting::None

After fixing this issue ship it.


- Lamarque Souza
Post by Jan Grulich
-----------------------------------------------------------
https://git.reviewboard.kde.org/r/123465/
-----------------------------------------------------------
(Updated April 24, 2015, 1:14 p.m.)
Review request for Network Management, Lukáš Tinkl and Lamarque Souza.
Bugs: 341070
http://bugs.kde.org/show_bug.cgi?id=341070
Repository: plasma-nm
Description
-------
This patch adds support for SSH VPN plugin (according to nm-connection-editor).
Diffs
-----
vpn/ssh/sshwidget.ui PRE-CREATION
vpn/ssh/sshwidget.cpp PRE-CREATION
vpn/ssh/sshwidget.h PRE-CREATION
vpn/ssh/sshauth.ui PRE-CREATION
vpn/ssh/sshauth.cpp PRE-CREATION
vpn/ssh/sshauth.h PRE-CREATION
vpn/ssh/sshadvanced.ui PRE-CREATION
vpn/ssh/ssh.cpp PRE-CREATION
vpn/ssh/ssh.h PRE-CREATION
vpn/ssh/plasmanetworkmanagement_sshui.desktop PRE-CREATION
vpn/ssh/nm-ssh-service.h PRE-CREATION
vpn/ssh/Messages.sh PRE-CREATION
vpn/ssh/CMakeLists.txt PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/123465/diff/
Testing
-------
I tried to create a new SSH VPN connection in both (kde5-)nm-connection-editor and re-open it in another editor to check whether all values were stored/loaded properly.
Thanks,
Jan Grulich
Lamarque Souza
2015-04-29 13:29:42 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123465/#review79680
-----------------------------------------------------------

Ship it!


Ship It!

- Lamarque Souza
Post by Jan Grulich
-----------------------------------------------------------
https://git.reviewboard.kde.org/r/123465/
-----------------------------------------------------------
(Updated April 24, 2015, 1:14 p.m.)
Review request for Network Management, Lukáš Tinkl and Lamarque Souza.
Bugs: 341070
http://bugs.kde.org/show_bug.cgi?id=341070
Repository: plasma-nm
Description
-------
This patch adds support for SSH VPN plugin (according to nm-connection-editor).
Diffs
-----
vpn/ssh/sshwidget.ui PRE-CREATION
vpn/ssh/sshwidget.cpp PRE-CREATION
vpn/ssh/sshwidget.h PRE-CREATION
vpn/ssh/sshauth.ui PRE-CREATION
vpn/ssh/sshauth.cpp PRE-CREATION
vpn/ssh/sshauth.h PRE-CREATION
vpn/ssh/sshadvanced.ui PRE-CREATION
vpn/ssh/ssh.cpp PRE-CREATION
vpn/ssh/ssh.h PRE-CREATION
vpn/ssh/plasmanetworkmanagement_sshui.desktop PRE-CREATION
vpn/ssh/nm-ssh-service.h PRE-CREATION
vpn/ssh/Messages.sh PRE-CREATION
vpn/ssh/CMakeLists.txt PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/123465/diff/
Testing
-------
I tried to create a new SSH VPN connection in both (kde5-)nm-connection-editor and re-open it in another editor to check whether all values were stored/loaded properly.
Thanks,
Jan Grulich
Jan Grulich
2015-04-29 13:56:14 UTC
Permalink
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123465/
-----------------------------------------------------------

(Updated April 29, 2015, 1:56 p.m.)


Status
------

This change has been marked as submitted.


Review request for Network Management, Lukáš Tinkl and Lamarque Souza.


Changes
-------

Submitted with commit d76fb3dee7ed20545ae1bb3b2a2d2e78517f6698 by Jan Grulich to branch master.


Bugs: 341070
http://bugs.kde.org/show_bug.cgi?id=341070


Repository: plasma-nm


Description
-------

This patch adds support for SSH VPN plugin (according to nm-connection-editor).


Diffs
-----

vpn/ssh/sshwidget.ui PRE-CREATION
vpn/ssh/sshwidget.cpp PRE-CREATION
vpn/ssh/sshwidget.h PRE-CREATION
vpn/ssh/sshauth.ui PRE-CREATION
vpn/ssh/sshauth.cpp PRE-CREATION
vpn/ssh/sshauth.h PRE-CREATION
vpn/ssh/sshadvanced.ui PRE-CREATION
vpn/ssh/ssh.cpp PRE-CREATION
vpn/ssh/ssh.h PRE-CREATION
vpn/ssh/plasmanetworkmanagement_sshui.desktop PRE-CREATION
vpn/ssh/nm-ssh-service.h PRE-CREATION
vpn/ssh/Messages.sh PRE-CREATION
vpn/ssh/CMakeLists.txt PRE-CREATION

Diff: https://git.reviewboard.kde.org/r/123465/diff/


Testing
-------

I tried to create a new SSH VPN connection in both (kde5-)nm-connection-editor and re-open it in another editor to check whether all values were stored/loaded properly.


Thanks,

Jan Grulich

Loading...